From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C43DDA0C41; Fri, 16 Apr 2021 17:00:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5E734068A; Fri, 16 Apr 2021 17:00:58 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 0F8DC40150 for ; Fri, 16 Apr 2021 17:00:57 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id c123so24265318qke.1 for ; Fri, 16 Apr 2021 08:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WzreWJXu1k/a82wKMnVheEsTY18QgzVQJEuOB8nGa34=; b=MHk7S0rzd03iKx1zeX/Uzb6RmnZ9qE1EvMO82NDJjNR95tuE3AJunmkFJqumg+XKb0 JXG4Zj+lt/llngySVXrjY+TaDXeCQEG7NQV+dqi+DXksdKHOE7xJSmRbO497x9AAccNm O5X64LDtl5oU2ooUDbEW5buFEdAlYtdTFGYWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WzreWJXu1k/a82wKMnVheEsTY18QgzVQJEuOB8nGa34=; b=FUgJqgQD1MpnCHUjpTNMUMlkzgLSehG6iZueeDPWhSwqsqaTUJkh2UHAOFW6HE/rOM 6lv7jbObrkYstCGKjqkxdnQ508BVUl9/SI3/c4yKbIl8Dl3PpJpKZrG1z4hISJdJLokf rhr5dvZ6+SdUfKlZOnXXZUIqdn04XKgO6zDDpeSL5RAL4MXfxCekdLPw39qzpUQlBBxo H0k0Rkl19li7S3RH1LZ99jr1+ksDwW9J9u15rEz7maywSNxjA99qoZxLVerK57nxTX/E 07zTHw2/Gw0THtYqWHqG4cYTFOSJpnVEU6W58Mw43WtTOkI6QY0fUKMOFrQmDfXvboh1 iUGQ== X-Gm-Message-State: AOAM531I9ac2mz4pfMDYSCpeDI514+di+iiWqWePfFhJjTn83bBkIa2X Ji5giAvJtkeyo08H/tQJDeumLfxnCJo7xSmzTSlPAg== X-Google-Smtp-Source: ABdhPJyjsRSnrAN5iL5LIpJuhc0XWkZBzh1PaiRhFpPToAvW9CACQFAN2EPJ5exmr29xa86X16LaivZxqjDs8FrUgRk= X-Received: by 2002:a37:43cc:: with SMTP id q195mr9443397qka.455.1618585256050; Fri, 16 Apr 2021 08:00:56 -0700 (PDT) MIME-Version: 1.0 References: <1617940481-125528-1-git-send-email-bingz@nvidia.com> <1618501912-92525-2-git-send-email-bingz@nvidia.com> <4523824.l8Hmzzfj0I@thomas> In-Reply-To: <4523824.l8Hmzzfj0I@thomas> From: Ajit Khaparde Date: Fri, 16 Apr 2021 08:00:39 -0700 Message-ID: To: Thomas Monjalon Cc: Bing Zhao , Ori Kam , Ferruh Yigit , Andrew Rybchenko , Matan Azrad , Slava Ovsiienko , dpdk-dev , Gregory Etelson , Andrey Vesnovaty Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000041170605c0183f67" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000041170605c0183f67 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 16, 2021 at 12:03 AM Thomas Monjalon wrote: > > 15/04/2021 19:59, Ajit Khaparde: > > On Thu, Apr 15, 2021 at 8:52 AM Bing Zhao wrote: > > > There are two types of flow actions: > > > 1. the direct (normal) actions that could be created and stored > > > within a flow rule. Such action is tied to its flow rule and > > > cannot be reused. > > > 2. the indirect action, in the past, named shared_action. It is > > > created from a direct actioni, like count or rss, and then used > > > in the flow rules with an object handle. The PMD will take care > > > of the retrieve from indirect action to the direct action > > > when it is referenced. > [...] > > > The RTE_FLOW_ACTION_TYPE_SHARED is kept for now in order not to > > > break the ABI. All the implementations are changed by using > > > RTE_FLOW_ACTION_TYPE_INDIRECT. > > > > When I read this somehow indirect did not feel right. > > But I don't have a strong suggestion either. > > Since it is a context of action or actions maybe we use action_context? > > This is an action which is not directly described in the flow rule, > but in another object referenced by its handle. > It creates a level of indirection in the rule description. > I think the word "indirect" is accurate. Ok. Let's go with that. Acked-by: Ajit Khaparde > > > --00000000000041170605c0183f67--