From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87F55A0547; Wed, 27 Oct 2021 03:48:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E48D40DDA; Wed, 27 Oct 2021 03:48:16 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 5058E407FF for ; Wed, 27 Oct 2021 03:48:15 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id q127so683388iod.12 for ; Tue, 26 Oct 2021 18:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wl+3qDHqxvg2EktG1B+kg2L+Rq6ljx2cd0yEygaD9C0=; b=cxJ23fLJZDHP+rxM5v8tMpMTepZM881tA1IEixow5JJZf9/H6dwPfDhmYeEUqQuWJC lraYdH8adH24iVyGLBAW3q4Y5DmSYNdTyvAcpvojBIdeQY5oldUlf/zkf5X1kXORveZA 115kHY3V0Lj+FLvA7/RHL1MAWrd6iyt+3t6XE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wl+3qDHqxvg2EktG1B+kg2L+Rq6ljx2cd0yEygaD9C0=; b=EPjkyw58QQp3wEtOoiIIHVmiGJwhj9SgawGAPJwiuelBuODrJl5tdF2Sl3zfrdD3L/ gPdZH4YGFrd1fSdJdeKntvBxQgJPamrCVysqfrEV7AW4BgOBh4Z2peR01bMIcLaKnClS o1KzlV4Bk2cVYRD753DSATm22U0BShpo1D9s5dbuhLV/F4YjiBWof8h9wsyvWM0zH0om DYkyhXbt1NzxDBQB0xYq5d0jDKC/ptpdgH/7JGn1fbNBjZUQ5dcayeKaL2hLm7kuOlRG wYXBY3jXDNb+O5VqQPelwLGMN4MXnBXK+2kw+JS0faTBBhqACMwiRZbSWWTrjfOlp/Cl 6MLQ== X-Gm-Message-State: AOAM530DzWtTLk/tsSgNWbVnc/P+S8Q8eha7S/7tdU3WMKHeqsmdx3p7 mro1fIhplxr+GhHgs82OSFq7k5xMRyLoH1yVoP+C7Q== X-Google-Smtp-Source: ABdhPJxZH2tkZV+dW1bWoFJplhKKRaZqdvWhJtWx/MGsmjeaRyNPn9YUz2AKcUK2AFyQr4H7K17faCYTMOP6lxQHEqM= X-Received: by 2002:a02:cac8:: with SMTP id f8mr8215058jap.65.1635299294610; Tue, 26 Oct 2021 18:48:14 -0700 (PDT) MIME-Version: 1.0 References: <20211026051430.1389-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20211026051430.1389-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Tue, 26 Oct 2021 18:47:58 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS behavior on Thor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 25, 2021 at 9:54 PM Kalesh A P wrote: > > From: Kalesh AP > > Move the Rx queue state update before bnxt_setup_one_vnic() > is called. For Thor, rxq->rx_started and eth_dev->data->rx_queue_state[] > needs to be set for all queues before bnxt_hwrm_vnic_cfg() or > bnxt_vnic_rss_configure() are called. > > Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson > Signed-off-by: Kalesh AP > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 5a34bb9..668e3aa 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -790,6 +790,16 @@ static int bnxt_start_nic(struct bnxt *bp) > goto err_out; > } > > + for (j = 0; j < bp->rx_nr_rings; j++) { > + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; > + > + if (!rxq->rx_deferred_start) { > + bp->eth_dev->data->rx_queue_state[j] = > + RTE_ETH_QUEUE_STATE_STARTED; > + rxq->rx_started = true; > + } > + } > + > /* default vnic 0 */ > rc = bnxt_setup_one_vnic(bp, 0); > if (rc) > @@ -813,16 +823,6 @@ static int bnxt_start_nic(struct bnxt *bp) > } > } > > - for (j = 0; j < bp->rx_nr_rings; j++) { > - struct bnxt_rx_queue *rxq = bp->rx_queues[j]; > - > - if (!rxq->rx_deferred_start) { > - bp->eth_dev->data->rx_queue_state[j] = > - RTE_ETH_QUEUE_STATE_STARTED; > - rxq->rx_started = true; > - } > - } > - > rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); > if (rc) { > PMD_DRV_LOG(ERR, > -- > 2.10.1 >