From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD090A0533; Thu, 23 Jan 2020 00:23:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A5502BBE; Thu, 23 Jan 2020 00:23:46 +0100 (CET) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 516702BBE for ; Thu, 23 Jan 2020 00:23:45 +0100 (CET) Received: by mail-ot1-f67.google.com with SMTP id h9so989393otj.11 for ; Wed, 22 Jan 2020 15:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+F51gzgV4W3rmWQl+Ct4sYOFMi/hE+YBaQg+8tlZ5cA=; b=Gr2uAb1cOcB4Jkq6k/XBnf/KvMvmOT9GkTUy47BLCLr+A2rL9M87fPmvC3ZOF0OzpG HFh/Jye+CzZzczUUogF0Ajv1ybfXvE27OWnONH8cQx3b98O5HtMAAdd6977OgP62vBTz PvD+h7IkBmQQ/7dDBCK8+x9gMpyXFjNNIye1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+F51gzgV4W3rmWQl+Ct4sYOFMi/hE+YBaQg+8tlZ5cA=; b=KF59b9EbVWPrQgkOPaHDT4EI4pt1ZUIG2DxlVX35mNa6s3hj6Wzn425OmXmmr+mKir tsbszesG/a7BNPcfXdxttdCciXcTqR/kRdpHXdTIBFe0JWhxEdIlmLI/oTfDFShDBaGf mOkE/ho13t6ItIBAUMUa8RqD4DYBKzNUJHT8S5A9BivuytxXFELXzfBSZM2SNClEZO5K fhRI4B5ZTLxrnF0BqdGA77rgFrZrEPKN+MK9t9Cj6K2348WnK+xzFqxx1U8I8je/QBWn RSOTBZ7ceh2wut5zVy/ljokSF1hXLERPz9OM2hGkhk99p2h1tQMFoxFgBQZVUfM1cxYu h+jw== X-Gm-Message-State: APjAAAXK3edlZfAbPhYgEm3cFKr9Pms2RJkzlDdmdoM6dF37onwCkWdn EhnIPBUMxlA7lVsljePdNbQXAw9VK8zaXXGFHp5+KNW/HZQ= X-Google-Smtp-Source: APXvYqw7NTnIN6ZByJJqL8d1N2CvkwMVPRgFh1HY5EaYK7PibV4STFwOGWCOUvUVP3GHuF8fycnX4KMrpJ2LUMhCDEA= X-Received: by 2002:a9d:6e14:: with SMTP id e20mr9592270otr.283.1579735424209; Wed, 22 Jan 2020 15:23:44 -0800 (PST) MIME-Version: 1.0 References: <20200122004733.7194-1-stephen@networkplumber.org> <20200122231840.37215-1-ajit.khaparde@broadcom.com> In-Reply-To: <20200122231840.37215-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Wed, 22 Jan 2020 15:23:28 -0800 Message-ID: To: dpdk-dev Cc: Ferruh Yigit , Stephen Hemminger , Lance Richardson , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 22, 2020 at 3:18 PM Ajit Khaparde wrote: > From: Stephen Hemminger > > When the VLAN is stripped from the packet on receive the > driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf. > This is done correctly for normal receive in the bnxt driver > but was not being handled correctly in the new SSE code. > > Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") > Cc: lance.richardson@broadcom.com > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger > Reviewed-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. Thanks > --- > v1->v2: fixed the commit headline > > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > index 22d9f9e84..31457300a 100644 > --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > @@ -289,7 +289,8 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf > **rx_pkts, > (RX_PKT_CMPL_METADATA_VID_MASK | > RX_PKT_CMPL_METADATA_DE | > RX_PKT_CMPL_METADATA_PRI_MASK); > - mbuf->ol_flags |= PKT_RX_VLAN; > + mbuf->ol_flags |= > + PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED; > } > > bnxt_parse_csum(mbuf, rxcmp1); > -- > 2.21.0 (Apple Git-122.2) > >