From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BD32A04A6; Thu, 27 Jan 2022 17:57:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22034427A0; Thu, 27 Jan 2022 17:57:12 +0100 (CET) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by mails.dpdk.org (Postfix) with ESMTP id C468A4067C for ; Thu, 27 Jan 2022 17:57:10 +0100 (CET) Received: by mail-io1-f50.google.com with SMTP id p63so3455723iod.11 for ; Thu, 27 Jan 2022 08:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zRfWjgypdn10rCoaSYn7RhH3WjGtZ2dkcaT96BQ2LZM=; b=UjYnYtmFECD+CAJ/baYdqPaXR8xVzJ4HktZKqyAcOXTe8jrFJ6L5xhJVmFvrvUufN5 JAP9+p/W+EMJ5AjKnhI07MLl63e+8OUSZEaSM6uITrLsAbhMk1N+NLiK74n+bwDuDxpO zz6A3lO/FCxamG2L8alfxjriFiXl4ExHTAOhc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zRfWjgypdn10rCoaSYn7RhH3WjGtZ2dkcaT96BQ2LZM=; b=PrPSp/ifOgfcD4kLYpmzi5aK/fg2tCO0+yFNHQJyNcNDB+ZfEPDxaJhEaX8WBV5feE 4MxPFVK51JiiP71USRkFBoRRcNAnzgerK3NyE3TvQx/ogbplv9QDcASxHjIbuqcPq1DW UZUrdfL7py3XqwsWBc+O8ufvKEpbQmA3N41iTBIe7Ih3B+ET5c/m+8o2zdm4tXE22joU LftfMgDq+f3UX9jGOB/RrxhjrlnVrjSp8r1ehiRl5A7qlvidZOfP+0dyw8qks3eGiFcY itDMTX0YiL8CmTcVLyMx19Gq7bUOD2Sfi2IP66K9o1gYjrPpwAgRrmkWfnZu8u3BMmyc jF5g== X-Gm-Message-State: AOAM530ehKcwnxXDM+IRFIvPevkwxlFpSQxpAyU9QWc/3jSbgJ2yei0g Cmg7i2B3jJQjxFOEve8yDCMAh3uJ/xA+tO/NCuIPkA== X-Google-Smtp-Source: ABdhPJyn7siDKDBlB8eOn/nVfmKoC+uKobGcVLuIUW9kGryYfq5ruk6ZL8XuHS/+/mcc81XAbDe9sfyYtSY/zElpVP0= X-Received: by 2002:a05:6638:41a2:: with SMTP id az34mr484208jab.84.1643302629987; Thu, 27 Jan 2022 08:57:09 -0800 (PST) MIME-Version: 1.0 References: <20220109105851.734687-1-skori@marvell.com> <20220113102718.3167282-1-jerinj@marvell.com> <20220113102718.3167282-2-jerinj@marvell.com> <839ce0f4-3170-8f2d-c05b-46cf6a99553f@intel.com> <7a34c391-008c-d1a7-a554-2ef414eb9f74@intel.com> In-Reply-To: <7a34c391-008c-d1a7-a554-2ef414eb9f74@intel.com> From: Ajit Khaparde Date: Thu, 27 Jan 2022 08:56:53 -0800 Message-ID: Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options To: Ferruh Yigit Cc: Sunil Kumar Kori , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Xiaoyun Li , Aman Singh , Yuying Zhang , "thomas@monjalon.net" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "bruce.richardson@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , Satha Koteswara Rao Kottidi , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 27, 2022 at 2:40 AM Ferruh Yigit wrote: > > On 1/27/2022 7:13 AM, Sunil Kumar Kori wrote: > > > >> -----Original Message----- > >> From: Ferruh Yigit > >> Sent: Tuesday, January 25, 2022 11:07 PM > >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Xiaoyun > >> Li ; Aman Singh ; Yuying > >> Zhang > >> Cc: thomas@monjalon.net; ajit.khaparde@broadcom.com; > >> aboyer@pensando.io; andrew.rybchenko@oktetlabs.ru; > >> beilei.xing@intel.com; bruce.richardson@intel.com; chas3@att.com; > >> chenbo.xia@intel.com; ciara.loftus@intel.com; Devendra Singh Rawat > >> ; ed.czeck@atomicrules.com; > >> evgenys@amazon.com; grive@u256.net; g.singh@nxp.com; > >> zhouguoyang@huawei.com; haiyue.wang@intel.com; Harman Kalra > >> ; heinrich.kuhn@corigine.com; > >> hemant.agrawal@nxp.com; hyonkim@cisco.com; igorch@amazon.com; Igor > >> Russkikh ; jgrajcia@cisco.com; > >> jasvinder.singh@intel.com; jianwang@trustnetic.com; > >> jiawenwu@trustnetic.com; jingjing.wu@intel.com; johndale@cisco.com; > >> john.miller@atomicrules.com; linville@tuxdriver.com; keith.wiles@intel.com; > >> Kiran Kumar Kokkilagadda ; > >> oulijun@huawei.com; Liron Himi ; > >> longli@microsoft.com; mw@semihalf.com; spinler@cesnet.cz; > >> matan@nvidia.com; matt.peters@windriver.com; > >> maxime.coquelin@redhat.com; mk@semihalf.com; humin29@huawei.com; > >> Pradeep Kumar Nalla ; Nithin Kumar Dabilpuram > >> ; qiming.yang@intel.com; qi.z.zhang@intel.com; > >> Radha Chintakuntla ; rahul.lakkireddy@chelsio.com; > >> Rasesh Mody ; rosen.xu@intel.com; > >> sachin.saxena@oss.nxp.com; Satha Koteswara Rao Kottidi > >> ; Shahed Shaikh ; > >> shaibran@amazon.com; shepard.siegel@atomicrules.com; > >> asomalap@amd.com; somnath.kotur@broadcom.com; > >> sthemmin@microsoft.com; steven.webster@windriver.com; Sunil Kumar Kori > >> ; mtetsuyah@gmail.com; Veerasenareddy Burru > >> ; viacheslavo@nvidia.com; xiao.w.wang@intel.com; > >> cloud.wangxiaoyun@huawei.com; yisen.zhuang@huawei.com; > >> yongwang@vmware.com; xuanziyang2@huawei.com > >> Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based > >> pfc CLI options > >> > >> External Email > >> > >> ---------------------------------------------------------------------- > >> On 1/13/2022 10:27 AM, jerinj@marvell.com wrote: > >>> From: Sunil Kumar Kori > >>> > >>> Patch adds command line options to configure queue based priority flow > >>> control. > >>> > >>> - Syntax command is given as below: > >>> > >>> set pfc_queue_ctrl rx \ > >>> tx > >>> > >> > >> Isn't the order of the paramters odd, it is mixing Rx/Tx config, what about > >> ordering Rx and Tx paramters? > >> > > It's been kept like this to portray config for rx_pause and tx_pause separately i.e. mode and corresponding config. > > > > What do you mean 'separately'? You need to provide all arguments anyway, right? > > I was thinking first have the Rx arguments, later Tx, like: > > rx tx I think this grouping is better. > > Am I missing something, is there a benefit of what you did in this patch? > > >>> - Example command to configure queue based priority flow control > >>> on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause > >>> time 2047 > >>> > >>> testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047 > >>> > >>> Signed-off-by: Sunil Kumar Kori > >> > >> <...> >