From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dpdk-dev <dev@dpdk.org>,
yux.jiang@intel.com, Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix IPv4 checksum
Date: Mon, 2 Aug 2021 11:04:47 -0700 [thread overview]
Message-ID: <CACZ4nhuoZdAo5nP3gUKJrrJnAPvRyfKFsDkOYEzB0DbVvi4Krw@mail.gmail.com> (raw)
In-Reply-To: <20210802180011.7183-1-getelson@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2624 bytes --]
On Mon, Aug 2, 2021 at 11:00 AM Gregory Etelson <getelson@nvidia.com> wrote:
>
> UDP protocol reserves 0 checksum value for special purposes.
> Other protocols, like IPv4, TCP and SCTP must calculate checksum value
> in software or offload checksum calculation to hardware.
>
> If IPv4 TX checksum offload was off and header checksum was set to 0,
> testpmd csum engine did not calculate checksum value for IPv4, TCP and
> SCTP.
>
> The patch always calculates IPv4, TCP and SCTP TX checksums if it is
> not offloaded.
>
> Fixes: b2a9e4a855d0 ("app/testpmd: fix Tx checksum calculation for tunnel")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
I think this fixes Bug 768?
If yes, please add the tag "Bugzilla ID: 768" to the commit.
> ---
> app/test-pmd/csumonly.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index bd5ad64a57..607c889359 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -487,7 +487,7 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,
> } else {
> if (tx_offloads & DEV_TX_OFFLOAD_IPV4_CKSUM) {
> ol_flags |= PKT_TX_IP_CKSUM;
> - } else if (ipv4_hdr->hdr_checksum != 0) {
> + } else {
> ipv4_hdr->hdr_checksum = 0;
> ipv4_hdr->hdr_checksum =
> rte_ipv4_cksum(ipv4_hdr);
> @@ -519,7 +519,7 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,
> ol_flags |= PKT_TX_TCP_SEG;
> else if (tx_offloads & DEV_TX_OFFLOAD_TCP_CKSUM) {
> ol_flags |= PKT_TX_TCP_CKSUM;
> - } else if (tcp_hdr->cksum != 0) {
> + } else {
> tcp_hdr->cksum = 0;
> tcp_hdr->cksum =
> get_udptcp_checksum(l3_hdr, tcp_hdr,
> @@ -535,7 +535,7 @@ process_inner_cksums(void *l3_hdr, const struct testpmd_offload_info *info,
> if ((tx_offloads & DEV_TX_OFFLOAD_SCTP_CKSUM) &&
> ((ipv4_hdr->total_length & 0x3) == 0)) {
> ol_flags |= PKT_TX_SCTP_CKSUM;
> - } else if (sctp_hdr->cksum != 0) {
> + } else {
> sctp_hdr->cksum = 0;
> /* XXX implement CRC32c, example available in
> * RFC3309 */
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-08-02 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 18:00 Gregory Etelson
2021-08-02 18:04 ` Ajit Khaparde [this message]
2021-08-02 18:13 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2021-08-03 1:33 ` Ajit Khaparde
2021-08-04 9:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhuoZdAo5nP3gUKJrrJnAPvRyfKFsDkOYEzB0DbVvi4Krw@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).