Re: [dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

On Thu, Apr 30, 2020 at 3:34 AM Wisam Jaddo <wisamm@mellanox.com> wrote:

> Introduce new feature to dump memory statistics of each socket
> and a total for all before and after the creation.
>
> This will give two main advantage:
> 1- Check the memory consumption for large number of flows
> "insertion rate scenario alone"
>
> 2- Check that no memory leackage after doing insertion then
> deletion.
>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
> ---
>  app/test-flow-perf/main.c      | 69 ++++++++++++++++++++++++++++++++++
>  doc/guides/tools/flow-perf.rst |  6 ++-
>  2 files changed, 74 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
> index 7c11c0b577..95435910de 100644
> --- a/app/test-flow-perf/main.c
> +++ b/app/test-flow-perf/main.c
> @@ -62,6 +62,7 @@ static uint16_t flow_actions;
>  static uint8_t flow_attrs;
>  static volatile bool force_quit;
>  static volatile bool dump_iterations;
> +static volatile bool dump_socket_mem_flag;
>  static volatile bool delete_flag;
>  static struct rte_mempool *mbuf_mp;
>  static uint32_t nb_lcores;
> @@ -78,6 +79,7 @@ static void usage(char *progname)
>                 " iteration\n");
>         printf("  --deletion-rate: Enable deletion rate"
>                 " calculations\n");
> +       printf("  --dump-socket-mem: to dump all socket memory\n");
>
A nit.. keep the usage text consistent when it comes to lower/upper case.

--dump-iterations: To
                          ^
--deletion-rate: Enable
                      ^
--dump-socket-mem: to
                              ^

::snip::


>