From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A47A1A0352; Wed, 6 May 2020 06:11:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0294E1D62E; Wed, 6 May 2020 06:11:18 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id AE5CD1D629 for ; Wed, 6 May 2020 06:11:16 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id j4so302461otr.11 for ; Tue, 05 May 2020 21:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QYs1KkiQ54TfQ7XVxHAceHqWZ96/A+ZibKBlIY1cyrs=; b=JqpTihS9tAZYFHg4SeF645vPnjEsQif9reFkj7frV8t0Hoc9x+eZdrrIUNtoSwF2qs MywWtvJZkwLrCmA1BdsrNgWKC4ZZ9C549DwwO2wT3uMKqbIx4GhwpT5zq9JTaouemp60 oyoiLeUqkX1vKz3uMpsyE/Wp8AvF1Ac8sqha4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QYs1KkiQ54TfQ7XVxHAceHqWZ96/A+ZibKBlIY1cyrs=; b=mOpdlFSXPZ5T1gNfCDo5M1DAVBmfrYLhqofWKO4nUGrUJmPKPK9qBjIJPJHEuzEcQm ufn6pLqkb4A6w7JC8u+IV3yZl/X2xpbh2n+hLunCOLdQ75ocHl76b2vXwGEl9rmPzgOP obpQcCvoFolWFWBQ3f5TIcxM5a93Z81I5K0C33vJjlg9E1GNMHLxqJrAsU+POKlXWqGN PTJVuxXOmJt2ISX/38tKYw45ZolE9P2nVtqOW7q0mTdQdVnF32FkEP2sxYg2Z90hQxKn txkD1V9MMe/jPNo0hRk2xTqOt5dVrtl7fLxY8jeyArl9xGdgkpp6OLgwoeLL6R33vyF+ ihsg== X-Gm-Message-State: AGi0PubonJri8XIi0wKv5ogEDPJtgyk528asIqFwj9POjs6nY6fOTlJX 0AI5bozCI2jIIG3IPagOEXjsmdelf/Z43uQ6kTZppg== X-Google-Smtp-Source: APiQypICgsRcoAFWbWB1mNgmGW1gfDSavem1MrZq9NRepb+OCFhJ+8OqC9Hy07gukQO6Y000CZBsqs8WkUC3QC3p+Zc= X-Received: by 2002:a9d:170e:: with SMTP id i14mr5038504ota.283.1588738275809; Tue, 05 May 2020 21:11:15 -0700 (PDT) MIME-Version: 1.0 References: <20200430093249.6772-2-wisamm@mellanox.com> <20200430103341.1845-1-wisamm@mellanox.com> <20200430103341.1845-5-wisamm@mellanox.com> In-Reply-To: <20200430103341.1845-5-wisamm@mellanox.com> From: Ajit Khaparde Date: Tue, 5 May 2020 21:10:59 -0700 Message-ID: To: Wisam Jaddo Cc: dpdk-dev , jackmin@mellanox.com, Thomas Monjalon , Jerin Jacob , gerlitz.or@gmail.com, l.yan@epfl.ch, Suanming Mou Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 30, 2020 at 3:34 AM Wisam Jaddo wrote: > Introduce new feature to dump memory statistics of each socket > and a total for all before and after the creation. > > This will give two main advantage: > 1- Check the memory consumption for large number of flows > "insertion rate scenario alone" > > 2- Check that no memory leackage after doing insertion then > deletion. > > Signed-off-by: Suanming Mou > Signed-off-by: Wisam Jaddo > --- > app/test-flow-perf/main.c | 69 ++++++++++++++++++++++++++++++++++ > doc/guides/tools/flow-perf.rst | 6 ++- > 2 files changed, 74 insertions(+), 1 deletion(-) > > diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c > index 7c11c0b577..95435910de 100644 > --- a/app/test-flow-perf/main.c > +++ b/app/test-flow-perf/main.c > @@ -62,6 +62,7 @@ static uint16_t flow_actions; > static uint8_t flow_attrs; > static volatile bool force_quit; > static volatile bool dump_iterations; > +static volatile bool dump_socket_mem_flag; > static volatile bool delete_flag; > static struct rte_mempool *mbuf_mp; > static uint32_t nb_lcores; > @@ -78,6 +79,7 @@ static void usage(char *progname) > " iteration\n"); > printf(" --deletion-rate: Enable deletion rate" > " calculations\n"); > + printf(" --dump-socket-mem: to dump all socket memory\n"); > A nit.. keep the usage text consistent when it comes to lower/upper case. --dump-iterations: To ^ --deletion-rate: Enable ^ --dump-socket-mem: to ^ ::snip:: >