From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D87CA46142; Tue, 28 Jan 2025 18:54:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B22BF40615; Tue, 28 Jan 2025 18:54:44 +0100 (CET) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id DF1B440144 for ; Tue, 28 Jan 2025 18:54:42 +0100 (CET) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-467a1ee7ff2so57311881cf.0 for ; Tue, 28 Jan 2025 09:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738086882; x=1738691682; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ntvpmQNfHzN5g6IxfAkzhfvXyctcZ0j2C0juel2anFs=; b=Uh0YrYqPCo5F2vbetShNjhGLgklEJCp41Tdh8Xt94aA6v4iLCtbMv1k2XFUyYPpRCy kB3JM0ed5AcU6YFakD0J/FD/hmgePid5wISLrIvXi2tQPgKs2JSBay1z2xYd0dK57Udu g6CoQkKhfHWk1SW++x0x5PVifnUmLTR7K3pnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738086882; x=1738691682; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ntvpmQNfHzN5g6IxfAkzhfvXyctcZ0j2C0juel2anFs=; b=X6fgq2/9yRPfu761qvwNgSfimzzQDqhWRF6VibP7QNgAPO0fDGwm7kyNlDXAqHU1fN 4CLO2UKtQdzGvIKGtDFQmP8RIz58wPSEZOzIfsQFE61ohuOTJe9Ef43up/c0TckEv70+ XndxfwSc/+3UE3xkP0XjY+HrTJnscJkD6Gsq78OiLlcgHsjSBJlQ5bscAOeflk6MSXsk IbPgaU52npgW3UsgldqPfLXcSW3U4I56RpvnkN2oT0j18BZts0QGHAf877CCjtnMH+M8 6iJm4wf76NoLJ+k12wBatBhjTVyo4j0tWHSErpofgFrc/xjOqIBgBtRN6zQHPkQR5WZT rJkw== X-Gm-Message-State: AOJu0YzMAedtAK6002zB3GeGF1Hf1kUGrjBWa1ZT04wOepVNNy/KCAmB AaR/DGFdOMg4S8pVTfBM/yP0VOhd885NQbBfGcs3/G5W7ATxe38lYQlI1JwKwl3sBWnrOEpgT+o OW6lqPkvqexwPpDDPy6SMwIcnjiFr4bcDoFoj X-Gm-Gg: ASbGncsMLbJyE5+44VWmBWSyKsMWbj6fDEtolzOE0Y86HwGGG/EVbzTbvha8nEGqKz6 GkLny1rQOuLSls7w738lu8Dn66GRWGO81uY1AB+wUbqnGenqNiI/r2vmIcHAKD9OV1ffIkR999Q == X-Google-Smtp-Source: AGHT+IEpM1JbBUsY5Obqg4S5HXd1pS53MkHy2M25m3cdlK/4mk0EmsgREMwEq4vnQIF3bH7pH2E0HuzAb5MVQxgv8eI= X-Received: by 2002:a05:622a:1a0d:b0:467:45b7:c49f with SMTP id d75a77b69052e-46fd0b6886amr914691cf.40.1738086882103; Tue, 28 Jan 2025 09:54:42 -0800 (PST) MIME-Version: 1.0 References: <20250128174219.155796-1-stephen@networkplumber.org> In-Reply-To: <20250128174219.155796-1-stephen@networkplumber.org> From: Ajit Khaparde Date: Tue, 28 Jan 2025 09:54:26 -0800 X-Gm-Features: AWEUYZlSlnDBrAc1sMS0csRhDcDXiopKxW34LLqvkkShe3EUEhQdGi8fNhZZ9Ig Message-ID: Subject: Re: [PATCH] net/bnxt: remove unnecessary checks for null pointer To: Stephen Hemminger Cc: dev@dpdk.org, Somnath Kotur Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000037c21f062cc7e3e5" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000037c21f062cc7e3e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 28, 2025 at 9:42=E2=80=AFAM Stephen Hemminger wrote: > > The function rte_free() handles a NULL pointer as no-op. > This patch was automatically generated from nullfree.cocci script. > > Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 6 ++---- > drivers/net/bnxt/tf_ulp/ulp_mapper.c | 3 +-- > drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c | 6 ++---- > 3 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c b/drivers/net/bn= xt/tf_core/v3/tfc_tbl_scope.c > index 1770069295..f88299bbf7 100644 > --- a/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c > +++ b/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c > @@ -1668,10 +1668,8 @@ int tfc_tbl_scope_cpm_alloc(struct tfc *tfcp, uint= 8_t tsid, > return 0; > > cleanup: > - if (cmm_lkup !=3D NULL) > - rte_free(cmm_lkup); > - if (cmm_act !=3D NULL) > - rte_free(cmm_act); > + rte_free(cmm_lkup); > + rte_free(cmm_act); > > return rc; > } > diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_u= lp/ulp_mapper.c > index 2429ac2f1a..49cd6620dd 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c > @@ -1359,8 +1359,7 @@ ulp_mapper_key_recipe_tbl_deinit(struct bnxt_ulp_ma= pper_data *mdata) > recipes =3D mdata->key_recipe_info.recipes[dir][f= type]; > for (idx =3D 0; idx < mdata->key_recipe_info.num_= recipes; > idx++) { > - if (recipes[idx]) > - rte_free(recipes[idx]); > + rte_free(recipes[idx]); > } > rte_free(mdata->key_recipe_info.recipes[dir][ftyp= e]); > mdata->key_recipe_info.recipes[dir][ftype] =3D NU= LL; > diff --git a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c b/drivers/net/bnxt/tf_u= lp/ulp_sc_mgr.c > index 5fa8e240db..85b72f328c 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c > @@ -158,11 +158,9 @@ ulp_sc_mgr_deinit(struct bnxt_ulp_context *ctxt) > if (!ulp_sc_info) > return -EINVAL; > > - if (ulp_sc_info->stats_cache_tbl) > - rte_free(ulp_sc_info->stats_cache_tbl); > + rte_free(ulp_sc_info->stats_cache_tbl); > > - if (ulp_sc_info->read_data) > - rte_free(ulp_sc_info->read_data); > + rte_free(ulp_sc_info->read_data); > > rte_free(ulp_sc_info); > > -- > 2.45.2 > --00000000000037c21f062cc7e3e5 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIHWtjhosdxP1Do6UMu0N Kykq8oEuor6z+t8FaSSJUt9SMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI1MDEyODE3NTQ0MlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAkHVmjmg1/fnHFWcEBm4ccClItsORkuIovVLua 2GkmqqjFqS5oH6LK7wbWwtfltybbHBK4PVh6+PHp5lMRiamb3aO/osBGwJNjrvyY5iP1qmpjs8bg 5JySxlX71gJ5dAsf1eGUTKdhS+ayrsjVp8h3ZHOe6PHlzSr5Jp6n7xxL7CFVRADuyJ5cSM5b/6Cm ZuP44KFkFogHyv6X0kFDBZst94VsV+LSe8B6jDkOTp07/bdpiemRHzFwtd486E3081HKUXyg9UIS gQUgyZ0f3+3mJvl1dQkpxmzTlU+5YqQo8rxuiWhJgKV2ZdLQYmSH80lsDj1QKRVAhF1pqPXdbt9I --00000000000037c21f062cc7e3e5--