From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172]) by dpdk.org (Postfix) with ESMTP id 9DE025F2B for ; Mon, 26 Mar 2018 22:25:43 +0200 (CEST) Received: by mail-qt0-f172.google.com with SMTP id s2so21004853qti.2 for ; Mon, 26 Mar 2018 13:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fIw4F33fSzLBy2txOiyM+9PEU0W0zGwquevPpFfrafY=; b=ZHrIOtks2eyWGZJZMyl1oTlC/fq0peLacmw288rkvVLRbzo8SNRYGjQOn6T1Qh4gGS QpPAnLfhlN2Q4pEVnOwnh2xEJgiXWByJTq8Khodl5+Sjbr/qR1cWKJOkkSGD2PlsbFCK dsRJ3GdVtG3EuMMh+Iekdq444sny7tQt/hZEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fIw4F33fSzLBy2txOiyM+9PEU0W0zGwquevPpFfrafY=; b=aHhlIFfCYM3W1vjXD1XcQ5oEf1UxOXsC7SS1oEMWXY1ncF/tiryDwSRqXv0LGILuEY LPCfLP2doz9f6etFN+V4TAJZt7T13sfnHb80cHNNVyesYHL3dF12/dyFUB1KjX697svv Et/VC7irVp2QbUnhPUhnlDwC5DjkddI2Jwez4At7hXZ0nNsZvEWTTqTFA4cNdXcO+h2u 54S/wdRcOURwwNtXk6QPc2HFdWlV0y9qqUIspFraBCoxyfrj8nUSmUNCe+DyhbmCdyaM 9FL9SI4bzsWAroUSd3eQcxvINfiVxAMyT7lrzV0Tc/J/J9KGH2SlW7ZMU8BROJ4Gmu3A 3JrA== X-Gm-Message-State: AElRT7FQzvEgPlZPn4AstXFjK0ve0CSr/YLTpd5r/A05Q7HRneLREXCX z1ElMC9boarSgAfIMexWOFxEXxo3QVA5MHrBJjrHYg== X-Google-Smtp-Source: AG47ELuj1Gpw4L3vQvbuha7PnbH0jQos3spUgi1E537pxUqsknVY1gxykba/ViZktxdTS/rPuSUGvEeqYJANAr8jvM4= X-Received: by 10.200.68.90 with SMTP id m26mr53574188qtn.5.1522095943007; Mon, 26 Mar 2018 13:25:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.58.134 with HTTP; Mon, 26 Mar 2018 13:25:02 -0700 (PDT) In-Reply-To: <025ed639-19b5-a4ce-f1f8-739dd9852bf2@intel.com> References: <20180228221236.28288-1-ajit.khaparde@broadcom.com> <025ed639-19b5-a4ce-f1f8-739dd9852bf2@intel.com> From: Ajit Khaparde Date: Mon, 26 Mar 2018 13:25:02 -0700 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 20:25:43 -0000 On Mon, Mar 26, 2018 at 1:20 PM, Ferruh Yigit wrote: > On 2/28/2018 10:12 PM, Ajit Khaparde wrote: > > When the vnic_tpa_cfg HWRM command is sent to the FW, > > we are not passing the VNIC ID in case of disable. > > This can cause the FW to return an error. > > Correct VNIC ID needs to be passed for both enable and disable. > > Hi Ajit, > > Patch title doesn't tell what is actually fixed, after reading commit log= , > will > you be agree on following: > > "net/bnxt: fix LRO disable" > =E2=80=8BYes, Ferruh. This is fine.=E2=80=8B Thanks > > > > > Fixes: 0958d8b6435d ("net/bnxt: support LRO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.= c > > index b7843afe6..05663fedd 100644 > > --- a/drivers/net/bnxt/bnxt_hwrm.c > > +++ b/drivers/net/bnxt/bnxt_hwrm.c > > @@ -1517,12 +1517,12 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, > > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO | > > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_EC= N > | > > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_ > AGG_WITH_SAME_GRE_SEQ); > > - req.vnic_id =3D rte_cpu_to_le_32(vnic->fw_vnic_id); > > req.max_agg_segs =3D rte_cpu_to_le_16(5); > > req.max_aggs =3D > > rte_cpu_to_le_16(HWRM_VNIC_ > TPA_CFG_INPUT_MAX_AGGS_MAX); > > req.min_agg_len =3D rte_cpu_to_le_32(512); > > } > > + req.vnic_id =3D rte_cpu_to_le_32(vnic->fw_vnic_id); > > > > rc =3D bnxt_hwrm_send_message(bp, &req, sizeof(req)); > > > > > >