From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4F3F87CC4 for ; Thu, 1 Jun 2017 18:36:46 +0200 (CEST) Received: by mail-qk0-f181.google.com with SMTP id 19so40848086qke.2 for ; Thu, 01 Jun 2017 09:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vtYFXdNCtMamu2iK6dquE056Taukd1RgZGi1YoqcAkE=; b=Ci5CHg626l/hJj9x9KfH3+1mygswGDR2v89FfdVssluKz4JtBEXky9ueXeSsO6tCax X/yP4A1tBAleS4BaEQC/A1DPKdq3uJixGlMZ63X5ZyrRb5hoLkVsjQmE4gSM6A6thuOc s40o674f3abn6CpwzuXPJMii00bynvePaGV4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vtYFXdNCtMamu2iK6dquE056Taukd1RgZGi1YoqcAkE=; b=a4UH5G+bHe55BzzEHZNrUw1cOzUOgZ3LNALnbTSe9P/oFsLLLyb+/DwN9nxOZH39mx kpj8dhC2lOQm+4NrGaFWFIcpd9aCMt0EA+c5/2kYS5SHOVUO008M4xVeZpn1V78bkJqh azNcqvcaxr3FqCCMpLZAY6SKAGnA21NRiUIbeEX7o9VPZrut1ZiiCuAFVx/HTZD7ZM4h a6HXW6MuUu9LrkohB+P1hd09Y44FU2Dgrvp6p2guPp+Iotg+cWn1eylSMgP5ep3nVOmZ aFR/vScJkrsgbFq33D4K9CyVSQM3ciX9HkUwtTSCd5aNLalHa9foTBeA6TlONRm/h3nK 949Q== X-Gm-Message-State: AODbwcBavOSThSMBEhdAUHf7AOve6T8NBA7S/64C7hLTwPJd412CiR82 G0zc2TVdV7fwN06SuyYZEw/J+bwnqmzG X-Received: by 10.55.135.67 with SMTP id j64mr2779048qkd.151.1496335005794; Thu, 01 Jun 2017 09:36:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.52.165 with HTTP; Thu, 1 Jun 2017 09:36:05 -0700 (PDT) In-Reply-To: <5fac4171-de91-8953-2df3-b78b0708c439@intel.com> References: <5d0e287f-dfe9-3a41-695e-9af0d57d37c1@intel.com> <20170601030232.38677-1-ajit.khaparde@broadcom.com> <20170601030232.38677-23-ajit.khaparde@broadcom.com> <5fac4171-de91-8953-2df3-b78b0708c439@intel.com> From: Ajit Khaparde Date: Thu, 1 Jun 2017 11:36:05 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hurd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 22/26] net/bnxt: add code to determine the Rx status of VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 16:36:47 -0000 On Thu, Jun 1, 2017 at 7:28 AM, Ferruh Yigit wrote= : > Hi Ajit, > > On 6/1/2017 4:02 AM, Ajit Khaparde wrote: > > This patch adds code to determine the Rx status of a VF. > > It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates > > the VNIC count of the function to get the Rx status. > > > > Signed-off-by: Stephen Hurd > > Signed-off-by: Ajit Khaparde > > <...> > > > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > > +{ > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_info dev_info; > > + struct bnxt *bp; > > + > > + dev =3D &rte_eth_devices[port]; > > + if (!is_bnxt_supported(dev)) > > + return -ENOTSUP; > > + > > + rte_eth_dev_info_get(port, &dev_info); > > + bp =3D (struct bnxt *)dev->data->dev_private; > > + > > + return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count); > > +} > > I guess there is rebasing error here, this function left here and > causing a build error [1]. > (or function tries to sneak in within another patch :) > =E2=80=8BYes. It seems to have. I was actually trying to avoid this and com= pile testing at a minimum during each rebase step to make sure. But may be the warning message scrolled away. I am sending a new series. Thanks =E2=80=8B > > [1] > .../drivers/net/bnxt/rte_pmd_bnxt.c:639:5: error: no previous prototype > for function 'rte_pmd_bnxt_get_tx_drop_count' > [-Werror,-Wmissing-prototypes] > int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > ^ >