From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CF36A04AC; Tue, 1 Sep 2020 19:11:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66AE61C0B1; Tue, 1 Sep 2020 19:11:51 +0200 (CEST) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by dpdk.org (Postfix) with ESMTP id CC9B41C0AF for ; Tue, 1 Sep 2020 19:11:49 +0200 (CEST) Received: by mail-oi1-f177.google.com with SMTP id r64so951948oib.6 for ; Tue, 01 Sep 2020 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vh4uCLKGVSio24mFyfADRUnQzjIljrT/yVyS2QDb/jc=; b=fdSzjbRq0uo7Eic0fETqLjT3mGc03fpY1M87Fe3B9QA8pRwwrLOOEZr9ALT1j34lKk vKUorBuBTmppPfrEuhQaP3Y7IB146PTgz6sqLpSWkiaEdIB9otxTlNNUinbJHwkqNtU6 0z2sMQqFJ5rnymK549iI7XJakRMtXHCGhfCaA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vh4uCLKGVSio24mFyfADRUnQzjIljrT/yVyS2QDb/jc=; b=USt3DDuI5cwmfLTSNUibkXW6mB6obvfVT2r3aoUuOMiEDYpFwb6cEO5KoOaMacERem pYuFNU7xDMZD1xyUn6AnvvRY5SkXuW9TA7qus57lv+73T1L5VvkjUG7FBC85L1F7Nmax F+fJ5PzyWXIUrlY/xONxPUvSAIfqf9zk4nbC5u9PHe4KYmbbhFwPPXJcVGO6jJe5dHr0 xoDYHpivdmR9LyvENHOgWi9vQKkP8MKAdbgm5gbswG+eqNL7DQG8yn3iiHeu7RVsU1kr kMHhEqSWVCKaT7NhgoLATdnIQ0OKK1SIBUSBYpzUAFAaJEQ5d4dCMDCfOAJpcPB/HqQ6 wlAw== X-Gm-Message-State: AOAM530xFbist1sBEW22BNIyd7RQIap0KImqVcOybxrhvvP3ssj3jTbp 358lk7itFDiUl/RDWOVsVDQz+6iXctWYPVGwPQ3o2w== X-Google-Smtp-Source: ABdhPJzk4YnXB1hyzOd/SOyb6nbUVEVrMb+pqrc4YoJoRPes4s55Aj+cbN5T8jumV666RLJn2c43gAKPtbb7nY8CyPw= X-Received: by 2002:aca:f417:: with SMTP id s23mr1479929oih.168.1598980308712; Tue, 01 Sep 2020 10:11:48 -0700 (PDT) MIME-Version: 1.0 References: <20200821110330.214931-1-kirankumark@marvell.com> <20200901032708.58247-1-kirankumark@marvell.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 1 Sep 2020 10:11:32 -0700 Message-ID: To: Kiran Kumar Kokkilagadda Cc: Ferruh Yigit , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "orika@mellanox.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "rosen.xu@intel.com" , "beilei.xing@intel.com" , "jia.guo@intel.com" , Rasesh Mody , Shahed Shaikh , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "keith.wiles@intel.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@nxp.com" , "wei.zhao1@intel.com" , "johndale@cisco.com" , "hyonkim@cisco.com" , "chas3@att.com" , "matan@mellanox.com" , "shahafs@mellanox.com" , "viacheslavo@mellanox.com" , "rahul.lakkireddy@chelsio.com" , "grive@u256.net" , Liron Himi , "jingjing.wu@intel.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "somnath.kotur@broadcom.com" , "jasvinder.singh@intel.com" , "cristian.dumitrescu@intel.com" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v7 1/3] ethdev: add level support for RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 1, 2020 at 7:27 AM Kiran Kumar Kokkilagadda < kirankumark@marvell.com> wrote: > > > > -----Original Message----- > > From: Ferruh Yigit > > Sent: Tuesday, September 1, 2020 7:08 PM > > To: Kiran Kumar Kokkilagadda ; Thomas Monjalon > > ; Andrew Rybchenko > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > > orika@mellanox.com; xuanziyang2@huawei.com; > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > > rosen.xu@intel.com; beilei.xing@intel.com; jia.guo@intel.com; Rasesh > Mody > > ; Shahed Shaikh ; Nithin Kumar > > Dabilpuram ; qiming.yang@intel.com; > > qi.z.zhang@intel.com; keith.wiles@intel.com; hemant.agrawal@nxp.com; > > sachin.saxena@nxp.com; wei.zhao1@intel.com; johndale@cisco.com; > > hyonkim@cisco.com; chas3@att.com; matan@mellanox.com; > > shahafs@mellanox.com; viacheslavo@mellanox.com; > > rahul.lakkireddy@chelsio.com; grive@u256.net; Liron Himi > > ; jingjing.wu@intel.com; xavier.huwei@huawei.com; > > humin29@huawei.com; yisen.zhuang@huawei.com; > > ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com; > > jasvinder.singh@intel.com; cristian.dumitrescu@intel.com > > Subject: [EXT] Re: [dpdk-dev][PATCH v7 1/3] ethdev: add level support > for RSS > > offload types > > > > External Email > > > > ---------------------------------------------------------------------- > > On 9/1/2020 4:27 AM, kirankumark@marvell.com wrote: > > > From: Kiran Kumar K > > > > > > This patch reserves 2 bits as input selection to select Inner and > > > outer encapsulation level for RSS computation. It is combined with > > > existing > > > ETH_RSS_* to choose Inner or outer layers. > > > This functionality already exists in rte_flow through level parameter > > > in RSS action configuration rte_flow_action_rss. > > > > > > Signed-off-by: Kiran Kumar K > > > --- > > > V7 Changes: > > > * Re-worked to keep it in sync with rte_flow_action_rss and support > > > upto > > > 3 levels. > > > * Addressed testpmd review comments. > > > > > > lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > > > diff --git a/lib/librte_ethdev/rte_ethdev.h > > > b/lib/librte_ethdev/rte_ethdev.h index 70295d7ab..13e49bbd7 100644 > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > @@ -552,6 +552,33 @@ struct rte_eth_rss_conf { > > > #define RTE_ETH_RSS_L3_PRE64 (1ULL << 53) > > > #define RTE_ETH_RSS_L3_PRE96 (1ULL << 52) > > > > > > +/* > > > + * We use the following macros to combine with the above layers to > > > +choose > > > + * inner and outer layers or both for RSS computation. > > > + * bit 50 and 51 are reserved for this. > > > + */ > > > + > > > +/** level 0, requests the default behavior. Depending on the packet > > > + * type, it can mean outermost, innermost, anything in between or > even no > > RSS. > > > + * It basically stands for the innermost encapsulation level RSS > > > + * can be performed on according to PMD and device capabilities. > > > + */ > > > +#define ETH_RSS_LEVEL_0 (0ULL << 50) > > > > I can see from history how this is involved, but the 'ETH_RSS_LEVEL_0' > naming is > > not really clear what it is, the naming in v6 is more clear. > > > > What about following one: > > 0 -> LEVEL_PMD_DEFAULT > > 1 -> LEVEL_OUTER > > 2 -> LEVEL_INNER > > 3 -> LEVEL_INNER_OUTER > > > > This doesn't exactly match to rte_flow one, but closer than v6 one. This > ends > > with max level 2. And defines a way to say both inner and outer. > > This one looks good to me. If everyone is ok with the proposed changes, I > will send V8. > How about following one: 0 -> LEVEL_PMD_DEFAULT 1 -> LEVEL_OUTERMOST 2 -> LEVEL_INNERMOST This way we can avoid any ambiguity especially if stacked tunnel headers become real. 3 -> LEVEL_INNER_OUTER But I am not sure if INNER_OUTER has a use case. Alternatively, why not just add uint32_t level; just like in case of rte_flow_action_rss? It will break ABI but its 20.11. Thanks -Ajit > > > > > > + > > > +/** level 1, requests RSS to be performed on the outermost packet > > > + * encapsulation level. > > > + */ > > > +#define ETH_RSS_LEVEL_1 (1ULL << 50) > > > + > > > +/** level 2, requests RSS to be performed on the > > > + * specified inner packet encapsulation level, from outermost to > > > + * innermost (lower to higher values). > > > + */ > > > +#define ETH_RSS_LEVEL_2 (2ULL << 50) > > > > I can see you are trying to copy rte_flow usage, but this doesn't really > makes > > sense here. Where the value of the level is defined in this case? If not > defined > > how the PMD knows which level to use? > > > > > +#define ETH_RSS_LEVEL_MASK (3ULL << 50) > > > + > > > +#define ETH_RSS_LEVEL(rss_hf) ((rss_hf & ETH_RSS_LEVEL_MASK) >> 50) > > > + > > > /** > > > * For input set change of hash filter, if SRC_ONLY and DST_ONLY of > > > * the same level are used simultaneously, it is the same case as > > > -- > > > 2.25.1 > > > > >