From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F25D0A0C4D; Wed, 13 Oct 2021 04:26:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9733C40150; Wed, 13 Oct 2021 04:26:49 +0200 (CEST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id 8757640142 for ; Wed, 13 Oct 2021 04:26:48 +0200 (CEST) Received: by mail-io1-f53.google.com with SMTP id p68so1081063iof.6 for ; Tue, 12 Oct 2021 19:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LT5mWemErxvkxYzbSA7LCVrDdgeJVbFJy/7wFkrQewc=; b=VP0rnq1PK1n+FzsWZnMxWnZRT6qV9hOGS1jrOeSy3gJa7AHdRzbRFeXKH5+V0E0Mes OvtIqNqdfg3boFU6K0f4d9d2YgkWW0gS2C9VhbZfYvvyGPiEVwSRZQKrZWRU/c0rXuBZ O7GK+Q5YOLVHg12/IIEvqQe3bXxKejhvQOIyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LT5mWemErxvkxYzbSA7LCVrDdgeJVbFJy/7wFkrQewc=; b=yQxzRBcZjsgwxAvSQdb3FU0+vMs5Rz91lsyMzUwrjXl4XIly5b5O7qXfriVZGrha2L tEzNPQLYkhlor1Dk9ioSXlZhfx36AOJB0UGAmnRPLqCOg6vFaJAZG6fememq1cQfJlB6 uLnIIlmbY+CKcCtmRKLwm/Z/xWghNvShNDFBUg5bZi4MHLL/azYk23puGwu2x+yRB7LP 8MGWy4wUJscROj3lpcJKOm3kZhDCiE0vbXf/a6s5Ff3ODkICnLmyxY6oAA+WPJFK6TLp JsicI1cVm5Kb6V5uYDBG4v58BKV1YvKnAwNh9ozjGkHwJcHvPCy/lVHTP3nI5ZtcoyhE 1aTw== X-Gm-Message-State: AOAM531KY8ibzO++zPO+qsPD742J5qlPRl5OgYjNJtZ7s3lCagzwxl6Y K/VaETGuf16WUWr8rNpH76L1Lid7rzkl5Cl6n0uGTQ== X-Google-Smtp-Source: ABdhPJzePFR/4jVyzzBquhJifqW55k8mQVuM/kLcA8En/Cc0W6brTB713h758zwowKvm5aMxMwZaAuyPmw65aYu+CoE= X-Received: by 2002:a05:6638:40a1:: with SMTP id m33mr26084816jam.33.1634092007632; Tue, 12 Oct 2021 19:26:47 -0700 (PDT) MIME-Version: 1.0 References: <20211006044835.3936226-1-akozyrev@nvidia.com> <20211006044835.3936226-3-akozyrev@nvidia.com> <5aecc54e-3a11-bbc6-af93-5117f938ee18@oktetlabs.ru> In-Reply-To: From: Ajit Khaparde Date: Tue, 12 Oct 2021 19:26:31 -0700 Message-ID: To: Alexander Kozyrev Cc: Ivan Malov , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Ori Kam , "andrew.rybchenko@oktetlabs.ru" , "ferruh.yigit@intel.com" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000ab218405ce32b151" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000ab218405ce32b151 Content-Type: text/plain; charset="UTF-8" On Tue, Oct 12, 2021 at 6:25 PM Alexander Kozyrev wrote: > > > From: Ivan Malov On Wednesday, October 6, 2021 13:25 > > On 06/10/2021 07:48, Alexander Kozyrev wrote: > > > Treating every single flow rule as a completely independent and separate > > > entity negatively impacts the flow rules insertion rate. Oftentimes in an > > > application, many flow rules share a common structure (the same item > > mask > > > and/or action list) so they can be grouped and classified together. > > > This knowledge may be used as a source of optimization by a PMD/HW. > > > > > > The item template defines common matching fields (the item mask) > > without > > > values. The action template holds a list of action types that will be used > > > together in the same rule. The specific values for items and actions will > > > be given only during the rule creation. > > > > > > A table combines item and action templates along with shared flow rule > > > attributes (group ID, priority and traffic direction). This way a PMD/HW > > > can prepare all the resources needed for efficient flow rules creation in > > > the datapath. To avoid any hiccups due to memory reallocation, the > > maximum > > > number of flow rules is defined at table creation time. > > > > > > The flow rule creation is done by selecting a table, an item template > > > and an action template (which are bound to the table), and setting unique > > > values for the items and actions. For the life cycle of the template - Is a template supposed to be destroyed immediately after its use? Can there be multiple templates active at a time? In which case will the application maintain the templates? And how to identify one template from another? Or that will not be needed? > > > > > > Signed-off-by: Alexander Kozyrev > > > Suggested-by: Ori Kam > > > --- --000000000000ab218405ce32b151--