From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8449743A0B; Wed, 7 Feb 2024 05:49:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B84D402EE; Wed, 7 Feb 2024 05:49:56 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id AC83F402EC for ; Wed, 7 Feb 2024 05:49:54 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5cfd95130c6so93249a12.1 for ; Tue, 06 Feb 2024 20:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1707281394; x=1707886194; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=c4sIeGjvwPfDHtwHRfCNlmIRVaTG5sYujxkE/Xl3kpo=; b=Gq2yBMsnI4rfttat7jaCaZk4Qrge79apgNTtoBIEmLluknF8YtfnCfWcjKGoqgmUZ+ Lps4xPC6zgs3L9cLtu+dJs482nCLBXq6eqWDeFGZtIFawSEPI2JJSBm8sPehJDR4N4ZT 42udNvJFeH/6QHzFrAsB/B+hhI7cWANjuBH4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707281394; x=1707886194; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c4sIeGjvwPfDHtwHRfCNlmIRVaTG5sYujxkE/Xl3kpo=; b=Xq2v81O9mUGDIu6U8QktqTnvM9cV9zurczyZjnNeSu2XCfaAQxUxPJg3g7Rgrmd010 jRTq2U7Fw+6weowuLb/1u0YQOKQ3dJY7YcX1OCEFZQjS+tQJwSCIWfLgjwIvKjmbJsCT LsFB02ZCk0j3yS9dctcU7BjDhD7DqL1Zc6sJ6UK0uDARij9lLNFaVVCPCbXPU6xB2wVl GRw0aute/lXRNzQXss+U0zMFHBd3cIIk6F6H3xfWni7pSdJofJOyjPqaX6ETEoAhn7hL trL7Ayd2iBKUBhdzSavNlcZlcTtLL5qwl/CAXnrv0DFkE7HhD1kkwr40CGzd8yplNWs/ kutA== X-Forwarded-Encrypted: i=1; AJvYcCXysZVPj9yb0/jqoKP+7DAPdlmM7+/9NNfWFqN+QvWMMsik/nbgLZh7Fz92NS1YiX2JqoGWhzZDWwa9Bns= X-Gm-Message-State: AOJu0YyDVOnnFkYyNW3lXZgy7wSL89yq7lfFHFfeXP7ejT9kKBkpQP58 pHT6NpIw5j64kYZln7Jngfeqd7TuLZAYGNiML7J9WL0fmsHYx4Zf+8uM/ugwDi7FzHV/erB4hRn o14WS45JR15buWRexLZj8BS8pIvSPYozv4qQV X-Google-Smtp-Source: AGHT+IER3j+kLsxOm9q9OIEBVIR1JVEwg7j9A7PdbT7AaoedHxge2aYCBIWO2octLUftMFxDPfhMWoWcUM8LwV3t6MQ= X-Received: by 2002:a17:90a:6ba5:b0:296:1a66:bc64 with SMTP id w34-20020a17090a6ba500b002961a66bc64mr1638045pjj.40.1707281393396; Tue, 06 Feb 2024 20:49:53 -0800 (PST) MIME-Version: 1.0 References: <20240130112520.1971315-1-gavinl@nvidia.com> <20240130112520.1971315-2-gavinl@nvidia.com> <16740437.geO5KgaWL5@thomas> In-Reply-To: <16740437.geO5KgaWL5@thomas> From: Ajit Khaparde Date: Tue, 6 Feb 2024 20:49:36 -0800 Message-ID: Subject: Re: [RFC V1 1/1] net: extend VXLAN header to support more extensions To: Thomas Monjalon Cc: orika@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, Gavin Li , dev@dpdk.org, jiaweiw@nvidia.com, jerinj@marvell.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Jie Hai , Long Li , Dariusz Sosnowski , Hemant Agrawal , Maxime Coquelin Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000006a5150610c36d06" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000006a5150610c36d06 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 6, 2024 at 2:51=E2=80=AFPM Thomas Monjalon wrote: > > 30/01/2024 12:25, Gavin Li: > > In this patch, all the VXLAN extension header will be merged with VXLAN= as > > union if the overlapped field has different format among protocols. The > > existing VXLAN-GPE will be marked as deprecated and new extensions of > > VXLAN should be added to VXLAN instead of a new RTE item. > > So VXLAN GPE, GBP, and original ones will all use the same struct. > Asking confirmation to other reviewers: > - do we want to deprecate specific VXLAN GPE? For start, yes. > - do we want to plan for VXLAN GPE removal? Once deprecated, we can remove it. > > [...] > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > +* ethdev: The flow item ``RTE_FLOW_ITEM_TYPE_VXLAN_GPE`` is replaced w= ith ``RTE_FLOW_ITEM_TYPE_VXLAN``. > > + The item ``RTE_FLOW_ITEM_TYPE_VXLAN_GPE``, the struct ``rte_flow_ite= m_vxlan_gpe``, its mask ``rte_flow_item_vxlan_gpe_mask``, > > + and the header struct ``rte_vxlan_gpe_hdr`` with the macro ``RTE_ETH= ER_VXLAN_GPE_HLEN`` > > + will be removed in DPDK 25.11. > > [...] > > @@ -38,8 +38,65 @@ struct rte_vxlan_hdr { > > rte_be32_t vx_vni; /**< VNI (24) + Reserved (8)= . */ > > }; > > struct { > > - uint8_t flags; /**< Should be 8 (I flag). *= / > > - uint8_t rsvd0[3]; /**< Reserved. */ > > + union { > > + uint8_t flags; /**< Should be 8 (I = flag). */ > > + /* Flag bits defined by GPE */ > > + struct { > > +#if RTE_BYTE_ORDER =3D=3D RTE_LITTLE_ENDIAN > > + uint8_t flag_o:1, > > + flag_b:1, > > + flag_p:1, > > + flag_i_gpe:1, > > + flag_ver:2, > > + rsvd_gpe:2; > > +#elif RTE_BYTE_ORDER =3D=3D RTE_BIG_ENDIAN > > + uint8_t rsvd_gpe:2, > > + flag_ver:2, > > + flag_i_gpe:1, > > + flag_p:1, > > + flag_b:1, > > + flag_o:1; > > +#endif > > + }; > > + /* Flag bits defined by GBP */ > > + struct { > > +#if RTE_BYTE_ORDER =3D=3D RTE_LITTLE_ENDIAN > > + uint8_t rsvd_gbp1:3, > > + flag_i_gbp:1, > > + rsvd_gbp2:3, > > + flag_g:1; > > +#elif RTE_BYTE_ORDER =3D=3D RTE_BIG_ENDIAN > > + uint8_t flag_g:1, > > + rsvd_gbp1:3, > > + flag_i_gbp:1, > > + rsvd_gbp2:3; > > +#endif > > + }; > > + }; > > + union { > > + uint8_t rsvd0[3]; /**< Reserved. */ > > + /* Overlap with rte_vxlan_gpe_hdr which i= s deprecated.*/ > > + struct { > > + uint8_t rsvd0_gpe[2]; /**< Reserv= ed. */ > > + uint8_t proto; /**< Next prot= ocol. */ > > + }; > > + struct { > > +#if RTE_BYTE_ORDER =3D=3D RTE_LITTLE_ENDIAN > > + uint8_t rsvd0_gbp1:3, > > + policy_applied:1, > > + rsvd0_gbp2:2, > > + dont_learn:1, > > + rsvd0_gbp3:1; > > +#elif RTE_BYTE_ORDER =3D=3D RTE_BIG_ENDIAN > > + uint8_t rsvd0_gbp1:1, > > + dont_learn:1, > > + rsvd0_gbp2:2, > > + policy_applied:1, > > + rsvd0_gbp3:3; > > +#endif > > + uint16_t policy_id; > > + }; > > + }; > > uint8_t vni[3]; /**< VXLAN identifier. */ > > uint8_t rsvd1; /**< Reserved. */ > > }; > > Naming looks OK. +1 > Any different opinion? > > --00000000000006a5150610c36d06 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIFR22DGUl0BeGAOFFjxR N+VZRpCegeTBG5AQzQo7V/IyMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI0MDIwNzA0NDk1NFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBobRwAdKe1SSt6ARlTdqhLscrhyniLVCm/GNIy 6pkFoIyNzGUT0tFbnMNZmsL+zefa63Q9jCgRvt4P5StZRAJe7kkUV/cRJ8BbYibaOX/keYY7olN8 JrXVqIYqdRNjBPFcgKzOYYhZfczt1IWQNGKD5G3HHbbosfIkcA2IHl7ie4VaHHYgmFyh1p5IU9KV 9H5MQryJt2vSm97NnDOfRYrBdQdb095GxX00URTNcNSOZKrFXCSrriUe7EOgEQLLib3Cn0pY06n1 RWaZI9N0rgCGGQ7/y2za4dYDatSsRfXSHijZP9ysBKCllgzYGgHdh1Sp4tIJ0+qXhpmDGN1vrUVF --00000000000006a5150610c36d06--