From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation
Date: Mon, 18 Nov 2019 12:41:02 -0800 [thread overview]
Message-ID: <CACZ4nhvJREZxUps9R4Pt+D4rr=boixxSEQzTSa_bq50urcSn8w@mail.gmail.com> (raw)
In-Reply-To: <20191118203150.66895-1-ajit.khaparde@broadcom.com>
On Mon, Nov 18, 2019 at 12:32 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> When the number of Rx queues requested by the application is less than
> the number of pools calculated, we end up calling HWRM_VNIC_ALLOC with
> incorrect parameters. This causes the firmware to return an error.
> Fix the Rx queue pool calculation.
>
> Fixes: 10bb6ddc2984 ("net/bnxt: fix flow creation with non-consecutive
> group ids")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm
> ---
> drivers/net/bnxt/bnxt_rxq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
> index 94f105d34..457ebede0 100644
> --- a/drivers/net/bnxt/bnxt_rxq.c
> +++ b/drivers/net/bnxt/bnxt_rxq.c
> @@ -104,6 +104,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
> pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : pools;
> }
>
> + pools = RTE_MIN(pools, bp->rx_cp_nr_rings);
> nb_q_per_grp = bp->rx_cp_nr_rings / pools;
> bp->rx_num_qs_per_vnic = nb_q_per_grp;
> PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
> --
> 2.21.0 (Apple Git-122.2)
>
>
next prev parent reply other threads:[~2019-11-18 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 20:31 Ajit Khaparde
2019-11-18 20:41 ` Ajit Khaparde [this message]
2019-11-19 13:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhvJREZxUps9R4Pt+D4rr=boixxSEQzTSa_bq50urcSn8w@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).