From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A4FA0353; Mon, 18 Nov 2019 21:41:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54028CF3; Mon, 18 Nov 2019 21:41:21 +0100 (CET) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 1A09D9E4 for ; Mon, 18 Nov 2019 21:41:20 +0100 (CET) Received: by mail-ot1-f67.google.com with SMTP id u13so15770508ote.0 for ; Mon, 18 Nov 2019 12:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oA/NNLWmOGDN2duZmX8VIPxiPzWDGIzHjkeZY8u7elU=; b=BC5yBHSOscINbF4bXL8ZRiO0ptDhq3KzEp7b1ah2xilasxOwNcV7OPC0XwF+kaSNj8 ySK+asjKYFMhNQJ7DBgj4hqOiJJTv2Q49LeCiQYTclojHFW8Y+q4Lsu1mDpPYKLT09GE eIsb1J7u7a30JszZJ1cBDm3N0lub5/DAZyKdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oA/NNLWmOGDN2duZmX8VIPxiPzWDGIzHjkeZY8u7elU=; b=jQ5dsRudJ6dVGwM3ZuodG4SB20nhphgBgUkQJcB5277zprTsLT76wRYVChvsjBg9Vy x7RZeuNXslJFL2AHocyg6HwR8PCclnxTLRqx8jIfji33QVYhuxY87bNuO0A+uhNFtjuA Pz7HsRqMrt2bz+kvdGaUV24/DUTh19GDDnOZLQy+06IxR2VrC0dJQj3Uhmo4MBpkVPQv ScCRxKYZYBPqNR4xGu7XT0EFoyeT/x2Acc+d0RQD7aRaB45huJVlf7jO2cAcSVz1BVuA kpKYLHhKolKBBosV2zHtM1pMvwAx4kmSxLlm5JjN9YjGT79mrVGITl3Q5QQYfGas4Akq PRGA== X-Gm-Message-State: APjAAAVAOaRkvz9Q3eE5Fen2Cm1iSeY9XnW/SkJfA0FTL1RabcdZPju6 BjfuiB/b+oG0huHThijmDKh6FuZUZMx2ij1Mjsa5c2NL9Iw= X-Google-Smtp-Source: APXvYqwKFr+gBIrfGLj7F5+ymPrzSwZMwg5up2oKVsW4UsO+SoVYc5UkyhoLpBdLv6St8z5zyKUMqPlnzh3spHK4+J4= X-Received: by 2002:a9d:7a4a:: with SMTP id z10mr896164otm.283.1574109678808; Mon, 18 Nov 2019 12:41:18 -0800 (PST) MIME-Version: 1.0 References: <20191118203150.66895-1-ajit.khaparde@broadcom.com> In-Reply-To: <20191118203150.66895-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Mon, 18 Nov 2019 12:41:02 -0800 Message-ID: To: dpdk-dev Cc: Ferruh Yigit , Somnath Kotur Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 18, 2019 at 12:32 PM Ajit Khaparde wrote: > When the number of Rx queues requested by the application is less than > the number of pools calculated, we end up calling HWRM_VNIC_ALLOC with > incorrect parameters. This causes the firmware to return an error. > Fix the Rx queue pool calculation. > > Fixes: 10bb6ddc2984 ("net/bnxt: fix flow creation with non-consecutive > group ids") > > Signed-off-by: Ajit Khaparde > Reviewed-by: Somnath Kotur > Patch applied to dpdk-next-net-brcm > --- > drivers/net/bnxt/bnxt_rxq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c > index 94f105d34..457ebede0 100644 > --- a/drivers/net/bnxt/bnxt_rxq.c > +++ b/drivers/net/bnxt/bnxt_rxq.c > @@ -104,6 +104,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp) > pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : pools; > } > > + pools = RTE_MIN(pools, bp->rx_cp_nr_rings); > nb_q_per_grp = bp->rx_cp_nr_rings / pools; > bp->rx_num_qs_per_vnic = nb_q_per_grp; > PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n", > -- > 2.21.0 (Apple Git-122.2) > >