* [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation
@ 2020-04-24 11:00 Somnath Kotur
2020-04-24 17:58 ` Ajit Khaparde
0 siblings, 1 reply; 4+ messages in thread
From: Somnath Kotur @ 2020-04-24 11:00 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
Max Rx Ring count could be < Max stat contexts. While accounting
for stat contexts, this should be also considered and
the max ring count adjusted accordingly.
Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray devices")
Cc: stable@dpdk.org
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 586d3f5..12fed1e 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -653,10 +653,10 @@ struct bnxt {
#define MAX_STINGRAY_RINGS 128U
/* For sake of symmetry, max Tx rings == max Rx rings, one stat ctx for each */
#define BNXT_MAX_RX_RINGS(bp) \
- (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings, \
+ (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings / 2U, \
MAX_STINGRAY_RINGS), \
bp->max_stat_ctx / 2U) : \
- RTE_MIN(bp->max_rx_rings, \
+ RTE_MIN(bp->max_rx_rings / 2U, \
bp->max_stat_ctx / 2U))
#define BNXT_MAX_TX_RINGS(bp) \
(RTE_MIN((bp)->max_tx_rings, BNXT_MAX_RX_RINGS(bp)))
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation
2020-04-24 11:00 [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation Somnath Kotur
@ 2020-04-24 17:58 ` Ajit Khaparde
0 siblings, 0 replies; 4+ messages in thread
From: Ajit Khaparde @ 2020-04-24 17:58 UTC (permalink / raw)
To: Somnath Kotur; +Cc: dpdk-dev, Ferruh Yigit
On Fri, Apr 24, 2020 at 4:04 AM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> Max Rx Ring count could be < Max stat contexts. While accounting
> for stat contexts, this should be also considered and
> the max ring count adjusted accordingly.
>
> Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray
> devices")
> Cc: stable@dpdk.org
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index 586d3f5..12fed1e 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -653,10 +653,10 @@ struct bnxt {
> #define MAX_STINGRAY_RINGS 128U
> /* For sake of symmetry, max Tx rings == max Rx rings, one stat ctx for
> each */
> #define BNXT_MAX_RX_RINGS(bp) \
> - (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings, \
> + (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings / 2U, \
> MAX_STINGRAY_RINGS), \
> bp->max_stat_ctx / 2U) : \
> - RTE_MIN(bp->max_rx_rings, \
> + RTE_MIN(bp->max_rx_rings / 2U, \
> bp->max_stat_ctx / 2U))
> #define BNXT_MAX_TX_RINGS(bp) \
> (RTE_MIN((bp)->max_tx_rings, BNXT_MAX_RX_RINGS(bp)))
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation
@ 2020-06-10 11:43 Somnath Kotur
2020-06-10 11:56 ` Somnath Kotur
0 siblings, 1 reply; 4+ messages in thread
From: Somnath Kotur @ 2020-06-10 11:43 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
Max Rx Ring count could be < Max stat contexts. While accounting
for stat contexts, this should be also considered and
the max ring count adjusted accordingly.
Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray devices")
Cc: stable@dpdk.org
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 586d3f5..12fed1e 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -653,10 +653,10 @@ struct bnxt {
#define MAX_STINGRAY_RINGS 128U
/* For sake of symmetry, max Tx rings == max Rx rings, one stat ctx for each */
#define BNXT_MAX_RX_RINGS(bp) \
- (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings, \
+ (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings / 2U, \
MAX_STINGRAY_RINGS), \
bp->max_stat_ctx / 2U) : \
- RTE_MIN(bp->max_rx_rings, \
+ RTE_MIN(bp->max_rx_rings / 2U, \
bp->max_stat_ctx / 2U))
#define BNXT_MAX_TX_RINGS(bp) \
(RTE_MIN((bp)->max_tx_rings, BNXT_MAX_RX_RINGS(bp)))
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation
2020-06-10 11:43 Somnath Kotur
@ 2020-06-10 11:56 ` Somnath Kotur
0 siblings, 0 replies; 4+ messages in thread
From: Somnath Kotur @ 2020-06-10 11:56 UTC (permalink / raw)
To: dev; +Cc: Ferruh Yigit
On Wed, Jun 10, 2020 at 5:18 PM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> Max Rx Ring count could be < Max stat contexts. While accounting
> for stat contexts, this should be also considered and
> the max ring count adjusted accordingly.
>
> Fixes: f03e66cb64ce ("net/bnxt: limit queue count for NS3/Stingray devices")
> Cc: stable@dpdk.org
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
> drivers/net/bnxt/bnxt.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
> index 586d3f5..12fed1e 100644
> --- a/drivers/net/bnxt/bnxt.h
> +++ b/drivers/net/bnxt/bnxt.h
> @@ -653,10 +653,10 @@ struct bnxt {
> #define MAX_STINGRAY_RINGS 128U
> /* For sake of symmetry, max Tx rings == max Rx rings, one stat ctx for each */
> #define BNXT_MAX_RX_RINGS(bp) \
> - (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings, \
> + (BNXT_STINGRAY(bp) ? RTE_MIN(RTE_MIN(bp->max_rx_rings / 2U, \
> MAX_STINGRAY_RINGS), \
> bp->max_stat_ctx / 2U) : \
> - RTE_MIN(bp->max_rx_rings, \
> + RTE_MIN(bp->max_rx_rings / 2U, \
> bp->max_stat_ctx / 2U))
> #define BNXT_MAX_TX_RINGS(bp) \
> (RTE_MIN((bp)->max_tx_rings, BNXT_MAX_RX_RINGS(bp)))
> --
> 1.8.3.1
>
Sorry, kindly ignore this patch, got sent out by accident (prev history)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-10 11:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 11:00 [dpdk-dev] [PATCH] net/bnxt: fix max ring count calculation Somnath Kotur
2020-04-24 17:58 ` Ajit Khaparde
2020-06-10 11:43 Somnath Kotur
2020-06-10 11:56 ` Somnath Kotur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).