From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81546A00C5; Thu, 7 May 2020 05:14:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60C001D9A2; Thu, 7 May 2020 05:14:18 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 3D2E51D949 for ; Thu, 7 May 2020 05:14:17 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id m13so3342964otf.6 for ; Wed, 06 May 2020 20:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5Ylh2/ckOn4sNdY51HmQJCqv1YJ82bBPo02oGNhNl78=; b=WY3KfBXCUbolJWLAkQACsuZPXujMtbpkLxry6jqdfuM2Dghtweu4javiKR98//ly4D PUr9egiLmwpZIZ/675+C8dKQU/Rj/EcL6ga7ngAdnXSqxSAhAna7F9I7PU6hRQQmCpKz m5ecIV0KR4Ryx30+7MmVUds/zZH5spxCPSvyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Ylh2/ckOn4sNdY51HmQJCqv1YJ82bBPo02oGNhNl78=; b=QIIaUa6KV3N0uOHZLmxAYcc6C/9ZOSP5yTQq3M2JOd3tJdxI1yGwaxXCL4gPZZraTT VFG5F34JzPi4y9ZSva96EOg38p1yCZJliAeCV5FN7nZxzgA83dWq3OCC9W6Tx5F838OC BQGslf7rJRML/ixb80izgCLK6cCfgOS9DCJsfmndrIdcTYtRim0GPJbKmNs9flUuuob5 19YCjZXGsiYKxF+vWyWUt4zqn9flVTwqJRHABBR8WRjBJ5SJSb5m+JA5Hfd37GlXcKwr RHQGu4JRxUR7NifiBWk1tfumLlNmOTVae6OMNYaP7KhRGWMds4Tk1CUEbp3WobggQzoK ny3w== X-Gm-Message-State: AGi0PubcyjQNLZ9/pPd9eqzlF1R8wLf1QTut2bGUGvISBZHR5Zn65CvC cX/ik7pcGG2wCKkN1tne0Dba3fCU1l/2aEmuihWLQw== X-Google-Smtp-Source: APiQypJxOYqhh7axHPTmBOtPst0wYgXGTdmCWeR12b/Txlyy+eEUPcYr6u6TvSkxfjdz/9sP0mGGnYhbCUCXV73DOEU= X-Received: by 2002:a9d:170e:: with SMTP id i14mr8960805ota.283.1588821256326; Wed, 06 May 2020 20:14:16 -0700 (PDT) MIME-Version: 1.0 References: <20200505191738.58219-1-ajit.khaparde@broadcom.com> <20200505191738.58219-2-ajit.khaparde@broadcom.com> <6d0bac2f-7295-3f2a-9100-447ce60e45dc@intel.com> <477e4980-b8c3-cc36-195e-735d440ddb48@intel.com> In-Reply-To: <477e4980-b8c3-cc36-195e-735d440ddb48@intel.com> From: Ajit Khaparde Date: Wed, 6 May 2020 20:14:00 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Kishore Padmanabha , Michael Baucom , John McNamara Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 5:09 PM Ferruh Yigit wrote: > On 5/6/2020 11:14 PM, Ajit Khaparde wrote: > > > > > > On Wed, May 6, 2020 at 2:17 AM Ferruh Yigit > > wrote: > > > > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > > From: Kishore Padmanabha > > > > > > > > Fix a buffer overrun issue spotted by coverity while accessing > > > the array ulp_device_params. > > > > If it is spotted by coverity, is there a coverity issue id? > > > > Yes. But in an internal scan. > > I haven't seen anything reported in this area in the latest coverity > report > > against 20.05-rc1. > > Thanks for checking, I wonder what is the difference so that it is not in > public > converity. > Can you please mention in commit log that it is internal coverity, to > prevent > same confusion later? > Done. Sent a v2 as well. > > > > > > > > > > > Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") > > > > > > Signed-off-by: Kishore Padmanabha > > > > > Reviewed-by: Michael Baucom > > > > > Reviewed-by: Ajit Khaparde > > > > > --- > > > drivers/net/bnxt/tf_ulp/ulp_template_db.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > b/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > > index 86384169f..e89aefad4 100644 > > > --- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > > +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > > @@ -321,7 +321,7 @@ struct bnxt_ulp_def_ident_info > ulp_def_ident_tbl[] = { > > > } > > > }; > > > > > > -struct bnxt_ulp_device_params ulp_device_params[] = { > > > +struct bnxt_ulp_device_params > ulp_device_params[BNXT_ULP_DEVICE_ID_LAST] = { > > > [BNXT_ULP_DEVICE_ID_WH_PLUS] = { > > > .global_fid_enable = BNXT_ULP_SYM_YES, > > > .byte_order = (enum bnxt_ulp_byte_order) > > > > > > >