From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02326A0C43; Thu, 21 Oct 2021 20:28:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D11CB4003F; Thu, 21 Oct 2021 20:28:42 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id CA1464003E for ; Thu, 21 Oct 2021 20:28:40 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id a8so1659134ilj.10 for ; Thu, 21 Oct 2021 11:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M23bD7OrRB5xsj1f31RNqDKMsg+YYrlrddRLkRzNlPI=; b=d9tm5562JwJUCt/Bkj9jaIqsiTY1LqYS65a+VvgAJPojo78jq9f+FuCVocuR1ddih5 xNuFBifMDRk7T/f5sztQ7jdxe3xOiaAwE2lkbtvGt0KbSnix7EFFb9CconLB0rJNbhBF 1r26K82xUqFJKrZ9SG9oaTnI/Vx9/VNhWx44o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M23bD7OrRB5xsj1f31RNqDKMsg+YYrlrddRLkRzNlPI=; b=IoygtnUcrYvIrYlOqZZxU6qHhNSp7d/lP/qGAZlfc/sLw8coB2aTSnA+LSTZJWfEIb JkIW+TX+9SXFPJs6H/ZbAM3ItIPV9kHIX6DdMkX+IEHVLugSP53fBxbfJOoIOHahW0vd 31R8OLsDYOY+oBaGF4NhwhsEvcSHfP9e2cmLy4JFZV+AiVnzkjvrPLK8jmes1a27I5J9 9zM2tTFX7QPOWMJgrN1VYeB7dT4W1akvrfRDOCyqBVfTqVsKUzO11bfan9cEbFmEA3a4 TK+74uU7u4ZSMtgHJlirBuWZKEv0EaoPP9jybpGlO6/zgG/jfcnlCFXBz9CCTZ5Xu8i1 j0FA== X-Gm-Message-State: AOAM531Jse3lIRDElsFQ+LdnpDXpBKUiJwy625DiMrApeR+hovcuJJ4H 6D8VUJqO9iwxdqkCikschTT6ZG8gglCg2tFzECDuTA== X-Google-Smtp-Source: ABdhPJy8ikJi9A1BmqQ1LKQczU5EAu3sVC2QrF3w2Y02aEXk24tZ6iQZWKxgLJ/6P/ObpzXbv0EWlnDjviDCLZ6g07U= X-Received: by 2002:a05:6e02:1bc8:: with SMTP id x8mr4759760ilv.80.1634840920161; Thu, 21 Oct 2021 11:28:40 -0700 (PDT) MIME-Version: 1.0 References: <20211019123722.3414694-1-dkozlyuk@nvidia.com> <20211021063503.3632732-1-dkozlyuk@nvidia.com> <20211021063503.3632732-3-dkozlyuk@nvidia.com> In-Reply-To: <20211021063503.3632732-3-dkozlyuk@nvidia.com> From: Ajit Khaparde Date: Thu, 21 Oct 2021 11:28:23 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 2/6] ethdev: add capability to keep shared objects on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 20, 2021 at 11:35 PM Dmitry Kozlyuk wrote: > > rte_flow_action_handle_create() did not mention what happens > with an indirect action when a device is stopped and started again. > It is natural for some indirect actions, like counter, to be persistent. > Keeping others at least saves application time and complexity. > However, not all PMDs can support it, or the support may be limited > by particular action kinds, that is, combinations of action type > and the value of the transfer bit in its configuration. > > Add a device capability to indicate if at least some indirect actions > are kept across the above sequence. Without this capability the behavior > is still unspecified, and application is required to destroy > the indirect actions before stopping the device. > In the future, indirect actions may not be the only type of objects > shared between flow rules. The capability bit intends to cover all > possible types of such objects, hence its name. > > Declare that the application can test for the persistence > of a particular indirect action kind by attempting to create > an indirect action of that kind when the device is stopped > and checking for the specific error type. > This is logical because if the PMD can to create an indirect action > when the device is not started and use it after the start happens, > it is natural that it can move its internal flow shared object > to the same state when the device is stopped and restore the state > when the device is started. > > Indirect action persistence across a reconfigurations is not required. > In case a PMD cannot keep the indirect actions across reconfiguration, > it is allowed just to report an error. > Application must then flush the indirect actions before attempting it. > > Signed-off-by: Dmitry Kozlyuk Acked-by: Ajit Khaparde >