From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Yuan Linsi <yuanlinsi01@baidu.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
Date: Thu, 30 Apr 2020 11:29:06 -0700 [thread overview]
Message-ID: <CACZ4nhvWnFrRgS6pb8+EkQh9dWenEOLnAAu1qrdG7bYM6-o51w@mail.gmail.com> (raw)
In-Reply-To: <CADyeNEBsh0Vd15CgdZrW6ORkfYfoNobbiU2iRKiEC6bcAUwAcA@mail.gmail.com>
On Thu, Apr 30, 2020 at 6:45 AM Lance Richardson <
lance.richardson@broadcom.com> wrote:
> On Thu, Apr 30, 2020 at 9:37 AM Yuan Linsi <yuanlinsi01@baidu.com> wrote:
> >
> > From: yuanlinsi01 <yuanlinsi01@baidu.com>
> >
> > We see a stack smashing as a result of defensive code missing. Once the
> > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to
> > zero after doing a floor align, and we can not exit the following
> > receiving packets loop. And the buffers will be overwrite, then the
> > stack frame was ruined.
> >
> > Fix the problem by adding defensive code, once the nb_pkts is zero, just
> > directly return with no packets.
> >
> > Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: yuanlinsi01 <yuanlinsi01@baidu.com>
> > Signed-off-by: rongdongsheng <rongdongsheng@baidu.com>
>
> Thanks for the fix!
>
> Acked-by: Lance Richardson <lance.richardson@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
next prev parent reply other threads:[~2020-04-30 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 13:37 Yuan Linsi
2020-04-30 13:45 ` Lance Richardson
2020-04-30 18:29 ` Ajit Khaparde [this message]
2020-04-30 23:55 ` Ferruh Yigit
2020-05-05 3:42 ` Ajit Khaparde
2020-05-06 3:18 ` [dpdk-dev] 答复: " Yuan,Linsi
-- strict thread matches above, loose matches on Subject: below --
2020-05-06 3:28 [dpdk-dev] " Yuan Linsi
2020-05-06 5:26 ` Ajit Khaparde
2020-05-06 3:18 Yuan Linsi
2020-04-30 12:05 yuanlinsi01
2020-04-30 12:55 ` Somnath Kotur
2020-04-30 13:33 ` [dpdk-dev] 答复: " Yuan,Linsi
2020-04-30 10:08 [dpdk-dev] " yuanlinsi01
2020-04-30 10:07 yuanlinsi01
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhvWnFrRgS6pb8+EkQh9dWenEOLnAAu1qrdG7bYM6-o51w@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=yuanlinsi01@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).