From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7575A04B1; Tue, 24 Nov 2020 15:43:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 857A1C926; Tue, 24 Nov 2020 15:43:10 +0100 (CET) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 2C403C910 for ; Tue, 24 Nov 2020 15:43:09 +0100 (CET) Received: by mail-oi1-f196.google.com with SMTP id d9so24031775oib.3 for ; Tue, 24 Nov 2020 06:43:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vSSdluf8ExVe3Y/qc2RYDYAd91qotEE3orzK+Bn1QKw=; b=Eezp44gafjfeO85cLVBpA/mQ6FT6Vt6rOSszAPiVPZIw+BzmChUg4lE1v+zZ/q2Rne J+d7h04utC6WsGM0m6y0fM58DlDPEoaWbJGnRkw8mIXQ/dn7PvI6ZaUJikNhNZcdbxWM g5XUUSNOwLlOGkBztWVp8B0Bnmbsx5UuT8JC8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vSSdluf8ExVe3Y/qc2RYDYAd91qotEE3orzK+Bn1QKw=; b=RIlUy8QaTxG4WLrxn8HUKGedQ0EpUaAJUtc5rTe3SQNi+pv5W/ffa5sArzTe8MXfrf dYs09o4lIMdXGSY4Iu1bNtTz25pgOJ0CMs7S4Pg6ghUODq9EKjthRTbO4jV8SlJzQHHf c4cQJcIHGdESFWquEk7IyzMXjkI92Hd/eYtueqXcRW/GyyB8r0FOTnz57QXMoHItytK1 3M+DivxstxeKW7+hY96DTriGtnzWkjvKdP2fhXX+KozMnT+UErPqhltP5mq4XJ4132Ri XDSC/ZytmGba3oew/bEPIWGBmmk3ZMDA43AHCTTMQm51YAnQisjQiXJ7BNzteSvk7z4b BTnw== X-Gm-Message-State: AOAM533rQLMVmaoEKEWprtn9OoRzaCy1LbzLkoBoS+lM3XGq2vp0tqv7 17vnpLrzDxJu2ey/UdLO6R7lsbSOmB5nEUWG5XrJjw== X-Google-Smtp-Source: ABdhPJwILYykAI2tMdXFnPD4aDd/s7d8MlwGrE9vFHJue6TN1KazvjnIKkz2M6HnUUtBgF2V2Lx2CZ1JcTH/Iw0jgJA= X-Received: by 2002:aca:ecca:: with SMTP id k193mr2986853oih.27.1606228987468; Tue, 24 Nov 2020 06:43:07 -0800 (PST) MIME-Version: 1.0 References: <20200811061443.8214-1-getelson@nvidia.com> In-Reply-To: <20200811061443.8214-1-getelson@nvidia.com> From: Ajit Khaparde Date: Tue, 24 Nov 2020 06:42:51 -0800 Message-ID: To: Gregory Etelson Cc: dpdk-dev , Matan Azrad , Raslan Darawsheh , dpdk stable , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 10, 2020 at 11:15 PM Gregory Etelson wrote: > > According to current RTE API, port flow rules must not be kept > after port stop. > > Testpmd did not flush port flow rules after `port stop' command was > called. As the result, after the port was restarted, it showed bogus > flow rules. > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson > Acked-by: Ori Kam Acked-by: Ajit Khaparde > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 7842c3b781..4ba5c41c6e 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2627,6 +2627,9 @@ stop_port(portid_t pid) > RTE_PORT_HANDLING) == 0) > continue; > > + if (port->flow_list) > + port_flow_flush(pi); > + > rte_eth_dev_stop(pi); > > if (rte_atomic16_cmpset(&(port->port_status), > -- > 2.25.1 >