From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix link update op
Date: Tue, 6 Oct 2020 14:25:44 -0700 [thread overview]
Message-ID: <CACZ4nhvXYbLY0s4APhrRJhzmBhgWXCCNVf8izixEQFk-uyELvw@mail.gmail.com> (raw)
In-Reply-To: <20201006160156.32228-1-kalesh-anakkur.purayil@broadcom.com>
On Tue, Oct 6, 2020 at 8:47 AM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> 1. When port is stopped, we can forcibly set the link status for the
> device to down.
> 2. VFs and MH PFs do not have the privilege to bring the link down.
> As a result driver prints "Link Up" when port is stopped.
> 3. When driver receives link status/speed/config async event from fw,
> driver invokes bnxt_link_update() with exp_link_status as ETH_LINK_UP.
> This is not logically correct as the async event could be for Link up
> or link down or for speed change.
>
> Fixes: 074cacb9907a ("net/bnxt: fix link during port toggle")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
prev parent reply other threads:[~2020-10-06 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 16:01 Kalesh A P
2020-10-06 21:25 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhvXYbLY0s4APhrRJhzmBhgWXCCNVf8izixEQFk-uyELvw@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).