From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 398FFA0C47; Sun, 31 Oct 2021 17:05:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CBB1410E6; Sun, 31 Oct 2021 17:05:24 +0100 (CET) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by mails.dpdk.org (Postfix) with ESMTP id 9088440689 for ; Sun, 31 Oct 2021 17:05:23 +0100 (CET) Received: by mail-io1-f47.google.com with SMTP id q127so17752847iod.12 for ; Sun, 31 Oct 2021 09:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z+cUxrwDoODvj3aW7XYiPsPavslA9AvqEcA0QbnrlnI=; b=MaVJg1c2gBE4uWyttQlPS7NGuURa5SC4u3Cz+318muKM3spxZECi7eiBX5amWZwWiN ipEWWVuzN+8TT3HBWVeLv5iPQieu8gPC4WZ3t7zWUmtu95LjX4bB9vLmoeypiASQTyd7 UpoKZ9yQTiSDHspAAqPHh8ldyK9RvIs0TtJMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z+cUxrwDoODvj3aW7XYiPsPavslA9AvqEcA0QbnrlnI=; b=uugESa/4ZiGJLrBC5U+nz+lsalI3RVa+Zd+lOLUz3O2iDJ6btU8pFZFgtQ+p1vXPds axlc/yrJwJJyu2QVTanLrY9yYy75aiesy9iM30QUFYDeXM/m9+4Ui5gYzQSOmTtOmuhF rW4yR5H5jeZqhsloBJWnLpstIRib3jDWcWk0yYCGX4uERAyJcBljnnKXFUU8frJsk+Fw +FVJMJ5a2sWHOWcXhU9YjkT9nGwCuLGT1CbmXMw7GQPMQXssxxdP4+/f47z1AwwuHe0J wpTAIXcNbS/DywFo6NVcYaZdADA/ov7Kt04aAxsbWxn7fhCS7A0jp2a/aW6mqUx3lFVG LjJg== X-Gm-Message-State: AOAM5313W6jVCP615qQC9dCR1D86FowP9ihAJZ5AkZFHIhJ9jc+KK1Ge aoEWPMW9Z73hY/tytelt4rMQw1xJf9K4WQ0vGq8V4Q== X-Google-Smtp-Source: ABdhPJwV12T6HOgig7Yub+hmYU+87WVF0FJwczREfkugeBLNjcvc3uZJnHS2YD1SMNpBUnwlOzkYvd5r39PV4WjOZ1A= X-Received: by 2002:a5d:878e:: with SMTP id f14mr17460724ion.111.1635696322978; Sun, 31 Oct 2021 09:05:22 -0700 (PDT) MIME-Version: 1.0 References: <20211030035020.31813-1-kalesh-anakkur.purayil@broadcom.com> <20211030035020.31813-2-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20211030035020.31813-2-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Sun, 31 Oct 2021 09:05:07 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix stat context allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 8:30 PM Kalesh A P wrote: > > From: Kalesh AP > > stat_ctx_alloc is called within the context of each rx/tx ring. > i.e from bnxt_alloc_hwrm_rx_ring and bnxt_alloc_hwrm_tx_ring(). > So, there is no need to invoke bnxt_alloc_all_hwrm_stat_ctxs() > from bnxt_start_nic(). > > Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ------ > drivers/net/bnxt/bnxt_hwrm.c | 31 ------------------------------- > drivers/net/bnxt/bnxt_hwrm.h | 1 - > 3 files changed, 38 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 91f114e..c8dad8a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -747,12 +747,6 @@ static int bnxt_start_nic(struct bnxt *bp) > if (BNXT_CHIP_P5(bp)) > bp->max_ring_grps = BNXT_MAX_RSS_CTXTS_P5; > > - rc = bnxt_alloc_all_hwrm_stat_ctxs(bp); > - if (rc) { > - PMD_DRV_LOG(ERR, "HWRM stat ctx alloc failure rc: %x\n", rc); > - goto err_out; > - } > - > rc = bnxt_alloc_hwrm_rings(bp); > if (rc) { > PMD_DRV_LOG(ERR, "HWRM ring alloc failure rc: %x\n", rc); > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 82e89b7..55dcb1d 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -2648,37 +2648,6 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) > return 0; > } > > -int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp) > -{ > - struct bnxt_cp_ring_info *cpr; > - unsigned int i; > - int rc = 0; > - > - for (i = 0; i < bp->rx_cp_nr_rings; i++) { > - struct bnxt_rx_queue *rxq = bp->rx_queues[i]; > - > - cpr = rxq->cp_ring; > - if (cpr->hw_stats_ctx_id == HWRM_NA_SIGNATURE) { > - rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr); > - if (rc) > - return rc; > - } > - } > - > - for (i = 0; i < bp->tx_cp_nr_rings; i++) { > - struct bnxt_tx_queue *txq = bp->tx_queues[i]; > - > - cpr = txq->cp_ring; > - if (cpr->hw_stats_ctx_id == HWRM_NA_SIGNATURE) { > - rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr); > - if (rc) > - return rc; > - } > - } > - > - return rc; > -} > - > static int > bnxt_free_all_hwrm_ring_grps(struct bnxt *bp) > { > diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h > index 6dc23b9..72d4864 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.h > +++ b/drivers/net/bnxt/bnxt_hwrm.h > @@ -188,7 +188,6 @@ int bnxt_hwrm_vnic_plcmode_cfg(struct bnxt *bp, > int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp, > struct bnxt_vnic_info *vnic, bool enable); > > -int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp); > int bnxt_clear_all_hwrm_stat_ctxs(struct bnxt *bp); > int bnxt_alloc_all_hwrm_ring_grps(struct bnxt *bp); > void bnxt_free_cp_ring(struct bnxt *bp, struct bnxt_cp_ring_info *cpr); > -- > 2.10.1 >