From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 058E6A0C47; Thu, 19 Aug 2021 06:49:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9B1740E01; Thu, 19 Aug 2021 06:49:25 +0200 (CEST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id B3D2840141 for ; Thu, 19 Aug 2021 06:49:24 +0200 (CEST) Received: by mail-qt1-f176.google.com with SMTP id l3so3557326qtk.10 for ; Wed, 18 Aug 2021 21:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZjswCC5X1O6DOhecapTBR7rFCxdhqdeAsOrK4diC0mI=; b=Nh5WEtOfZW97+QrArQoBMr0qL7SBznYb5+W/jZjkjWSmatT6kWj/Xu+wL/yQJgHxBM EuXL52uVS8VBbiOVq8Seqy1ShrYl3BNi1YQS74BOiVz8Pq7tRgOWVoCVnWjBlsZU401F aGCQP5Y9mA1TrmWtnGm4Jc0nR9S/BpFnm4uZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZjswCC5X1O6DOhecapTBR7rFCxdhqdeAsOrK4diC0mI=; b=UPkWKDtIfvEfJCvE76NYf5abYg/2Itzij0Pi409Gdiz7u0YGoemZJlrl6xywSvenF8 9KpiEgASzO0fdwsmbrRuLOobRAm4ZNGI02MeI8dLPjYiA/h1ZhbDlw2IFYm8q8co7ngj j3DDxAOfif28pwgfWaYeNE687PEf8EH86k0G7RJ65Jz0x3Z5KzpXAHMUN//vdnGbQXjr mzL+N/wHe4GoJHm20rQpfgeihMThuJZAXaMrUWW57/51ck8k3bzRlHqgqa1tvZ0ErMGY kEOfRMHBjI6+3TknBd5cEvYMpw6Nvj9GqGAslzxAG2vGirv5TAkaGskdkRT/OL6cWiUd KsJg== X-Gm-Message-State: AOAM533BjkacmoKfFckD/CU+vJTsDgwdGQO6IxDf2mSjrsjk5G9F7dPX eQ/cELidqZwQJFaqweOacvi6/ZVW0eBKQzlQRLdflCEMgJgRSA== X-Google-Smtp-Source: ABdhPJxY8aqMvw7IxRZLZzQVvw/PxPbDVDUmhnyAyZFxZvIJ+cZ2h8Zb4f8bfHt5fIG5O6wYseGhh8TBYkC1e46a2a4= X-Received: by 2002:ac8:664e:: with SMTP id j14mr11387034qtp.194.1629348563834; Wed, 18 Aug 2021 21:49:23 -0700 (PDT) MIME-Version: 1.0 References: <20210818053902.71231-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210818053902.71231-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Wed, 18 Aug 2021 21:49:07 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable , Somnath Kotur Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000608ccb05c9e2465f" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: update ring group after ring stop start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000608ccb05c9e2465f Content-Type: text/plain; charset="UTF-8" On Tue, Aug 17, 2021 at 10:39 PM Ajit Khaparde wrote: > A Rx ring stop start sequence may result in the FW returning > a different set of Rx ring and AGG ring IDs. If the ring group > is not updated with the new IDs, the HW sees the host driver using > incorrect BD types for the Rx ring and AGG ring. This can cause > the chip to go into a bad state or encounter RE_flush issue > or leak MBUFs in the HW. > > Fix this by issuing a bnxt_hwrm_ring_grp_free() and an > bnxt_hwrm_ring_grp_alloc() to refresh the ring group information. > > Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Somnath Kotur > Patch applied to dpdk-next-net-brcm for-next-net branch. > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 +++ > drivers/net/bnxt/bnxt_ring.c | 6 ++++++ > 2 files changed, 9 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 73deb41f81..eb9de45cb9 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -2717,6 +2717,9 @@ void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int > queue_index) > struct bnxt_ring *ring = rxr->rx_ring_struct; > struct bnxt_cp_ring_info *cpr = rxq->cp_ring; > > + if (BNXT_HAS_RING_GRPS(bp)) > + bnxt_hwrm_ring_grp_free(bp, queue_index); > + > bnxt_hwrm_ring_free(bp, ring, > HWRM_RING_FREE_INPUT_RING_TYPE_RX, > cpr->cp_ring_struct->fw_ring_id); > diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c > index b05c470766..957b175f1b 100644 > --- a/drivers/net/bnxt/bnxt_ring.c > +++ b/drivers/net/bnxt/bnxt_ring.c > @@ -631,6 +631,12 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int > queue_index) > if (rc) > goto err_out; > > + if (BNXT_HAS_RING_GRPS(bp)) { > + rc = bnxt_hwrm_ring_grp_alloc(bp, queue_index); > + if (rc) > + goto err_out; > + } > + > if (rxq->rx_started) { > if (bnxt_init_one_rx_ring(rxq)) { > PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring > failed!\n"); > -- > 2.21.1 (Apple Git-122.3) > > --000000000000608ccb05c9e2465f--