From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C63A0C47; Mon, 26 Jul 2021 05:07:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DADE40F35; Mon, 26 Jul 2021 05:07:41 +0200 (CEST) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mails.dpdk.org (Postfix) with ESMTP id 4B2B240DDA for ; Mon, 26 Jul 2021 05:07:40 +0200 (CEST) Received: by mail-qt1-f171.google.com with SMTP id l24so6152487qtj.4 for ; Sun, 25 Jul 2021 20:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=swDUU0beTlrMPzI/7suaE50ehFTnqhzMSuwhkj7H3yo=; b=MwU1hgnvEG1JSctPeet6K860AO/ODlrJ4IeCeGoxBzLUYzkHMGwbrdYnuVnMhdirKU RW3N1C0nhWdLwwRDQpxlUT47vAtxXJSe7ugCUEV5J7uY3/rNsDLwe8/0YrH+E8b/ySo5 8lNE3pzfH7kT6aKP8/nXEduxvt6yQR/5JN8eE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=swDUU0beTlrMPzI/7suaE50ehFTnqhzMSuwhkj7H3yo=; b=dK5tQehnGDMX2BAX5lay1XuDnJyzxZxz+kyqeMJkd/izbYs5XiWfO0iQAvU+J38Ai/ eQwUi90pKtzFL3S+977BZRB5Jy3DVvLYrYG45EI7oV0KZeYRsp4v9wmBvaYDQZDfCWp4 6FrToLAYCYu8Jc+XTEQCQ09IKi777Qr6rrOeMBDevjjl+GLeXeBmY8iJzBOCBEUznd3V K2bEj+GypbYNrfk9Ex3iv3axpRp+8l4xWX2vVEQQPymK403jzhadselg/3vkr/PRoBD5 DoT1M6psLrD4LMhc6OlruBnlFarcOwRkPY3GRhHxaay45Y8WUCpkCzmXlrgD0NvhBmZL PVMw== X-Gm-Message-State: AOAM533VnSt0V0Y+RizYA2Lzl4my0jLyAiZW2CddTC3J1zOyMYFm2KCa cPiDSlxe/r6JXUjAFMEKxSb7Xdoj1mXcjIQnrXDLDQ== X-Google-Smtp-Source: ABdhPJzF1/G0B01c8SFn892XrOreQxmX7avyA1ycnu57Mw84XhpB7naAVOXaq1WXMntibuScAdJc/D0soMqG8EYl4eY= X-Received: by 2002:a05:622a:14ce:: with SMTP id u14mr13589031qtx.208.1627268859477; Sun, 25 Jul 2021 20:07:39 -0700 (PDT) MIME-Version: 1.0 References: <20210721155816.188795-3-xhavli56@stud.fit.vutbr.cz> <20210721111629.2e03cadd@hermes.local> In-Reply-To: <20210721111629.2e03cadd@hermes.local> From: Ajit Khaparde Date: Sun, 25 Jul 2021 20:07:23 -0700 Message-ID: To: Stephen Hemminger Cc: Martin Havlik , Ori Kam , Thomas Monjalon , Andrew Rybchenko , Ferruh Yigit , Dekel Peled , Bing Zhao , Gregory Etelson , Eli Britstein , Alexander Kozyrev , dpdk-dev , Jan Viktorin Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000057d7bf05c7fe0e94" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000057d7bf05c7fe0e94 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 21, 2021 at 11:16 AM Stephen Hemminger wrote: > > On Wed, 21 Jul 2021 17:58:14 +0200 > Martin Havlik wrote: > > > The ability to create RTE flow rules, depending on > > port status, can and does differ between PMDs. > > Now the doc reflects that. > > > > Signed-off-by: Martin Havlik > > --- > > doc/guides/prog_guide/rte_flow.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > > index 2b42d5ec8c..2988e3328a 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -3097,6 +3097,10 @@ actually created and a handle returned. > > const struct rte_flow_action *actions[], > > struct rte_flow_error *error); > > > > +The ability to create a flow rule may depend on the status (started/stopped) > > +of the port for which the rule is being created. This behaviour is > > +PMD specific. Seek relevant PMD documentation for details. > > Any PMD specific behavior in DPDK is an anathema to application developers > and should be considered a design flaw! But it is better to be clear about the behavior. Drivers and their underlying devices may need certain resources to be initialized before flows could be created. There may be some drivers who do not need that. Specifying ports to be started would cover both the cases. Maybe then we can say that "some drivers may _not_ need the port to be started. Check PMD specific documentation". --00000000000057d7bf05c7fe0e94--