From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF53C42570; Mon, 11 Sep 2023 18:11:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D5D6402D6; Mon, 11 Sep 2023 18:11:26 +0200 (CEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 370AF402CE for ; Mon, 11 Sep 2023 18:11:24 +0200 (CEST) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-273d10d3df3so2803051a91.3 for ; Mon, 11 Sep 2023 09:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1694448683; x=1695053483; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9kInq4yj+/kKlAObfpAh/DW5geLHUCZONZATF8vPYMc=; b=KlapX1Kstbx5/Wa4bYUpHFE/iVrWMR2/g71JSmrFNzT/f3u+YJJMMNBLoD9YceOI2F 2mcVfi3pr/09ZgMax4Ir8DjO1SbJdAjQyNWd1ttv+sVFPi6PmfFMQjlHSP5d2MGhoKfM LFT1vwXWw9hQyEBmdpvsRUtFrsznSJrdW9fbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694448683; x=1695053483; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9kInq4yj+/kKlAObfpAh/DW5geLHUCZONZATF8vPYMc=; b=tqGZsqtcxhjpf5h4w8Ddh/7+3wMaQ7kTzBErgfUjAxxCeyCp38jigULYczyXq+T5kU khWipEwzewsY+uoVz6v6vpbeKQHdyqr873CmZWwa7I2FM8xtDQYaCXYoizKYKXZX1EqU 6IKaQZkbIm5jqSgtVmHIxmRV8FXq80RSUmK2yabN6xzFKyeNjRWA3bzxh2qJtJfziEDJ Vyf6BWxsV1VTs3CVt+bBb5un5AKrYXoSaEm7E0T1ixZYyEzBdVhiyvhyfcD9VYGnQuhw LL2d5K9tRgK5e0WuL7Y7S9CtyFTiW3BZpd2pNQwZsGQB/DhnnCaYzs9uyVawGz8DX2xb M4/Q== X-Gm-Message-State: AOJu0YxP6BXl1fnw509TubSgtdpeAOKJUGQZX9mG6pbmWFrPgrhYKasE nw3Wy3FB1QMNc9Nv7Vq3k5HIUtzASROnaqJRTxfzgA== X-Google-Smtp-Source: AGHT+IF/ePJPZRGbYtm+z7oM5rVquZRbCxgIyGUj3sVqxBnsnj65a0QSArM0PS82Cn7aXDDFepXw6oX40Y5cd1RrRh0= X-Received: by 2002:a17:90a:e651:b0:262:fba6:59b5 with SMTP id ep17-20020a17090ae65100b00262fba659b5mr7326354pjb.24.1694448683207; Mon, 11 Sep 2023 09:11:23 -0700 (PDT) MIME-Version: 1.0 References: <20230315110033.30143-1-liudongdong3@huawei.com> <6f9d565d-b9b7-030b-8daf-ffcd4faa39f1@huawei.com> <2002233.kXSN5OTJKJ@thomas> In-Reply-To: <2002233.kXSN5OTJKJ@thomas> From: Ajit Khaparde Date: Mon, 11 Sep 2023 09:11:06 -0700 Message-ID: Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm To: Thomas Monjalon Cc: Jie Hai , dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko , liudongdong3@huawei.com, orika@nvidia.com, jerinj@marvell.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000e00c3b060517937a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000e00c3b060517937a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 11, 2023 at 3:09=E2=80=AFAM Thomas Monjalon wrote: > > 09/09/2023 02:01, Ajit Khaparde: > > On Fri, Sep 8, 2023 at 1:44=E2=80=AFAM Jie Hai wro= te: > > > > > > Hi, Thomas > > > Thanks for your review. > > > > > > On 2023/9/4 15:45, Thomas Monjalon wrote: > > > > 04/09/2023 09:10, Jie Hai: > > > >> On 2023/8/30 19:46, Thomas Monjalon wrote: > > > >>> 26/08/2023 09:46, Jie Hai: > > > > >> + * The *func* field of the *rss_conf* structure indicates the= hash algorithm > > > >>>> + * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DE= FAULT allows > > > >>>> + * the PMD to use its best-effort algorithm rather than a speci= fic one. > > > >>>> */ > > > >>> > > > >>> I don't like commenting a field on top of the structure. > > > >>> By the way, the first sentence does not look helpful. > > > >>> RTE_ETH_HASH_FUNCTION_DEFAULT may be explained in the enum. > > > >>> > > > >> Other fields above the structure 'rte_eth_rss_conf' have comments= . > > > >> If the new fields 'func' do not have comments, it may be misleadin= g. > > > >> Unless all the comments above are removed. I'm not sure whether to > > > >> delete them or not. > > > > > > > > You should explain RTE_ETH_HASH_FUNCTION_DEFAULT in its enum. > > > > The rest of the explanation can be on the struct field. > > > > I'm OK to have another patch moving old explanations from the struc= t > > > > to the fields. > > > Fixed in V4, please check it. > > > > > > > >>>> struct rte_eth_rss_conf { > > > >>>> uint8_t *rss_key; /**< If not NULL, 40-byte hash k= ey. */ > > > >>>> uint8_t rss_key_len; /**< hash key length in bytes. *= / > > > >>>> uint64_t rss_hf; /**< Hash functions to apply - s= ee below. */ > > > >>>> + enum rte_eth_hash_function func; /**< Hash algorithm t= o apply. */ > > > >>> > > > >>> You can drop "to apply" words. > > > >> Fixed in V3. > > > >>> > > > >>> How the algorithms support combinations in rss_hf? > > > >>> > > > >> The rss_hf defines the input of the RSS hash algorithms. > > > >> For example, rss_hf =3D RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS= _IPV4, > > > >> these two kinds of packets can be dispatched to different queues > > > >> according to their tuple field value. > > > >> For ipv4-tcp packets, src-ip, dst-ip, src-port, dst-port are used = as > > > >> parameters of RSS hash algorithms to compute hash value. > > > >> For ipv4 packets src-ip, dst-ip are used. > > > >> > > > >> If rss_hf =3D RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_L4_SRC_ON= LY, for > > > >> ipv4-tcp packets, src-port is used as parameters of RSS hash algor= ithms > > > >> to compute hash value. > > > > > > > > I know what is rss_hf. > > > > My question is about the algorithms. > > > > Do they all support any combination in rss_hf? > > > > > > > > > > > I don't know about all vendors' hardware implementations, > > > so here's just my simple opinion. > > > > > > Theoretically, I think that all algorithms should support all > > > combinations in rss_hf, The reasons are as follows. > > > > Leave it to the driver and hardware to decide what combinations can be > > supported. > > > > > > > > 1. The rss_hf and algorithms are independent. For different algorithm= s > > > and the same packets and hash key, the input parameters for different > > > algorithms should be the same, which depends on implemetation of hard= ware. > > > > > > 2. As long as hardware and driver support, all packet types defined b= y > > > rss_hf could generate the the input parameters for the algorithm to c= ompute. > > How the application can know a hash is not supported with an algo? > I guess this is an error code on configure? Yes. We may need a way to differentiate errors because of RSS vs others. > > --000000000000e00c3b060517937a Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIEoBpsIrBUHTqoIQxjR0 tLLT6UsX3HodPQqV4nIUX5PjMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDkxMTE2MTEyM1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQA4+1MQ//Sg7HJ2lTC96VUB67HnrTWSZ3UwV/QA LcTa50XlVOrOtdtffLStef3lBv037a2ETb1heF8LW0JWz7PgxzfG+ICjb4KjGtArQUNmAscpGBAU FWcXsOpiuqPewFAmfskPIkS+pTkbLOUU5xnZ0NUYdORWS7l+VBoA3LDAgj2JBJYKFhiTE+66IIxV 0MRkASnT7Fz2XX1lv8AENGXCtgI08PYFV3fkbwwr3dhPgR6+B9iSE+EYHS5M3a2wd7jF7eiAAUE0 pisn4tyYjz2nTZe8LkFaMNNjamXEQG+4tmxXiHEg85KH994sh7xRilEBiqs4zHm5k2vTLbcBOJyw --000000000000e00c3b060517937a--