From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64612A0567; Tue, 9 Mar 2021 23:01:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DDE322A3E1; Tue, 9 Mar 2021 23:01:03 +0100 (CET) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id 64C1A4069D for ; Tue, 9 Mar 2021 23:01:01 +0100 (CET) Received: by mail-qk1-f180.google.com with SMTP id a9so14751890qkn.13 for ; Tue, 09 Mar 2021 14:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mv8wdT2LLUNNxuWFb+UCCI2UXurEv3GR/ffNAJ9FIIU=; b=CfYfK8ShJJXhrmP6Duqz/uyCHr7A2K73t+aKJBq7MPOW9W930Oc2ZqrAjbUqm99hiQ ew8YzJjnRvGW8fo5/mtAe/uFS/XHbc7e5XIPkn450yq2YSc3/2ioMSdkPyKw9saSzRfj imwS4J24c2wOL+QFCscwV9qEpdlxtKJSyd4ro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mv8wdT2LLUNNxuWFb+UCCI2UXurEv3GR/ffNAJ9FIIU=; b=qUOqvRYWwXssw1w1KeDVvjN360Dnp5s8HL3b8kj8d1WOrLxFkAYOE0AKXoquxKvk6/ 0o71W1tJvPA0HTX2zfM9OvnkdETwMtKzr2KPeb7Z+PzjXn5TTPT3li4v++IUG+T0QWRi O6V8GQLs+rps66htMvf3fBSiPI5ddg0cgXjWCAac9p6+eP2h6pH5Bvbhd3EgNCW6cr2A YvcxwXhRZIHoMUGuBAqwDR3jvicfDVlSFxCGCV+IX/KaQKEhhOpce6T8auCAFybhTUOJ OXB45XM6Jl7OL0mYoXmwQWNABTUOxVYVNfW0HvZXY83eyJrArz+C244YwB3yzH51n3nY IuUQ== X-Gm-Message-State: AOAM533xRJ22ssczk6AEXCHkaw+ZiQrqihrm43FOlHXcYaJbJcc9X2ao OT55CU94WSgLXzXIknr8p2bbY1iROtQx+BytEzmxgg== X-Google-Smtp-Source: ABdhPJypcIWR30rwpSCrmEn4gNBvVS4GpuxOiiT5F4J2J5++xILMkTG3dQYTmLjZOPmugUUzCWXpKfh2uOLHKXS4WJQ= X-Received: by 2002:a37:86c6:: with SMTP id i189mr28803346qkd.455.1615327260632; Tue, 09 Mar 2021 14:01:00 -0800 (PST) MIME-Version: 1.0 References: <20210308223434.48768-1-ajit.khaparde@broadcom.com> <14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com> In-Reply-To: <14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com> From: Ajit Khaparde Date: Tue, 9 Mar 2021 14:00:44 -0800 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Bing Zhao , Ori Kam Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000096dd6b05bd21afda" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] doc: fix formatting in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000096dd6b05bd21afda Content-Type: text/plain; charset="UTF-8" On Tue, Mar 9, 2021 at 4:52 AM Ferruh Yigit wrote: > > On 3/8/2021 10:34 PM, Ajit Khaparde wrote: > > Fix formatting in testpmd user guide for hairpin operation. > > > > Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") > > Cc:stable@dpdk.org > > > > Signed-off-by: Ajit Khaparde > > Cc: Bing Zhao > > Cc: Ori Kam > > --- > > doc/guides/testpmd_app_ug/run_app.rst | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst > > index 3035118cdc..8ec2300ee5 100644 > > --- a/doc/guides/testpmd_app_ug/run_app.rst > > +++ b/doc/guides/testpmd_app_ug/run_app.rst > > @@ -531,11 +531,13 @@ The command line options are: > > > > * ``--hairpin-mode=0xXX`` > > > > - Set the hairpin port mode with bitmask, only valid when hairpin queues number is set. > > - bit 4 - explicit Tx flow rule > > - bit 1 - two hairpin ports paired > > - bit 0 - two hairpin ports loop > > - The default value is 0. Hairpin will use single port mode and implicit Tx flow mode. > > + Set the hairpin port mode with bitmask, only valid when hairpin queues number is set:: > > + > > + bit 4 - explicit Tx flow rule > > + bit 1 - two hairpin ports paired > > + bit 0 - two hairpin ports loop > > + The default value is 0. > > + Hairpin will use single port mode and implicit Tx flow mode. > > > > Not sure if the last line intended to be part of the list, what do you think > only keep bit descriptions in the box but left the last sentences as regular > paragraph. > Ori please correct me if I am wrong with the original intention. Ori, Not just indentation. How about this modified text as well? - bit 0 - two hairpin ports loop - The default value is 0. - Hairpin will use single port mode and implicit Tx flow mode. + bit 0 - two hairpin ports loop (default) + +.. Note:: + + When hairpin is used in single port mode, Tx flow rule will be implicit. Does this statement look right? --00000000000096dd6b05bd21afda--