From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72C8A425FA; Wed, 20 Sep 2023 19:15:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46093402E0; Wed, 20 Sep 2023 19:15:53 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 3400D402C3 for ; Wed, 20 Sep 2023 19:15:51 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so5783998a12.1 for ; Wed, 20 Sep 2023 10:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1695230150; x=1695834950; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6uAV9qpXLwHWeVdEz+9FrJBKcSrj6MBwt5kaJMP8Z34=; b=GE8qlANiPnOePr1cGTnPsTXuZh2vS98l/i4J1iIy5vBdL4bct6/8NAmQ0ffaDUyOpC spKA61SxSW5bfRn2Gn7sFTi2xCshnTKoSEk08idf26sh2rEM52gitB+dht657d3sNLO8 OiOOwTkZ3NoBXJDX0Zpy+1kxcggRBEWF940ho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695230150; x=1695834950; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6uAV9qpXLwHWeVdEz+9FrJBKcSrj6MBwt5kaJMP8Z34=; b=nrzqNfSf6opUDoe39cXaYEXf1LqNy69ZwQC48HHmIYVzj/47TbAwAuXBnOcgq1C7wA vmmi0diW8Ocy7Lq79qrkskocOfqDhGgSczoH9TbCQCvHdfmE4D/Q62ErT6gyUqHDT+y7 5pt9vFXWs82sEHGA6+wIN4Ygha7Yg+2MFxVjNc42sWSXVAYODUv6bqgwKgwXAHVAsp5/ Fh5z3Q/h6RhCdm9sgDz2BH/Fl5C69hcnwXaI73Jo24io4YD/fbUvKp03xltsNArVk2P8 lI8jajBWIiBSVshqbYXtFXGeSaSFghjBhPPK5VknxfVe4wUFefELP0Y9rf7i1FPrIkXp kAGQ== X-Gm-Message-State: AOJu0YxuZBa0IZlUGjGuuUhEw+oPJJ7sxwJKAH6rT8Kh8KaSUs9+75W/ n+UzUXaQkUcZjdflLRMV7aWwbH0M7wM17fMYMFxkHQ== X-Google-Smtp-Source: AGHT+IHPKLVp7ZR5SaARDYTWvlleDXA/ux6jvqMiyk3+PbB/WeYJRbgIwhTrPEwcYDQGTGSRLs9ClaHxXY3q8qzJAvQ= X-Received: by 2002:a17:90b:4d87:b0:26b:24ed:e0d9 with SMTP id oj7-20020a17090b4d8700b0026b24ede0d9mr3067186pjb.33.1695230150280; Wed, 20 Sep 2023 10:15:50 -0700 (PDT) MIME-Version: 1.0 References: <20230904072851.7384-1-haijie1@huawei.com> <20230908080030.3837515-1-haijie1@huawei.com> <20230908080030.3837515-3-haijie1@huawei.com> <785537ac-1b25-472a-b114-53620373da69@amd.com> In-Reply-To: <785537ac-1b25-472a-b114-53620373da69@amd.com> From: Ajit Khaparde Date: Wed, 20 Sep 2023 10:15:33 -0700 Message-ID: Subject: Re: [PATCH v4 2/7] ethdev: support setting and querying RSS algorithm To: Ferruh Yigit Cc: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam , lihuisong@huawei.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000f10f5d0605cd8680" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000f10f5d0605cd8680 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 20, 2023 at 9:39=E2=80=AFAM Ferruh Yigit = wrote: > > On 9/8/2023 9:00 AM, Jie Hai wrote: > > Currently, rte_eth_rss_conf supports configuring and querying > > RSS hash functions, rss key and it's length, but not RSS hash > > algorithm. > > > > The structure ``rte_eth_rss_conf`` is extended by adding a new > > field "func". This represents the RSS algorithms to apply. The > > following API will be affected: > > - rte_eth_dev_configure > > - rte_eth_dev_rss_hash_update > > - rte_eth_dev_rss_hash_conf_get > > > > The problem with adding new configuration fields is, none of the drivers > are using it. > > I can see you are updating hns3 driver in next patch, but what about > others, application will set this field and almost all drivers will > ignore it for now. > And in near future, some will be supporting it and some won't, still > frustrating for the application perspective. > > In the past I was gathering list of these items and follow > implementation of them with drivers, but as the number of drivers > increased this became very hard to manage. > > Another way to manage this is go and update all drivers, and if the > configuration requests anything other than > 'RTE_ETH_HASH_FUNCTION_DEFAULT', return error. So that application can > know this is not supported by this driver. I think it is a good option. And then a driver can modify it when it adds support for other algorithms. > Do you have better solution for this? > :::: snip :::: > > > +}; > > + > > /** > > * A structure used to configure the Receive Side Scaling (RSS) featur= e > > * of an Ethernet port. > > @@ -464,6 +484,7 @@ struct rte_eth_rss_conf { > > * Supplying an *rss_hf* equal to zero disables the RSS feature. > > */ > > uint64_t rss_hf; > > + enum rte_eth_hash_function func; /**< Hash algorithm. */ > > Can we use 'algorithm' as the field name? > > I know it won't exactly match type name (rte_eth_hash_function) but I > think this will be more accurate also less confusing for "rss_hf (rss > hash function)" and "func (function)"? +1 > > > }; > > > > /* > > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c > > index 271d854f7807..d3f2d466d841 100644 > > --- a/lib/ethdev/rte_flow.c > > +++ b/lib/ethdev/rte_flow.c > > @@ -12,7 +12,6 @@ > > #include > > #include > > #include > > -#include "rte_ethdev.h" > > #include "rte_flow_driver.h" > > #include "rte_flow.h" > > > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > > index 3bd0dc64fbe2..a7578b1d2eff 100644 > > --- a/lib/ethdev/rte_flow.h > > +++ b/lib/ethdev/rte_flow.h > > @@ -40,6 +40,8 @@ > > #include > > #include > > > > +#include "rte_ethdev.h" > > + > > #ifdef __cplusplus > > extern "C" { > > #endif > > @@ -3183,26 +3185,6 @@ struct rte_flow_query_count { > > uint64_t bytes; /**< Number of bytes through this rule [out]. */ > > }; > > > > -/** > > - * Hash function types. > > - */ > > -enum rte_eth_hash_function { > > - /** > > - * DEFAULT means that conformance to a specific hash algorithm is > > - * uncared to the caller. The driver can pick the one it deems op= timal. > > - */ > > - RTE_ETH_HASH_FUNCTION_DEFAULT =3D 0, > > - RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > > - RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ > > - /** > > - * Symmetric Toeplitz: src, dst will be replaced by > > - * xor(src, dst). For the case with src/dst only, > > - * src or dst address will xor with zero pair. > > - */ > > - RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, > > - RTE_ETH_HASH_FUNCTION_MAX, > > -}; > > - > > /** > > * RTE_FLOW_ACTION_TYPE_RSS > > * > --000000000000f10f5d0605cd8680 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIHLzLPhvXXxCYy9Jj+4k TIRk8I0L6FBKu4KkPSaRTDBmMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDkyMDE3MTU1MFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQB6xe54lawuIRnAEGpLtMRZpYfP7pNnnFBKCMYS scwdEhWejuJHogMwh7cDb/rIDpuEAoIsn9PD9QzA5HciRtxm2tU1EtPPFZp1Ge3BUt9AXchWQTA8 1a2JN2vAYzyR2eS/W848RTXh5r4o/RGaflpAsrNKB+li2DtLuYiQNvNZEy247wLkzs1bOUYUgYy3 aHP8xJFs7ZMhdqRkzXeUc0/3B88m7vzmP0/zbwnYAMHmHEeLtDYi6qQCdCqwgWAzDteoHXHMmgfn D2U14v3cc/MZLcX1AZs5prCGawHQlJn6u7wMJfCgq6qjqeSm9o4tx7vlQ/xBE9r29eAxRGj/EwjX --000000000000f10f5d0605cd8680--