From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A013DA00BE; Thu, 10 Feb 2022 19:04:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34CA140140; Thu, 10 Feb 2022 19:04:38 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 3E0054013F for ; Thu, 10 Feb 2022 19:04:37 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id m185so8338552iof.10 for ; Thu, 10 Feb 2022 10:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ECiJ3Cib7RoBxjfKIBjMkE1iV/AghiYibzY3dM+vM84=; b=PB2t/V6sRM9HdNLdn2cg+qqIhUlHj/SgChtgpZp0MPE44eUk2Q2+9e15ngOEP2tYc+ 47LahieboFk+Jns+d+UkmVdnSIhiYiHcVnk9CltuH1YgsiT+aZMEEzvxDQUgoLbp5fS6 E+q3bWP5AuzFKjSl9yuLDEJH+nd1hSuqRiqNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ECiJ3Cib7RoBxjfKIBjMkE1iV/AghiYibzY3dM+vM84=; b=o4/Kww+Ud01EUKpG6VgObsJ9R+dcujauoGBdsUDhSHC4cc46Kont0teHfJDiveVm6j ydHlJYKRCNHqqyRi27PyXcQylyhylb06E2qDIw4Y7atCPe00LuY7mL4Fpy0pKHgtub8P f4qBCk4VSFg4go32+tNJXaIR8aQwmN0IRVotadcY4BS8slKoAagxvF2fjC7KkVFeSziG 1fNCXQguaDVcbT1kryaRSObQ4CFuGODFMXuA/DsoI/LYhF+4lhk7lEhAIWNaL4ng5Jel 9Yh1/g5m9CXZJDpHjgw1ktpcQvb1mI81pgX0MnhMRZLYwIfLKKgmlCTsLGEXP4rQLx2q NZRg== X-Gm-Message-State: AOAM533Ew9YxNBk/GmimAOuCiyBKJ+7h3XSCGi8FHKUOJ1Ym2j6D49IV DDPsGTI8L9Pp/+PNVU5pyKHx5vXxC11nvFryRp/aiQ== X-Google-Smtp-Source: ABdhPJwg8n2fBzjWJnZEXvnG3IXZUS9tgXEEa9ClMcivJ4cQlHseadbEWoTv1AphY2oUQOvnPNu7Ntc80CxtjeTuPQM= X-Received: by 2002:a05:6638:41a8:: with SMTP id az40mr2834539jab.84.1644516276386; Thu, 10 Feb 2022 10:04:36 -0800 (PST) MIME-Version: 1.0 References: <20220209213809.1208269-1-akozyrev@nvidia.com> <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> In-Reply-To: <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> From: Ajit Khaparde Date: Thu, 10 Feb 2022 10:04:20 -0800 Message-ID: Subject: Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules management To: Ferruh Yigit Cc: Alexander Kozyrev , dpdk-dev , Ori Kam , Thomas Monjalon , Ivan Malov , Andrew Rybchenko , mohammad.abdul.awal@intel.com, Qi Zhang , Jerin Jacob Kollanukkaran , Bruce Richardson Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000008055b905d7adc8e2" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008055b905d7adc8e2 Content-Type: text/plain; charset="UTF-8" On Thu, Feb 10, 2022 at 8:00 AM Ferruh Yigit wrote: > > On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: > > Three major changes to a generic RTE Flow API were implemented in order > > to speed up flow rule insertion/destruction and adapt the API to the > > needs of a datapath-focused flow rules management applications: > > > > 1. Pre-configuration hints. > > Application may give us some hints on what type of resources are needed. > > Introduce the configuration routine to prepare all the needed resources > > inside a PMD/HW before any flow rules are created at the init stage. > > > > 2. Flow grouping using templates. > > Use the knowledge about which flow rules are to be used in an application > > and prepare item and action templates for them in advance. Group flow rules > > with common patterns and actions together for better resource management. > > > > 3. Queue-based flow management. > > Perform flow rule insertion/destruction asynchronously to spare the datapath > > from blocking on RTE Flow API and allow it to continue with packet processing. > > Enqueue flow rules operations and poll for the results later. > > > > testpmd examples are part of the patch series. PMD changes will follow. > > > > RFC: https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226-1-akozyrev@nvidia.com/ > > > > Signed-off-by: Alexander Kozyrev > > Acked-by: Ori Kam > > > > --- > > v4: > > - removed structures versioning > > - introduced new rte_flow_port_info structure for rte_flow_info_get API > > - renamed rte_flow_table_create to rte_flow_template_table_create > > > > v3: addressed review comments and updated documentation > > - added API to get info about pre-configurable resources > > - renamed rte_flow_item_template to rte_flow_pattern_template > > - renamed drain operation attribute to postpone > > - renamed rte_flow_q_drain to rte_flow_q_push > > - renamed rte_flow_q_dequeue to rte_flow_q_pull > > > > v2: fixed patch series thread > > > > Alexander Kozyrev (10): > > ethdev: introduce flow pre-configuration hints > > ethdev: add flow item/action templates > > ethdev: bring in async queue-based flow rules operations > > app/testpmd: implement rte flow configuration > > app/testpmd: implement rte flow template management > > app/testpmd: implement rte flow table management > > app/testpmd: implement rte flow queue flow operations > > app/testpmd: implement rte flow push operations > > app/testpmd: implement rte flow pull operations > > app/testpmd: implement rte flow queue indirect actions > > > > Hi Jerin, Ajit, Ivan, > > As far as I can see you did some reviews in the previous versions, > but not ack the patch. > Is there any objection to last version of the patch, if not I will > proceed with it. The latest set is looking good. There are some places where we could cleanup or rephrase the text. But that need not block the series. So for the series Acked-by: Ajit Khaparde Thanks for checking. > > > Hi Alex, > > As process we require at least one PMD implementation (it can be draft) > to justify the API design. > > If there is no objection from above reviewers and PMD implementation > exists before end of the week, I think we can get the set for -rc1. > > Thanks, > ferruh --0000000000008055b905d7adc8e2 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDBCmE9BT7srhoNHDEDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjdaFw0yMjA5MjIxNDUxNDlaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAwXsxfYF9jpj9zve1vXxD491SrWDVlcmLMdnOS1c7POMC8lbbgvp1o2kIu/3n xCVFTai5H6rHZgrFItNNVZ+XaJW9Ob9eiSuXdnAu5gVdTb+IFAf4S/PT2LXzpP07M7vyvm/yvA+8 HtVfapzqqTNYdNVUpq28MYsKEWbnyK94x5+C3oCAV4bpNnMoPNtKrMhvOdpTREQRyew8hyy3/Mz7 RIaCW0xx+14NTQe17dkH6CEEpmCjejneq/FU0gmbuorwHoP9mOiqeh23/ZKVpmFO/eiDtvMNAMDW 6LzhOk/pMklUPTHu/gQNW3OQebyhyFUHiBSp8rDkfWZT57Asd0PtdQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUPHif0ihgndR0 h7r3sANaOIu2yM8wDQYJKoZIhvcNAQELBQADggEBAAEuLXDnP0Xd2zAMpQobXLUyqbpqGMO6ycQc Xq4H2YYlSNKVwPA+ZAVdUOzbSimBKlx8mzAEHkI3Ll1yXlYeT4UwkfWV9fioyGuQelLN1sGzi5bm WEpaSIbR1eiJMtzxUPwpRTn19gHZVueIot2Gw0fEYgHiMJpUr6xBWv2QNXULu/E8qvbXIRh2iycq 5rWFggX/JHglO8nVqzb1ImzqzVMFnDN15h3j8ryy2MIvZ8VDQRP7l81IXaTvVwaKpWMgV6rfQOi6 aOQZuOKkad7qoCkS5N2oSsvxi+rZtDaJJNsDjs05y5JZZQtBlfAmdYS+mmvkPjZ1iaLTzk59o/Yo fNkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwQphPQ U+7K4aDRwxAwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEINZc93GhEfAV1kHvEkuY AcF5M83f1yPXI1pVYlwLon2vMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMDIxMDE4MDQzNlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQC3h3qQuvZCO2EwzsqdmXOGRodVfUBDKi1aPUst jrvdPZI0KDUhMq3lcc1s7pMTWtZzPjw7/TRusF9vas/nHgwaKSbOxEr7jxwg7KE1GGejhRZMaY2D kBav75QyKQUMYYWj7CCIDpwdspR4LrZVkTEjl4yjgETIzwJn9p3APVcPbGH+ZbW3+kcatNE8+Ppb AiiB0HOfezRFVq6dhMJaov1ottimfSVSK2dx6hC5kl7Q9FO47JqDEBOfSe6LwX15Pzd6zzgTAGkV CXgiSIDfgtrieYYuNScike+HbgHJjgoCLy0ASsb+Xn5OPGYfpm1eeOi5uxchYMjy/nK3gSR69bCX --0000000000008055b905d7adc8e2--