* [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx
@ 2019-11-15 4:50 Somnath Kotur
2019-11-15 5:24 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Somnath Kotur @ 2019-11-15 4:50 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors
for both tunneled and non-tunneled IP packets.
Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector Rx")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_rxr.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index c35bc1afd..3b713c242 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -515,16 +515,18 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
if (likely(IS_IP_NONTUNNEL_PKT(flags2_f))) {
if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1)))
mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
+ else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
+ mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
else
mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
} else if (IS_IP_TUNNEL_PKT(flags2_f)) {
if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) ||
RX_CMP_IP_CS_ERROR(rxcmp1)))
mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
+ else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
+ mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
else
mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
- } else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) {
- mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
}
/* L4 Checksum */
--
2.23.0.rc1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx
2019-11-15 4:50 [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx Somnath Kotur
@ 2019-11-15 5:24 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2019-11-15 5:24 UTC (permalink / raw)
To: Somnath Kotur; +Cc: dpdk-dev, Ferruh Yigit
On Thu, Nov 14, 2019 at 8:58 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors
> for both tunneled and non-tunneled IP packets.
>
> Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector
> Rx")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_rxr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index c35bc1afd..3b713c242 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -515,16 +515,18 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
> if (likely(IS_IP_NONTUNNEL_PKT(flags2_f))) {
> if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> else
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> } else if (IS_IP_TUNNEL_PKT(flags2_f)) {
> if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) ||
> RX_CMP_IP_CS_ERROR(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> else
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> - } else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) {
> - mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> }
>
> /* L4 Checksum */
> --
> 2.23.0.rc1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 4:50 [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx Somnath Kotur
2019-11-15 5:24 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).