From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB8B9A052A; Fri, 10 Jul 2020 15:55:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 113DC1DE47; Fri, 10 Jul 2020 15:55:31 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 0AB801DE45 for ; Fri, 10 Jul 2020 15:55:29 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id t4so4826350oij.9 for ; Fri, 10 Jul 2020 06:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HkccT1a5+EY2ACRrDt/xTATKsklHHUZuVnrRFRBxYUs=; b=SsdQNiGCKR7GrsMOB7KwIU90NGHAaAoGfMlDI/ZSkBgrUrzUXfVGPRZpO4J7xJGnRL TN3+iudQnWJZ03MqTADlM+ML6wTg4JdzQC5w6TP7+9wqoJr4pFb+nFzUvgapkrfr7wce LF1hPoEwuMvef6puEE1NuiY4idEHidLC7ocAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkccT1a5+EY2ACRrDt/xTATKsklHHUZuVnrRFRBxYUs=; b=TLEbC8ZtccpKpZGtzvf1wdxUEH1F7UDwRIfBArfTvhRffdkUBLQzrhsFkEk2f2O6n3 zwRy7aqs89iaLlFwJbysqcXdiHp9iog/w+RgTkbGuzyg1JopEpdjIaAMfSl1NJotaFLp FQ365+z8PLTrFucI9UcsP5ilX+G8wt+nbTwMfOddcnsF46dPItDRJG8d8VltVHUonYs/ yqT3jaCw5+ViVTDNyIv5M37pO4gGVVKggJeSZm+KKGddYsfqK3me4+KpTKKGIRrouGEk hgQOnQA2BCeXMDUMPSi7/148dfrqCInwJpf/3Gx0H/AZOuvavLaIvkKuUm9FXLrWNPmw Co9A== X-Gm-Message-State: AOAM530xko39jJ4PSFbEpsgVGOk0IF51J0h5M1VBwgiPrjqnlq8Ghpvj 6Vqjkmk7Q4GgyLnlEeE8+FXlPMIKRV+qRshRoNw6Pw== X-Google-Smtp-Source: ABdhPJyc+40kNN+QfEwODpovj579RpTAexPFNALAtAnLDlspuJHh+HGMA4GfK0kShnf4gu1IDwoYVJ/1mzvSFE7li2c= X-Received: by 2002:aca:e1d6:: with SMTP id y205mr4211669oig.179.1594389327957; Fri, 10 Jul 2020 06:55:27 -0700 (PDT) MIME-Version: 1.0 References: <20200709081504.12336-1-david.marchand@redhat.com> In-Reply-To: From: Ajit Khaparde Date: Fri, 10 Jul 2020 06:55:09 -0700 Message-ID: To: David Marchand Cc: dpdk-dev , Ferruh Yigit , Thomas Monjalon , Somnath Kotur , Randy Schacher , Venkat Duvvuru , Peter Spreadborough Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 9, 2020 at 7:34 AM Ajit Khaparde wrote: > > > On Thu, Jul 9, 2020 at 1:15 AM David Marchand > wrote: > >> In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. >> Testing against a n value does not work and we end up with a link issue: >> >> /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc': >> .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference >> to `tf_em_ext_alloc' >> /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free': >> .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference >> to `tf_em_ext_free' >> collect2: error: ld returned 1 exit status >> gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3] >> Error 1 >> gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 >> >> Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") >> >> Signed-off-by: David Marchand >> > Acked-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. Thanks > > >> --- >> drivers/net/bnxt/tf_core/Makefile | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/bnxt/tf_core/Makefile >> b/drivers/net/bnxt/tf_core/Makefile >> index b4fbdd00fc..806471427c 100644 >> --- a/drivers/net/bnxt/tf_core/Makefile >> +++ b/drivers/net/bnxt/tf_core/Makefile >> @@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c >> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c >> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c >> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c >> -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) >> -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c >> +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) >> +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c >> else >> -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c >> +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c >> endif >> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c >> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c >> -- >> 2.23.0 >> >>