From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E331A0C4C; Tue, 23 Nov 2021 20:08:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6310F40040; Tue, 23 Nov 2021 20:08:05 +0100 (CET) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id BFA2F4003C for ; Tue, 23 Nov 2021 20:08:04 +0100 (CET) Received: by mail-il1-f172.google.com with SMTP id j7so59026ilk.13 for ; Tue, 23 Nov 2021 11:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CE1alVVME25ZRLIheDLBnb8vD5j38Fo3JKBJXC5Aktk=; b=Fn+WBCdjtXAjVj54nauRCLRV/DF43AL6yoPl6Nou9XW50uSir6S/j/OHQ7kX3NZalv SqQHObcg2DwFjcMl0ubmJlTmtKE5bHtoPjDRJDh6cMtLLrDlhglXzWatydQ7xS8P5WMi DmIGx5DfYIUZGXr4vpQwEbx7l0pHf4CTZr70U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CE1alVVME25ZRLIheDLBnb8vD5j38Fo3JKBJXC5Aktk=; b=J2yC9Whtm6fac7dbNo//2R0wxj/5Vxl2espIGo2+biWmj3f/hM4ec9JPe0A5iFOAn7 supuJxYoMNRMtkvimMmhPZDjhhjnbsyvweDeMc6VxLFzE0Y7fDVjaZxxPIubXaxe1qXS xFpysLh74wuNk/i7A1e7mv0ZZeFY78YB6ARhm7eiQoWtOkNLa8cX34oYPBitPn6zgucy 1YD1cbPnpHaPBoLNLmjWnqh2FRGQwOq4g3KF48WhvQMltfNQtfLPs2Rv8nBgRLYgW8dC q7nsdW1vmffKlb6yXSm3h0ceOYoQd2C5izjC/QTHyd/BpT9oNKMTCJ8mB8d1hjt1N3Z/ luqg== X-Gm-Message-State: AOAM530SZv7G6LSNxUWsv1SCbVGFfDWDg7ttaQiHsdS2tcXm3JbKhFrn x47HoQUSBtU+/++YdETRhdj5jYjK9nTzpA9PwRev0Q== X-Google-Smtp-Source: ABdhPJzY3bmxn6V8JHdiFEPW2OSh9DgvVd+0j2BCNgf7D3Lz1KpAjXmXPwtUtHuFT8xT3kWFrm2xz8271roJnHFZMfw= X-Received: by 2002:a05:6e02:20e5:: with SMTP id q5mr7939799ilv.63.1637694483975; Tue, 23 Nov 2021 11:08:03 -0800 (PST) MIME-Version: 1.0 References: <20211005125923.2651449-1-jerinj@marvell.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 23 Nov 2021 11:07:47 -0800 Message-ID: Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control To: Jerin Jacob Cc: Ori Kam , Jerin Jacob , dpdk-dev , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Ferruh Yigit , Andrew Rybchenko , Andrew Boyer , Beilei Xing , "Richardson, Bruce" , Chas Williams , "Xia, Chenbo" , Ciara Loftus , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Gaetan Rivet , Gagandeep Singh , Guoyang Zhou , Haiyue Wang , Harman Kalra , "heinrich.kuhn@corigine.com" , Hemant Agrawal , Hyong Youb Kim , Igor Chauskin , Igor Russkikh , Jakub Grajciar , Jasvinder Singh , Jian Wang , Jiawen Wu , Jingjing Wu , John Daley , John Miller , "John W. Linville" , "Wiles, Keith" , Kiran Kumar K , Lijun Ou , Liron Himi , "NBU-Contact-longli (EXTERNAL)" , Marcin Wojtas , Martin Spinler , Matan Azrad , Matt Peters , Maxime Coquelin , Michal Krawczyk , "Min Hu (Connor" , Pradeep Kumar Nalla , Nithin Dabilpuram , Qiming Yang , Qi Zhang , Radha Mohan Chintakuntla , Rahul Lakkireddy , Rasesh Mody , Rosen Xu , Sachin Saxena , Satha Koteswara Rao Kottidi , Shahed Shaikh , Shai Brandes , Shepard Siegel , Somalapuram Amaranath , Somnath Kotur , Stephen Hemminger , Steven Webster , Sunil Kumar Kori , Tetsuya Mukawa , Veerasenareddy Burru , Slava Ovsiienko , Xiao Wang , Xiaoyun Wang , Yisen Zhuang , Yong Wang , Ziyang Xuan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 23, 2021 at 2:58 AM Jerin Jacob wrote: > > On Sun, Nov 21, 2021 at 3:20 PM Ori Kam wrote: > > > > Hi Jerin, > > Hi Ori, > > > > > Sorry for my late response, > > Thanks for the review. > > > > > > -----Original Message----- > > > From: Jerin Jacob > > > Sent: Wednesday, November 17, 2021 11:49 AM > > > To: Jerin Jacob > > > Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: support priority based flow control > > > > > > On Tue, Oct 5, 2021 at 6:32 PM wrote: > > > > > > > > From: Jerin Jacob > > > > > > > > rte_eth_dev_priority_flow_ctrl_set() based API is not generic as it > > > > can not support other than VLAN priority mapping to PFC traffic class. > > > > > > > > Introducing RTE_FLOW_ACTION_TYPE_PFC_SET_TC rte_flow action to > > > > set the traffic class as per 802.1Qbb specification. This will enable, > > > > Traffic class(8bit) to be selected based on any packet field like DSCP. > > > > > > > > Also, making it as rte_flow action will enable fine control on > > > > traffic class selection to a specific queue or VF etc. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > Ping. If there are no comments on RFC, Planning to send v1 for 22.02. > > > > All the set type of functions are going to be deprecated. > > you should use RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > > > > What is the item that you are matching on when using rte_flow? Is it part of the tci in the vlan item? > > TC can be VLAN TCI field or DSCP field in IP header or any other field > in packet. > We need to set the traffic class as per 802.1Qbb specification, May I > know how the "modify" > attribute helps here. It should be a "set" operation. Right? I think "set" is appropriate.