From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
dpdk stable <stable@dpdk.org>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v4] net/bnxt: fix crash after port stop/start
Date: Mon, 23 Aug 2021 18:51:58 -0700 [thread overview]
Message-ID: <CACZ4nhvtoXk5wrBxejLuziqcvP7MXmewDyE-iX8y28xUPhBx5A@mail.gmail.com> (raw)
In-Reply-To: <20210823154453.403-1-somnath.kotur@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On Mon, Aug 23, 2021 at 8:49 AM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> On chips like Thor, port stop/start sequence could result in a crash
> in the application. This is because of false detection of a bad
> opaque in the Rx completion and the subsequent kicking-in of the ring
> reset code to recover from the condition.
> The root cause being that the port stop/start would result in the HW
> starting with fresh values, while the driver internal tracker variable
> `rx_next_cons` is still pointing to a stale value.
> Fix this by resetting rx_next_cons to 0 in bnxt_init_one_rx_ring()
>
> Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion")
> Cc: stable@dpdk.org
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Thanks Ferruh.
Patch applied to dpdk-next-net-brcm
prev parent reply other threads:[~2021-08-24 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 6:07 [dpdk-dev] [PATCH] net/bnxt: fix to reset Rx next consumer index Somnath Kotur
2021-08-19 4:48 ` Ajit Khaparde
2021-08-20 12:46 ` Ferruh Yigit
2021-08-23 6:38 ` Somnath Kotur
2021-08-23 6:33 ` [dpdk-dev] [PATCH v2] " Somnath Kotur
2021-08-23 14:43 ` [dpdk-dev] [PATCH v3] net/bnxt: fix crash after port stop/start Somnath Kotur
2021-08-23 15:43 ` [dpdk-dev] [PATCH v4] " Somnath Kotur
2021-08-23 15:44 ` Somnath Kotur
2021-08-24 1:51 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhvtoXk5wrBxejLuziqcvP7MXmewDyE-iX8y28xUPhBx5A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).