From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30B4BA0C46; Tue, 24 Aug 2021 03:52:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB4EB40F35; Tue, 24 Aug 2021 03:52:16 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 3A0CA406A3 for ; Tue, 24 Aug 2021 03:52:15 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id t190so21480922qke.7 for ; Mon, 23 Aug 2021 18:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FgLR9omDofMBNgJKkMR/tXgUO2SlEnvONRi6FwEZAdw=; b=STu4xL6wfa2tnMCu/bGV4lnWNTQLHYF136vRDj6503GTsdm+W0U0Ey+MRg7ZXjBXk/ ppiytZZwcR6RrUmUcr9fDnhjr5wRf53n1bz1T2NU0WNsDf9dv0fmlpFBCuwSnq3zL/Yt h0wMJmkU/yu3MRr/7XASghYLRAIqTonVfO02U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FgLR9omDofMBNgJKkMR/tXgUO2SlEnvONRi6FwEZAdw=; b=CqWZENJakjegv+c6cmpDOFsXNHQR+5NEH34YFyQHVDdo11DJJd/M+TXn3lokO3ZnjB nn7dI4HaSxz+KcRbLhe+37gRVABAe1tx5EM7Ryxn0OohKAE2oXiO2vVPBP4+sYcXnoHV ZHyO/HKdZmiH/LwJ4meZuPCrH9pT13W5MWm7t8C0w3j3HS+eWBk858RgZrmZNu7HEr7Q XFSG926QaS4T5N1VBzWEKfkur6kFwIhU/lxPMjBP9rmJg7HILEkbALpYUHgylF8JGQqK cQB7GT1VcpnVNXiYXUAJTg+WAbzurkkYC5gr7J69yfyepYVUbROA5O4WcUkRkZNbbMte I/+w== X-Gm-Message-State: AOAM532/aBdHjH+r17T1o+iNoicILJLKyqyIka2alZk6uUCu6N9+cr0G 0MLDtsgGyF0w9I374hS8GpnS0/F88YYve10s4aE3rg== X-Google-Smtp-Source: ABdhPJxd1QL3hRQAeeSB35viXhsntZoEhyCl8wGBTQfNnUX2Gjogpue4iUVjGhDXHMFZP6vNAJiKQD/Jo5+/yaE8gZs= X-Received: by 2002:a05:620a:d8e:: with SMTP id q14mr24135212qkl.409.1629769934562; Mon, 23 Aug 2021 18:52:14 -0700 (PDT) MIME-Version: 1.0 References: <20210810060731.30127-1-somnath.kotur@broadcom.com> <20210823154453.403-1-somnath.kotur@broadcom.com> In-Reply-To: <20210823154453.403-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Mon, 23 Aug 2021 18:51:58 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , dpdk stable , Kalesh AP Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000083eca05ca44623c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v4] net/bnxt: fix crash after port stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000083eca05ca44623c Content-Type: text/plain; charset="UTF-8" On Mon, Aug 23, 2021 at 8:49 AM Somnath Kotur wrote: > > On chips like Thor, port stop/start sequence could result in a crash > in the application. This is because of false detection of a bad > opaque in the Rx completion and the subsequent kicking-in of the ring > reset code to recover from the condition. > The root cause being that the port stop/start would result in the HW > starting with fresh values, while the driver internal tracker variable > `rx_next_cons` is still pointing to a stale value. > Fix this by resetting rx_next_cons to 0 in bnxt_init_one_rx_ring() > > Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") > Cc: stable@dpdk.org > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh AP > Reviewed-by: Ajit Khaparde Thanks Ferruh. Patch applied to dpdk-next-net-brcm --000000000000083eca05ca44623c--