From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 807B2A0093; Thu, 13 Jan 2022 13:41:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE18E42730; Thu, 13 Jan 2022 13:41:54 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id D2D7B40150 for ; Thu, 13 Jan 2022 13:41:53 +0100 (CET) Received: by mail-ot1-f45.google.com with SMTP id 35-20020a9d08a6000000b00579cd5e605eso6123552otf.0 for ; Thu, 13 Jan 2022 04:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IUHyA9t+pa92Znj+wE8P9cEf3tMWstQvNJUl3pzt1gM=; b=ETjIO5IFbRKNjiis37MXnsHqOor49rnP6CuBN6MEFqhC8gCdIEXifaQZ1kCUyYNqpi gKDmyfhL+aZB/EKuyON4YsF5x83njF29WCT92tf6NS119T+6S3NxZKdJqj2Q4SOe5YoK STF0tTtS6l6s94AJ/pxruoA69BIGJIx9NHlnyDvhvN3PQwWd1DDYamWmdqtirWb9OHWP UwY+DxCZ+DtMJ+KDyoJX20MoysUgYacQJYK67fPW6Yua8JJDr4/hl67hPasNwQgr8BTZ M916mh8RosZRBuXWYGGZzs5SUZ1Rp3RmglYuUr2ev6qmYplges1v2BYWQJD3jWNim3Pk WlwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IUHyA9t+pa92Znj+wE8P9cEf3tMWstQvNJUl3pzt1gM=; b=kkxSa85PmcUkem6vlBMnVelyG21bhr70QmjY8nzuB8WzoXkdxCyauXXUZYwRLWWJ36 BMP0YYk8oPe9z9LHK9y2c/Zk8V7zfgvLof8jTWYRZfousWqxYq58HCGT3j5xyG1PTTO7 JoETKQQDs4cpOX+E4zH13oqfgKThcHbVZBIdKwoOx7zyUhKozgWXdrNtpszjiNz4JXgw a3W2p4D1WtKjN7uxw2jTPYOxr1gQY0Tl0MrI3q2gfUJm/2f65TAGrEFWDZfFGQjQAeHJ D+OndQQVbjCPQwBL+ameEJlGK4skn4nqZ7YbdWiZRdZY/5GpKzVMKZLql+qC6+q9qbdC rq9Q== X-Gm-Message-State: AOAM530OFsOR387vvSQph2h/7PiSPN3JyEDS70Q2Jsg2gfjmBOUlU7Eg VjW3vy/EwkBGBawQ/Oa1hRsILYboJ3q8TnVHi/D6MRf/LCb0+g== X-Google-Smtp-Source: ABdhPJyB/4LYNnrWu45szzaSIH8sCfkAfRh35xAgUyywIEHM0miKhj3FRBO8kPRiDAyUcBLPgMtwvF/UyuVTrv9NHWc= X-Received: by 2002:a9d:4d8d:: with SMTP id u13mr3018168otk.246.1642077713087; Thu, 13 Jan 2022 04:41:53 -0800 (PST) MIME-Version: 1.0 References: <20220112065019.58924-1-jsoref@gmail.com> <20220112065019.58924-2-jsoref@gmail.com> <3172041.VqM8IeB0Os@thomas> In-Reply-To: <3172041.VqM8IeB0Os@thomas> From: Josh Soref Date: Thu, 13 Jan 2022 07:41:42 -0500 Message-ID: Subject: Re: [PATCH 1/1] ci: restrict concurrency To: Thomas Monjalon Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000c8418305d576027b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000c8418305d576027b Content-Type: text/plain; charset="UTF-8" On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon wrote: > Hi, > > The explanation should be in the patch, not the cover letter. > Actually, you don't need a cover letter for a single patch. > Copying it here: > " > dpdk is fairly expensive to build in GitHub. > > It's helpful to abandon old builds as soon as there's a new > build waiting instead of wasting resources on the previous > round. > " > > 12/01/2022 07:50, Josh Soref: > > Signed-off-by: Josh Soref > > --- > > + concurrency: > > + group: build-${{ matrix.config.os }}-${{ matrix.config.compiler > }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{ > matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }} > > + cancel-in-progress: true > > The goal of the CI is to catch any issue in a submitted patch. > Is your change cancelling a test of a patch when another one is submitted? > If it's on the same branch or if it's in the same pull request yes, otherwise, no. > --000000000000c8418305d576027b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
Hi,

The explanation should be in the patch, not the cover letter.
Actually, you don't need a cover letter for a single patch.
Copying it here:
"
dpdk is fairly expensive to build in GitHub.

It's helpful to abandon old builds as soon as there's a new
build waiting instead of wasting resources on the previous
round.
"

12/01/2022 07:50, Josh Soref:
> Signed-off-by: Josh Soref <jsoref@gmail.com>
> ---
> +=C2=A0 =C2=A0 concurrency:
> +=C2=A0 =C2=A0 =C2=A0 group: build-${{ matrix.config.os }}-${{ matrix.= config.compiler }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-= ${{ matrix.config.mini }}-${{ github.event.pull_request.number || github.re= f }}
> +=C2=A0 =C2=A0 =C2=A0 cancel-in-progress: true

The goal of the CI is to catch any issue in a submitted patch.
Is your change cancelling a test of a patch when another one is submitted?<= br>

I= f it's on the same branch or if it's in the same pull request yes, = otherwise, no.
--000000000000c8418305d576027b--