On 11/29/2021 1:59 PM, Bruce Richardson wrote:
> On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:
>> Hi Josh, Thanks for the patch.
>>
>> The typo fixes for comments and logs are more straightforward, but I have
>> mixed feeling about the variable / macro typo fixes, let's see what others
>> think.
>>
>> And I think we should get this patch either one of the first patch or last
>> patch to prevent conflict with other patches.
>
> +1 to being a first patch to start things off clean.
>
> For the macros, since there is quick a bit of content in the patch, could
> we have the patch split into a separate patch for macro changes to review
> separately, allowing the simple doc/printf spelling changes to go in
> immediately?
Yeah, this is doable. I'll see if I can do it now. It's a lot of files, plus I'll need to figure out the command sequence to reply to this thread. If someone is available on Slack for some handholding, that might help me get it done faster.
Also as far as I can see there are multiple build errors related to the
variable / macro renames, which was the concern.
I'm used to having access to GitHub based CI that let me test before making a PR. I've locally dropped the peer change, but didn't resubmit since I figured I'd wait for replies.
(Last night I installed meson and ninja, so I might be able to do a local build.)