DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nirmal Sarkar <nirmal.kisan@gmail.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"Thomas Monjalon" <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Andrew Rybchenko" <arybchenko@solarflare.com>,
	"Roberts, Lee A." <lee.roberts@hpe.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen
Date: Tue, 26 Nov 2019 13:51:37 +0530	[thread overview]
Message-ID: <CACeX4O_uDEu8D6EKHnf+pnwnRM6u7vQnMs8NEm6Osu=8QYMWCQ@mail.gmail.com> (raw)
In-Reply-To: <788C0E34-44F9-4E04-86C2-1F1B11FDE59C@intel.com>

Hello,

To support Jumbo frame in dpdk-pktgen,  changes were suggested in dpdk
libraries also apart from pktgen code.

*lib/librte_mbuf/rte_mbuf.h *
*lib/common/pg_inet.h *

But dpdk framework already supports jumbo frame [using *--enable-jumbo* &
*--max-pkt-len* flag].
Can you please help me to understand why do we need to change the libraries
in dpdk ?

Regards,
N. Sarkar

On Thu, Nov 21, 2019 at 12:24 AM Wiles, Keith <keith.wiles@intel.com> wrote:

>
>
> > On Nov 20, 2019, at 6:09 AM, Nirmal Sarkar <nirmal.kisan@gmail.com>
> wrote:
> >
> > Hello,
> >
> > Thanks for the help.
> > As I'm using DPDK-18.11.1, I did not find the definition of
> > "RTE_ETHER_MAX_LEN" in lib/librte_net/rte_ether.h file.
> > So I set "ETHER_MAX_LEN" value to 9600.
> > Apart from that I took rest of the changes and with these I'm able to
> send
> > jumbo frame.
> > Took tcpdump on the receiving end.
> >
> > Suddenly I got stuck at ARP. I could not send packets anymore.
>
> Sorry, I can not tell what the error condition is you are hitting, as the
> two screen dumps do not provide me where I should start looking. If you can
> help me understand the issue better.
> >
> > I've attached success & failure scenario.
> >
> > Regards,
> > N. Sarkar
> >
> > On Wed, Nov 20, 2019 at 2:14 AM Morten Brørup <mb@smartsharesystems.com>
> > wrote:
> >
> >> John, Marko,
> >>
> >> It seems we are missing documentation about enabling Jumbo frames in an
> >> application, and possibly an example of using the
> rte_eth_dev_info->max_mtu.
> >>
> >>
> >> Med venlig hilsen / kind regards
> >> - Morten Brørup
> >>
> >>> -----Original Message-----
> >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roberts, Lee A.
> >>> Sent: Tuesday, November 19, 2019 6:42 PM
> >>> To: Nirmal Sarkar; dev@dpdk.org
> >>> Subject: Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen
> >>>
> >>> Nirmal,
> >>>
> >>> Here are the changes that I've been using to allow jumbo frames with
> >> dpdk-
> >>> 19.08 and
> >>> pktgen-19.10.0:
> >>>
> >>> diff -r default/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h jumbo/dpdk-
> >>> 19.08/lib/librte_mbuf/rte_mbuf.h
> >>> 462c462
> >>> < #define     RTE_MBUF_DEFAULT_DATAROOM       2048
> >>> ---
> >>>> #define     RTE_MBUF_DEFAULT_DATAROOM       9600
> >>> diff -r default/dpdk-19.08/lib/librte_net/rte_ether.h jumbo/dpdk-
> >>> 19.08/lib/librte_net/rte_ether.h
> >>> 33c33
> >>> < #define RTE_ETHER_MAX_LEN   1518  /**< Maximum frame len, including
> >> CRC.
> >>> */
> >>> ---
> >>>> #define RTE_ETHER_MAX_LEN   9600  /**< Maximum frame len, including
> >> CRC.
> >>> */
> >>> diff -r default/pktgen-19.10.0/app/pktgen.c jumbo/pktgen-
> >>> 19.10.0/app/pktgen.c
> >>> 749c749
> >>> <     else if ( (plen >= 1024) && (plen <= PG_ETHER_MAX_LEN))
> >>> ---
> >>>>    else if ( (plen >= 1024) && (plen <= 1518))
> >>> 753c753
> >>> <     else if (plen > PG_ETHER_MAX_LEN)
> >>> ---
> >>>>    else if (plen > 1518)
> >>> diff -r default/pktgen-19.10.0/lib/common/pg_inet.h jumbo/pktgen-
> >>> 19.10.0/lib/common/pg_inet.h
> >>> 379,380c379,380
> >>> < #define ETH_MTU                     1500    /* Max MTU for Ethernet
> */
> >>> < #define ETH_MAX_PKT                 1518    /* Max Ethernet frame
> size
> >> */
> >>> ---
> >>>> #define ETH_MTU                     9600    /* Max MTU for Ethernet */
> >>>> #define ETH_MAX_PKT                 9600    /* Max Ethernet frame size
> >> */
> >>>
> >>>                                   - Lee Roberts
> >>>
> >>>
> >>> -----Original Message-----
> >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nirmal Sarkar
> >>> Sent: Monday, November 18, 2019 10:26 AM
> >>> To: dev@dpdk.org
> >>> Subject: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen
> >>>
> >>> Hello,
> >>>
> >>> I'm trying to explore pktgen and dpdk-pktgen with Jumbo frame.
> >>>
> >>> I'm using ubuntu-18.04 system where pktgen is a kernel module and I
> don't
> >>> have any provision to set it for Jumbo frame.
> >>> Can you please suggest how to configure Jumbo frame in pktgen ?
> >>>
> >>> In dpdk source code, I've modified RTE_MBUF_DEFAULT_DATAROOM [
> >>> *lib/librte_mbuf/rte_mbuf.h*] value with 9K and built.
> >>> During testing, I could not send packet size more than 1500 byte.
> >>> What is the suggestion to overcome this problem ?
> >>>
> >>> Regards,
> >>> N. Sarkar
> >>
> > <success.txt><failure.txt>
>
> Regards,
> Keith
>
>

  reply	other threads:[~2019-11-26 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 17:25 Nirmal Sarkar
2019-11-19 17:42 ` Roberts, Lee A.
2019-11-19 20:44   ` Morten Brørup
2019-11-20 12:09     ` Nirmal Sarkar
2019-11-20 18:54       ` Wiles, Keith
2019-11-26  8:21         ` Nirmal Sarkar [this message]
2019-11-27 15:12           ` Wiles, Keith
2019-11-27 18:42             ` Nirmal Sarkar
2019-11-30  0:01   ` Wiles, Keith
2019-12-01 19:55     ` Nirmal Sarkar
2019-12-02 12:46       ` Nirmal Sarkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACeX4O_uDEu8D6EKHnf+pnwnRM6u7vQnMs8NEm6Osu=8QYMWCQ@mail.gmail.com' \
    --to=nirmal.kisan@gmail.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=lee.roberts@hpe.com \
    --cc=marko.kovacevic@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).