From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] vfio: failed to select IOMMU type
Date: Wed, 5 Apr 2017 08:15:28 +0100 [thread overview]
Message-ID: <CAD+H990AkXWHzKB2zjcxyLEJyWKuOx22ez6TJFY=PZeNKP=cMQ@mail.gmail.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236978220D823@IRSMSX109.ger.corp.intel.com>
On Tue, Apr 4, 2017 at 5:20 PM, Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> Hi Andrew,
>
> > Please, take a look at http://dpdk.org/dev/patchwork/patch/23202/
>
> I took a quick look. It should fix the problem (closing the group will
> cause container detachment, so we can always assume that if there's no
> container associated with the group, there are no devices within that
> group). The issue of vfio_release_device() still remains. I think the fix
> for that would closely follow what you did here: close the dev_fd, check if
> the group still has a container associated with it, and if not, close the
> group_fd and clear the group.
>
>
That could work. When implementing the hotplug I realize the kernel could
give more info about a particular group status. Maybe I propose some
changes for facilitating this, even if we can fix the issue just checking
if there is a container there.
> I cannot thoroughly test it right this moment, however I'll have time
> later during the week.
>
> Thanks,
> Anatoly
>
next prev parent reply other threads:[~2017-04-05 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 10:46 Andrew Rybchenko
2017-04-03 16:11 ` Burakov, Anatoly
2017-04-04 15:29 ` Andrew Rybchenko
2017-04-04 15:52 ` Burakov, Anatoly
2017-04-04 16:10 ` Andrew Rybchenko
2017-04-04 16:20 ` Burakov, Anatoly
2017-04-05 7:15 ` Alejandro Lucero [this message]
2017-04-05 7:12 ` Alejandro Lucero
2017-04-06 9:10 ` Burakov, Anatoly
2017-04-18 11:22 ` Alejandro Lucero
2017-04-24 9:09 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H990AkXWHzKB2zjcxyLEJyWKuOx22ez6TJFY=PZeNKP=cMQ@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).