From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 4E6A91B27F for ; Fri, 17 Nov 2017 22:17:17 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r68so8925070wmr.1 for ; Fri, 17 Nov 2017 13:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YAYnxwtrGa0w3siwXkdh39fl0RnNx3kgty6W1wT4ECw=; b=ps008NEuR1eu80b6EHxAHxsxfhp4bz0zdZxsYUcS35DNWLv0p0Kyp2mnJg9ZJnwJk3 fYRb9BSlUbaeyIdiQaSh7DZSebF8oFEflt4uVtgypaJ1TwVs/GSR/1XgLV7ApKDnaEMs ILqW7DDpn3X7JHMdY/7/qNZAfX3SrWQY/xJTL90sHM5/MYG8NF2+q6+RcKc14TtUNEg9 iWVpIZ6O5sDItShvmzPr/faxbCQGo0dIowwNfb182wiMPZ3tglEP7KxPAZtUCJeTVRVa /pTmS9jqrEB+8cuWlUPy+d2DABR0iNYPbEkz+peXZgYWBuMEljywCf03WaNkOxM3PSKG 9WOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YAYnxwtrGa0w3siwXkdh39fl0RnNx3kgty6W1wT4ECw=; b=atbmzinWQWc3WfUhvkvoVBL0Iy2TulKexZABZAJJpD/40A9vWGQMGmlxYFSFPq4eLU D9tgFQxqCFW2I4RXsmJZyJCKfoz68xMlej5SAC4qv9143txKJ7JJmZpPI2djyA59sdMK EI/WDIhei7eB75/EMJ0AMHZZyfQELLNfKZklVtiPgODcG3MXprCkAcmyJKPn2d5n7Jl7 A5crKKSr12csaXog8Y5uBxkCAEEB0/kqxBFuO2VwVqbXEzIotXw9eibFreiGLzNsP7Nn vcdi4C2n+4hqY3nA0k0MzZuCErp67/meNzanyNYcWxJ0TMa62azKjZpGShr8sOMlj0ax M9Cg== X-Gm-Message-State: AJaThX7LYnz0VtTAvRQWlgmqc0ynpcSfh9UlopnMrSWbN65zOXiVjfrY JyNo+Jx1r1FSQHOtsscGTkcRD4wTLr8a6Bg+Tw7VSQ== X-Google-Smtp-Source: AGs4zMYU8bzVAzBsw80ATIk6seSZ/vgKPRUDRKvyHq3ciYk5xeBMS0Y4MswZkRtvfoVHQNyF0oYeaCNtwVqz+tdS3Ok= X-Received: by 10.80.212.27 with SMTP id t27mr7156128edh.89.1510953436739; Fri, 17 Nov 2017 13:17:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.226.72 with HTTP; Fri, 17 Nov 2017 13:17:16 -0800 (PST) In-Reply-To: <1510943014-8767-1-git-send-email-alejandro.lucero@netronome.com> References: <1510943014-8767-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Fri, 17 Nov 2017 21:17:16 +0000 Message-ID: To: dev Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix check when jumbos and strip CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 21:17:17 -0000 Wrong patch. I have removed it from patchwork. On Fri, Nov 17, 2017 at 6:23 PM, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > We have two problems here. First the jumbo frame check should not be > there at all. Then, the configuration should not fail in any case > related to CRC striping. > > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index 0501156..99401c5 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -488,13 +488,8 @@ enum nfp_qcp_ptr { > return -EINVAL; > } > > - if (rxmode->jumbo_frame) > - /* this is handled in rte_eth_dev_configure */ > - > - if (rxmode->hw_strip_crc) { > - PMD_INIT_LOG(INFO, "strip CRC not supported"); > - return -EINVAL; > - } > + if (!rxmode->hw_strip_crc) > + PMD_INIT_LOG(INFO, "avoid CRC strip is not supported by > HW"); > > if (rxmode->enable_scatter) { > PMD_INIT_LOG(INFO, "Scatter not supported"); > -- > 1.9.1 > >