From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <alejandro.lucero@netronome.com> Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com [209.85.213.47]) by dpdk.org (Postfix) with ESMTP id 215D45582 for <dev@dpdk.org>; Fri, 18 Nov 2016 17:50:36 +0100 (CET) Received: by mail-vk0-f47.google.com with SMTP id x186so172356759vkd.1 for <dev@dpdk.org>; Fri, 18 Nov 2016 08:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MK7f13MXQfst16iaARSOTaJJmPfxMwXASnBvXMW9n3E=; b=0FXGeUXoiQoFdULI8GUGKJBu70vSoRdj8LOgB/hh32+LxmvJeES380C2ehfJT41k8f uo/VwgAHbnXwhkVijED9vwT/txenGCI6hSCohVmP5XquFDt4JK0sm/ne2WUh+2A8CP6m yf5aSdtmVAT4GK+thLILP7TySTwqUv8ECOJBlS96rBH6+qd70u6g2faz7G40aUL+tRJ+ zIOnOiEDx3AgO7Wpf8H9b+R/hP0KrMtMNt4AL7hXeX76MmJwXSkhymQoAP5nNISitCHQ yt/Q9N7dOGAdypmryWprg7sP/jX3PNAjQ12k+i18yGMhDYb7bxHXzqD9TBF5B38H5WTo gwhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MK7f13MXQfst16iaARSOTaJJmPfxMwXASnBvXMW9n3E=; b=CltZ1XLcFnvwS57MFfuP8TLO8YmDB6cw0X30e2zXO6VI/1El9ObTxdG2wuxwnjey4l ZTdrpJhsADwRd9ZjtAYfnn2zB+ySzCe1Xx2E1j+Dd0viJUv2R228/A1wm8cVRmau0HJj jCbMtyNjavZRu2GUFKMITfRS6AELGhRUfsizBboI8YU/+hk1ImVXMtKEW049zPMYEGTQ 6cSSqQJEClljnJ59gmvEVkrNKriUearqvmUgBx/hlgS0Oeo/oT0G2NxahKZ8Rq/rtFds U/f6KhKTD3cLrD9iP4rjX/BN9x1cq3yim51gldm65Wee1EZNtziwh/qa84AqYHnity81 QEkA== X-Gm-Message-State: AKaTC02IlcR5Fpio+YBcwjp2GxiQMGMiRVmddXKfgxVLQsewciSfp0kOAGgvw+AcpbfLIftmrqXqzyE8IQVUfZwS X-Received: by 10.31.49.216 with SMTP id x207mr422123vkx.82.1479487836325; Fri, 18 Nov 2016 08:50:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.79.145 with HTTP; Fri, 18 Nov 2016 08:50:35 -0800 (PST) In-Reply-To: <1901770.8floaBijqc@xps13> References: <1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com> <1901770.8floaBijqc@xps13> From: Alejandro Lucero <alejandro.lucero@netronome.com> Date: Fri, 18 Nov 2016 16:50:35 +0000 Message-ID: <CAD+H990O-ZwxOtQ1DORTH7yanv-DY8wbzUUnv1AWoTiU+7YiEw@mail.gmail.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: dev <dev@dpdk.org> Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 18 Nov 2016 16:50:37 -0000 On Fri, Nov 18, 2016 at 4:29 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > 2016-11-18 16:06, Alejandro Lucero: > > Previous reported speed was hardcoded. > > > > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com> > > --- > > drivers/net/nfp/nfp_net.c | 28 ++++++++++++++++++++++++++-- > > drivers/net/nfp/nfp_net_ctrl.h | 13 +++++++++++++ > > 2 files changed, 39 insertions(+), 2 deletions(-) > > You should update the doc in the same patch: > doc/guides/nics/features/nfp.ini > It will be the first feature as the file appears to be empty. > So you will need another patch to fill other existing features. > Yes. I'm just working on updating that file properly. May I delay this doc change for including it with that other one? It will be a bit weird to just have one feature there. > > I have an unrelated question: why nfp is disabled in the default build? > > Because NFP PMD can just work if Netronome BSP is installed in the system. We do not support PF with the PMD, so it requires a Linux PF driver which comes with the BSP. The compilation has no dependencies, but we had our own UIO driver before (now using igb_uio). So basically, we wanted the people aware of this dependency and to specifically configure this option. I know what you are surely going to ask about DPDK in Linux distributions, and that this being a bad idea. The fact is, we have people using NFP PMD as part of a product, so installing that product implies to (automatically) install the BSP and a specific DPDK version with the NFP PMD enabled. But yes, maybe we should modify this and to add some sort of BSP check inside the PMD. So, thanks for the heads up. I will think about this.