From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 7B0AE1C0BA for ; Fri, 13 Apr 2018 19:06:50 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id s18so9881848wrg.9 for ; Fri, 13 Apr 2018 10:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ExqBl73rLtxwbmLw72yxmOv7S3DfaR7EmjKgFnXHwl0=; b=YLCJ3nsgGifPS62gtFbHApBFC6XTkHVITIdX7H0tqBDK2rTArym1ZrmUrCw3j5m7ko cEbI/t5zwpdoZAMswkYBOaKCC3hjbCRL1tpddpKVEjhF7zQOa/YFitRLCXUgemVsuFDH u/zAcSf/5KyGGaboEI0CnDY3P6d1h5eaIgvOJVP0kF/duZMoPXN7zvQ4jiB1QMJatYT5 e3JmsCm+3pjfXtyaVbfmTpj/7XGeHBApV0sl2wFVQN9LbWUnyT1qW9IiDARvPspD3uRB GVi0CfddG1VzN+DA24Dgj1OZuMspNLNVpzFww75pfI4KK5AhcZT3+7jnhYGR6FsSLbdD rkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ExqBl73rLtxwbmLw72yxmOv7S3DfaR7EmjKgFnXHwl0=; b=tKD4YuH6r7iDtBg1hjHVWgC2bH+wwyn6mjIvM+V6qHuambMQ1NtCzBqulYpketC/+U Pa6Xje4LMgXi8lNHNpY4qQqw2EOrEVuHMSzrg5Kq08psrJ1jCaeBq/aVPX/sXM10rsUf sZ2c9EdpfT5EnTR8YXr/xb14wqA9XNNLxqw4MnYikGEitRD4xRbDkLOYUInCpTcPPGDF CB2uYHoXaKg5PM5ChQJsKQSwXIbn4es+2434CNL9UXM4OZVUPWI56jGpijjolu5rnIKR HwrqCJ1EkbC5cT6c2GrYVSwB2t4iGnmQz1ewB0KbEje433pns5vond/odib1vxVyBa/o QAJQ== X-Gm-Message-State: ALQs6tBGR3eioAxE8cqUhTu+3P0Iib+7uLwz3OGk3l47gc3iFyfM9Tb4 /hVdtnezTXeJS69igWGxoM7DPZZW5gKw/iOyGyKzmA== X-Google-Smtp-Source: AIpwx49Hb931Eqs3y1dsWZWEemcsYDco5uaxbu7aKKXl4mnWPjOTtjW3cbXPoLjj9ssSQ5ubQUpHf7lwNa3m+SPq3rc= X-Received: by 10.80.234.132 with SMTP id d4mr20528684edo.97.1523639210130; Fri, 13 Apr 2018 10:06:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.203.69 with HTTP; Fri, 13 Apr 2018 10:06:49 -0700 (PDT) In-Reply-To: <9aa1ad5f-95d0-605e-26e5-5a823767f455@intel.com> References: <1523617233-12228-1-git-send-email-alejandro.lucero@netronome.com> <9aa1ad5f-95d0-605e-26e5-5a823767f455@intel.com> From: Alejandro Lucero Date: Fri, 13 Apr 2018 18:06:49 +0100 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: add support for chaning MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 17:06:50 -0000 Hi Ferruh, On Fri, Apr 13, 2018 at 6:02 PM, Ferruh Yigit wrote: > On 4/13/2018 12:00 PM, Alejandro Lucero wrote: > > This patch allows to use another MAC address than the one coming > > with the NIC by default. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index bedd4b6..7db438c 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -109,6 +109,8 @@ static int nfp_net_rss_reta_write(struct rte_eth_dev > *dev, > > uint16_t reta_size); > > static int nfp_net_rss_hash_write(struct rte_eth_dev *dev, > > struct rte_eth_rss_conf *rss_conf); > > +static void nfp_set_mac_addr(struct rte_eth_dev *dev, > > + struct ether_addr *mac_addr); > > Hi Alejandro, > > mac_addr_set dev_ops is changed in this release [1], new prototype is [2], > patch > is still in next-net, can you please rebase this patch on latest next-net? > Sure. I will do that asap. Thanks! > > > [1] > 703ee2278382 ("ethdev: return diagnostic when setting MAC address") > https://dpdk.org/dev/patchwork/patch/37951/ > > [2] > typedef int (*eth_mac_addr_set_t)(struct rte_eth_dev *dev, > struct ether_addr *mac_addr); >