From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f53.google.com (mail-vk0-f53.google.com [209.85.213.53]) by dpdk.org (Postfix) with ESMTP id 4D3AE20F for ; Tue, 16 May 2017 12:17:13 +0200 (CEST) Received: by mail-vk0-f53.google.com with SMTP id y190so63064879vkc.1 for ; Tue, 16 May 2017 03:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A+LfZgwFvPJ1cu5ilTP1ARS1K4/nv/qFfkTItxbKCCc=; b=TwvkuaODH9qKeD823oFPoPdykfuKEHyn6GDDOGXwK93ToIHgTXq5Q8tmfpxypMlPeh mnTDI9MMuIWm0CUkBrNZcVGtxNkh8nI+Z09X1AnfLB2ZKQQ80EoIsSk3NU+0FFElzS35 bhBCfy7YJkq3wEXBkcW1xWX6NnEqcuBkHXDkPWg57Wbjvy7q/vB4sbmD5QY1S0FGqTPm dZApVs8XhFqCsvhHbaifmImiAdwbX8/q66kFnX2J8xGuHP4C+xB0SOqqMucgklGhPzbl tKlYqNBu7NOKLDeywrh6EoI4voJO+dAgMkQIxzgkmzxLYgS2Yc8j29iUAlLtWZ5BEq6Z YfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A+LfZgwFvPJ1cu5ilTP1ARS1K4/nv/qFfkTItxbKCCc=; b=iFaa6pqzEgsfq10TkTJjy/1CgMcoX+Pj1h2AqGCroxA6Ij8pd7oNZmxYKt437bXRje Fk1EDfFJIRAdOl5SNBtnfPKbVrd/vtBxBFvyPaQg9xk9Wxxxd7iQL9SPWLrCE0BGzdVR EJZDIq9pzWzErzHYGbJVHLN5Wb6O1Mup9C0uHjFT8MYyZANawuhJ547fqRTiki2OPylJ BEk7Q2c2om31CDc8twqQyShf+Qv5CLSqiO5dbwwCOWFCZYiD5DD5iXfj9uxI+FflffCG YBFTa5gPAj7cqxd1b4QHo8/lQkNidWhzjDCXms0HuAx+xLOL6brsim8mH3fIapTge5DJ F2VQ== X-Gm-Message-State: AODbwcD4ZVhs3DpXKc7XFdtUSg8wkpPJm3LY60IihqXRmxMqqBzmmzej 4WwwPK0XPyRr+OJNEe96KAtEkcEnqAb9 X-Received: by 10.31.238.143 with SMTP id m137mr5315215vkh.109.1494929832493; Tue, 16 May 2017 03:17:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.40.135 with HTTP; Tue, 16 May 2017 03:17:11 -0700 (PDT) In-Reply-To: <3454007.3ZDP6eXIq0@xps> References: <20170510131053.75843-1-ferruh.yigit@intel.com> <17406199.hqjMraK9H2@xps> <3454007.3ZDP6eXIq0@xps> From: Alejandro Lucero Date: Tue, 16 May 2017 11:17:11 +0100 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dev , Shepard Siegel , Ed Czeck , John Miller , John McNamara , Harish Patil , Rasesh Mody , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Jing Chen , Helin Zhang , Jingjing Wu , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Matej Vido , Pascal Mazon , Yuanhan Liu , Maxime Coquelin , Shrikrishna Khare Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 10:17:13 -0000 On Tue, May 16, 2017 at 11:02 AM, Thomas Monjalon wrote: > 16/05/2017 11:39, Alejandro Lucero: > > Maybe we need another feature for detected link speed report capability. > > > > There is already support for ETH_SPEED_NUM_NONE if the speed is not > defined > > or it can not be specified by the device. Netronome has some firmwares > > without that link speed report capability, although maybe we are not the > > only ones with that problem. > > > > > > What do you think about this? > > Yes, you mean you can advertise a speed capability, > but cannot report the real negotiated speed, right? > So we could add this feature. > Perfect. > There are also virtual drivers which cannot report some real speed. > > Yes, that is right. Virtual drivers can not report speed. We have a problem with a client using pktgen which assumes a device will report the link speed always. By the way, I will send a patch for avoiding this issue with pktgen. Thanks