From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 89CF41C67E for ; Fri, 13 Apr 2018 17:36:26 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id o3so9217720wri.2 for ; Fri, 13 Apr 2018 08:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=x9afrbeH+uShMdcdbwlb+utRUMoXS8fRTp7Cr0SoBFo=; b=TeLu49A/QwXIi8+gpW8uT0ZquYX5shoa9QgcX3CmH3ycKEkzrpEYOiaqf2oLFH3Gdc pDOysTrxsfGne8HiMrDuSVPeYVr1BeAX+J7aIcCYR+UkGaF/kMVQWCAzvDMlkrQM7SlA rj4PDvkxbKsfADGJifqWiaR3YIN0B4XpnuoX4s94HKHvKLHexv0aPV5ts3uz1uGXx/V4 m185/SQFypIcHaPeGQueXCsuGUbHvCfeqF7D+tFDLH/QowQF08XpfH779U2KPZlYzUpP XJ3EFVbLQgqwIva32cFH+TN28mmhk19O+SxKzgITpiJm/2ltCTrplFglw/sWxYNPJ+uw kJNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=x9afrbeH+uShMdcdbwlb+utRUMoXS8fRTp7Cr0SoBFo=; b=mA+tQ0Euf2XHW3+2yA/adfTwRpt3yos97b8V8AjTZq8aH2NqtNkCzO9yN+Poi0YHFp 5YirmKpt6JpFdDzEIFW0iFoL/fkxVI+jUGdlHKkWO1KKH3oDXufWvBrRzAxdHiIvlO3+ aGkTm24DOW+DblAwpG/VT2dqKURKUtq0M7srGwLqyGDVHMzlAfZJYa47wCTuw1jrHmbi 7zTtsNJS54SH+VYD7Tp+W1/q5zI3Sr80As0WI224OYvwFB8EIFybkmZF4wb0oh8J8jpt D5+1IHnVMMViXAPjCbnk9rnTtHFyVgAQ4WEqgAWLvueRQNp4nEOoOyZ6oqWCA0IjyjaE OrlA== X-Gm-Message-State: ALQs6tBn7ld9I9YLAHTS82yErAxD1KZkFwrkP94BHx9Ug3dWEQmU5BPJ 9E+LmRS3rBGj0faPR2RFGVizrh8L+xv//UDYL/QCPQ== X-Google-Smtp-Source: AIpwx49ji8AwBpohD8hyvXbXDwgxagbI53HuKK1I6uSUp5GOmFr+Yqk4c37N0x/9J1O0CAMQvFoTANJ1UVxcF3kfzzc= X-Received: by 10.80.189.130 with SMTP id y2mr20767753edh.138.1523633786383; Fri, 13 Apr 2018 08:36:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.203.69 with HTTP; Fri, 13 Apr 2018 08:36:25 -0700 (PDT) In-Reply-To: References: <20180412222208.11770-1-aconole@redhat.com> From: Alejandro Lucero Date: Fri, 13 Apr 2018 16:36:25 +0100 Message-ID: To: Aaron Conole Cc: dev , Eelco Chaudron , Pablo Cascon , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 0/2] nfp driver fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 15:36:26 -0000 On Fri, Apr 13, 2018 at 2:23 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > Hi Aaron, > > > > Thanks for this patches. > > > > I'm afraid these are not applicable for current NFP driver after commit > > Okay. > > > "net/nfp: add NFP CPP support" > > > > which has been accepted in dpdk-net-next. > > I think nfp_acquire_process_lock() can be modified as I did in 2/2, but > I noticed that there's some reliance on various sysfs files (and I think > you point this out in your response to 2/2 as well) and that may be > problematic for us with ovs2.8+. I'll do some more digging. > If OVS always relies on VFIO, then it is fine and this patch makes sense. > > Thanks Alejandro! > > > However, those could be valid for stable versions. I have comments on > both patches. > > Cool. As I noted, I haven't tested them yet, but once I get time to > test them I will pull in any feedback and resubmit. I guess if I do, > they should really just be for stable fixes? Not sure how that would > work. > > Not sure how this needs to be done. Stable versions pull from main branch just for bug fixing applied patches. Maybe it is worth to discuss. Adding stable email. > > On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole > wrote: > > > > Two fixes, one which is fairly obvious (1/2), the other which may > > allow support of non-root users. These patches are only compile tested > > which is why they are submitted as RFC. After a proper test, will > > resubmit them as PATCH (with any suggested / recommended changes). > > > > Aaron Conole (2): > > nfp: unlink the appropriate lock file > > nfp: allow for non-root user > > > > drivers/net/nfp/nfp_nfpu.c | 25 +++++++++++++++++++++---- > > 1 file changed, 21 insertions(+), 4 deletions(-) > > > > -- > > 2.14.3 >