From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 1CF2A1B638 for ; Fri, 13 Apr 2018 09:26:56 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id x82so2399110wmg.1 for ; Fri, 13 Apr 2018 00:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4EMYRFzox9AkshokgS0CraibK+SJAKfT04K8bs2tMAg=; b=H0epndjh0/Rnv8GKe9BZOneNjBuPkE/yWdSEX8KSorHyXNZSFMmxYzFM1NcuaM/wVP DrrM4a6FgWqa2exfPhvqSdfQ/3hWGEEEerxeS9k/Ib2/lS8NXWKt9SB7R3zjtkDxeSyW WddeQnF1z0gopdmaNFtJZnFPWqH1EWuPKCpDwEfVNHOVGkRgGcQdF0aSfCUjo55cZnL0 CC2d9Gr4woPrvBsR0s9p1qp8a2pptcO7N+EfY33p72OwV3kMDPNmpxa98prvJQY4c4LF xHMViT9HbkyPaPMp6as7PM51AJrqrcxMu+dsGjW9FnAnUr28uxaASJ6gs+wS8/qE/JPK d//A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4EMYRFzox9AkshokgS0CraibK+SJAKfT04K8bs2tMAg=; b=oeHlqaIlK5oBJiK+cCFHmK24cnU4AieTKqfaFn9zUIahzylbyxwwxfcMoCjdWheI6i RiQMViwnAG6Yaze7nT8g+IWhkzsdPqk2bsk08mrHzY+wRUwjYSjM2UU9TJ+5wAT5Nub8 sQfRaHgs36jndH/ZVbG9qY82k1g/lPIkxV2c3ax/shH8AD7nI7dNa2Dk3osaBlCyr5Pa OL4nR4Prf5mA0ZX/6ccmUu9nz4TFLKUzEo8Br3dzReubwqOrYUgUZYddQRyTdvTWn7fz sAPT5+h/RBE5VBXCGKKg/QMDzFNZHGFevwj3jXbiVcYfAdAZz5hKcYpHFpMvVMpT1Iq0 98Cg== X-Gm-Message-State: ALQs6tBS3f8a53hNEv/gl6MSP/lMbA/GciCi6Eg0suN5TMpgPy/qxhqY LXMaYJxID73iIAhUTjeZZDOMMUkhQrVSV8PutfcCxw== X-Google-Smtp-Source: AIpwx4/4l5COp3dVPk5dvLrKVh8x0L+Tf0NOE9yNdUIkSBLoatNLoyTu1IjzcxJQstclS9H4x/pxsOsxTkjnohk4tQE= X-Received: by 10.80.243.16 with SMTP id p16mr19293064edm.101.1523604415881; Fri, 13 Apr 2018 00:26:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.203.69 with HTTP; Fri, 13 Apr 2018 00:26:55 -0700 (PDT) In-Reply-To: <20180412222208.11770-1-aconole@redhat.com> References: <20180412222208.11770-1-aconole@redhat.com> From: Alejandro Lucero Date: Fri, 13 Apr 2018 09:26:55 +0200 Message-ID: To: Aaron Conole Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 0/2] nfp driver fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 07:26:56 -0000 Hi Aaron, Thanks for this patches. I'm afraid these are not applicable for current NFP driver after commit "net/nfp: add NFP CPP support " which has been accepted in dpdk-net-next. However, those could be valid for stable versions. I have comments on both patches. On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole wrote: > Two fixes, one which is fairly obvious (1/2), the other which may > allow support of non-root users. These patches are only compile tested > which is why they are submitted as RFC. After a proper test, will > resubmit them as PATCH (with any suggested / recommended changes). > > Aaron Conole (2): > nfp: unlink the appropriate lock file > nfp: allow for non-root user > > drivers/net/nfp/nfp_nfpu.c | 25 +++++++++++++++++++++---- > 1 file changed, 21 insertions(+), 4 deletions(-) > > -- > 2.14.3 > >