From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 895A71CC75 for ; Thu, 5 Apr 2018 16:39:45 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id g8so6348265wmd.2 for ; Thu, 05 Apr 2018 07:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=n4hMzC1jwrJZEjiKye8beCl+nvnilb72i6kpD91T7h8=; b=0LEgGdk8HvWG/l0CggOQk04chXC1ZFL7Fjlx3XkZGIpzjog/j5ImGU7LljjVWEpWPh 9hDhjQEJIa1cCf7zwn1BDQwHY4gzCQuECfs94yWpn46la1BZIGFxKYB+OlP04z+K6c0p V/NqYBtwAlUFRvMxeG18eTbUxoG0Sp4B3X88uY9IAA/yJR9xbPcphwyiyRRqmg5tbPbx fI6ZwOi01sPHnB7phf19upMpfbNxx9d3owIYp/AnZCzp5G5s00n7Z/hbL1AgcOkOm/St TjBaUY+1fJumgAfn2JnCwzdqq+fZhZ80qxdo0+GtW3anPdI9Q5Cyi+q/sNLOK89AsKlY Y/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=n4hMzC1jwrJZEjiKye8beCl+nvnilb72i6kpD91T7h8=; b=KYdGgbc38XlCb62sZUcLN5PRaV1JJXZj8Oo1uVwpFyNGJtzqMzdCANemIOAd8olYHW 6mnTt62JyoAahTElrHyJV4rFMrjyq+A08+gOeYdVVlnmKPxjy8+s3MDhfrcFKSX8LlHa VjmQDxi8CZasGLzBERIUAzeve2Y3b7Onzfwx59e5xDMrUHmyXGkEXcaVzOu1RWvC0jMA zMdc71cqgA6nPQmGaxyGvZ3DpxpBpym6AsX5blmNGHayfekEwHg+NeFK7hj25cu3/Q8V XGvybPP66M03gkRg8A0IZ0DfWyEjZdbGIm5Heh399zAPpBoHAPjRRgy1JhPxONg8DoiY yPeQ== X-Gm-Message-State: ALQs6tCwiZo7vYUf2geqqjg3pa/Nc/uDjW/mTkgDdxf0SH5+H4d7J8zR CJno4bHtqW+cU4MfNlIwrIq2aNGgFox+0OlvO2tk4A== X-Google-Smtp-Source: AIpwx49vimVcZiUb2ckfrWPnx4Tt+8Hk0NrsexvtvdsgFSnllA+pqUD7fz/P/hUQ5FvFXb24rFsigmWnl7avTV/bpv0= X-Received: by 10.80.139.1 with SMTP id l1mr3209614edl.299.1522939185106; Thu, 05 Apr 2018 07:39:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.203.69 with HTTP; Thu, 5 Apr 2018 07:39:44 -0700 (PDT) In-Reply-To: <1522938510-5156-1-git-send-email-alejandro.lucero@netronome.com> References: <1522938510-5156-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Thu, 5 Apr 2018 16:39:44 +0200 Message-ID: To: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 0/4] NFP PF support based on new CPP interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 14:39:45 -0000 I did not create the patchset with the -v flag so just the first one has the v2 tag. I will remove the patches and send them again. Apologies. On Thu, Apr 5, 2018 at 4:28 PM, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > NFP PMD PF support requires to access the NFP chip for initialization. > Current NFP PMD PF support was added based on the NSPU interface. This > implies to do initialization through the NSP, a embedded ARM processor > which does initialization tasks on demand. The main problem with this > approach is it requires to add support for new NSP commands each time > a new functionality is required, which does not scale well and it is > not really flexible. > > Using the new CPP user space interface, the PMD can do whatever could > be done by the NSP, this is current commands and any new functionality > required. This CPP interface allows to access any single chip component > facilitating initialization, firmware uploading, firmware debugging or > extended stats. > > The changes just change the PMD PF initialization and do not touch the > datapath at all. No performance changes nor PMD functionalities are > affected. > > The initial impact using the new CPP interface is the way firmware upload > is handled, which helps the PMD detecting the card type and the firmware > file > to upload. Future commits will include extended stats and some sort of > debug > channel. > > The specific CPP code is contained in the first patch, which has not been > splitted up because is completely internal to the NFP functionality. The > second patch makes the PMD changes required for using the new interface. > > v2: > - removing unused reference to zlib.h > - fix build errors > - add SPDX tags in new files > - rebase changes nfp.rst > > Alejandro Lucero (4): > net/nfp: add NFP CPP support > net/nfp: update PMD for using new CPP interface > doc: update NFP guide > net/nfp: remove files > > doc/guides/nics/nfp.rst | 34 +- > drivers/net/nfp/Makefile | 17 +- > drivers/net/nfp/nfp_net.c | 342 +++++--- > drivers/net/nfp/nfp_net_eth.h | 82 -- > drivers/net/nfp/nfp_net_pmd.h | 16 +- > drivers/net/nfp/nfp_nfpu.c | 108 --- > drivers/net/nfp/nfp_nfpu.h | 55 -- > drivers/net/nfp/nfp_nspu.c | 642 --------------- > drivers/net/nfp/nfp_nspu.h | 83 -- > drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h | 722 +++++++++++++++++ > drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 36 + > drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h | 592 ++++++++++++++ > drivers/net/nfp/nfpcore/nfp6000/nfp6000.h | 40 + > drivers/net/nfp/nfpcore/nfp6000/nfp_xpb.h | 26 + > drivers/net/nfp/nfpcore/nfp_cpp.h | 776 > ++++++++++++++++++ > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 936 > ++++++++++++++++++++++ > drivers/net/nfp/nfpcore/nfp_cppcore.c | 856 > ++++++++++++++++++++ > drivers/net/nfp/nfpcore/nfp_crc.c | 49 ++ > drivers/net/nfp/nfpcore/nfp_crc.h | 19 + > drivers/net/nfp/nfpcore/nfp_hwinfo.c | 199 +++++ > drivers/net/nfp/nfpcore/nfp_hwinfo.h | 85 ++ > drivers/net/nfp/nfpcore/nfp_mip.c | 154 ++++ > drivers/net/nfp/nfpcore/nfp_mip.h | 21 + > drivers/net/nfp/nfpcore/nfp_mutex.c | 424 ++++++++++ > drivers/net/nfp/nfpcore/nfp_nffw.c | 235 ++++++ > drivers/net/nfp/nfpcore/nfp_nffw.h | 86 ++ > drivers/net/nfp/nfpcore/nfp_nsp.c | 427 ++++++++++ > drivers/net/nfp/nfpcore/nfp_nsp.h | 304 +++++++ > drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 109 +++ > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 665 +++++++++++++++ > drivers/net/nfp/nfpcore/nfp_resource.c | 264 ++++++ > drivers/net/nfp/nfpcore/nfp_resource.h | 52 ++ > drivers/net/nfp/nfpcore/nfp_rtsym.c | 327 ++++++++ > drivers/net/nfp/nfpcore/nfp_rtsym.h | 61 ++ > drivers/net/nfp/nfpcore/nfp_target.h | 579 +++++++++++++ > 35 files changed, 8334 insertions(+), 1089 deletions(-) > delete mode 100644 drivers/net/nfp/nfp_net_eth.h > delete mode 100644 drivers/net/nfp/nfp_nfpu.c > delete mode 100644 drivers/net/nfp/nfp_nfpu.h > delete mode 100644 drivers/net/nfp/nfp_nspu.c > delete mode 100644 drivers/net/nfp/nfp_nspu.h > create mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > create mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h > create mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > create mode 100644 drivers/net/nfp/nfpcore/nfp6000/nfp6000.h > create mode 100644 drivers/net/nfp/nfpcore/nfp6000/nfp_xpb.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_cpp.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_cppcore.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_crc.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_crc.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_hwinfo.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_hwinfo.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_mip.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_mip.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_mutex.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_nffw.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_nffw.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_nsp.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_nsp.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_nsp_cmds.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_nsp_eth.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_resource.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_resource.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_rtsym.c > create mode 100644 drivers/net/nfp/nfpcore/nfp_rtsym.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_target.h > > -- > 1.9.1 > >