From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f173.google.com (mail-ua0-f173.google.com [209.85.217.173]) by dpdk.org (Postfix) with ESMTP id 953B7316B for ; Fri, 9 Dec 2016 11:08:54 +0100 (CET) Received: by mail-ua0-f173.google.com with SMTP id 51so12860710uai.1 for ; Fri, 09 Dec 2016 02:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=evHXRwI9QDeyPi5QsZdgAnxzYvdb+axALozGMxbm1hI=; b=UUEHxM881dxkK8jjwaA+Bxfu8/Hx2ypnnSjLSQiyjwU5KRMgL7C75Dgy2DwkONKPxt QAJzaF09GBgpdZEeFboMPzizbyImpoQVtxSqUqYGzH0Ws1qMixo3jXPHIRXV/2rJmvYf XhgAiTTS+cxgKgvYvNLXQ4YpfGvTciqd2+CoOxhgBnsqeph0+POZlOOu/PatlENAl1B6 FN8A4jj1/Eya/RACVtq9supiPEW/2eEWH2InBV0Q1VorsytdS7ViaW3X66vOgMezHkYR L9XDqVjw5gygiNvJf1QEPPfhKUNKDd04P8YigCz48trR4mVKnj37tBXIzuT5HHknOluS NQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=evHXRwI9QDeyPi5QsZdgAnxzYvdb+axALozGMxbm1hI=; b=kSXaikTWAU7CyayRNIR2d5Qkk1yTbIAmke5/R1BbIk1Mh4ndqyhJNAXkQH0ZeN1qay t2f5+wrnC6Q+1DoT+T0yXdwNjnoTQ0gkxCmeFMHa0yFoHp51O0Zvmb2g6Jup3pEsg6C6 aUKlAByP07PljPeUwauguZOJNYrplUlTPubIUKNMGB9wPZV37Q1VsY9S2RupzEPxSkuW RcsztUvKP34ixd7mpmlevxi9ziA5NHAp2LH6IaVdmwCHAS2AZgANgI8l6nim8VsOu+hb Ck2ig2Q7ahRWZ6C5bFqp+gqXEaaJ2k+YxPAnjoCReCkvNG4S5kGlSPwcK2WLCf6EPU2x O2gw== X-Gm-Message-State: AKaTC01cyVgBgn9tSSyu4F2uuaHTIbGvWJUMYwB9tsifFj/yzvPLf8pfK5aAiOCVXihleqsvOqpcBhTAxK6AMteL X-Received: by 10.159.40.97 with SMTP id c88mr35351529uac.17.1481278134119; Fri, 09 Dec 2016 02:08:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Fri, 9 Dec 2016 02:08:53 -0800 (PST) In-Reply-To: References: <1480669552-10411-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Fri, 9 Dec 2016 10:08:53 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 10:08:54 -0000 On Tue, Dec 6, 2016 at 11:57 AM, Ferruh Yigit wrote: > On 12/2/2016 9:05 AM, Alejandro Lucero wrote: > > Previous reported speed was hardcoded. > > > > v3: remove unsed macro > > v2: using RTE_DIM instead of own macro > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 28 ++++++++++++++++++++++++++-- > > 1 file changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index c6b1587..24f3164 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -816,6 +816,17 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw) > > struct rte_eth_link link, old; > > uint32_t nn_link_status; > > > > + static const uint32_t ls_to_ethtool[] = { > > + [NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = > ETH_SPEED_NUM_NONE, > > + [NFP_NET_CFG_STS_LINK_RATE_UNKNOWN] = > ETH_SPEED_NUM_NONE, > > + [NFP_NET_CFG_STS_LINK_RATE_1G] = ETH_SPEED_NUM_1G, > > + [NFP_NET_CFG_STS_LINK_RATE_10G] = > ETH_SPEED_NUM_10G, > > + [NFP_NET_CFG_STS_LINK_RATE_25G] = > ETH_SPEED_NUM_25G, > > + [NFP_NET_CFG_STS_LINK_RATE_40G] = > ETH_SPEED_NUM_40G, > > + [NFP_NET_CFG_STS_LINK_RATE_50G] = > ETH_SPEED_NUM_50G, > > + [NFP_NET_CFG_STS_LINK_RATE_100G] = > ETH_SPEED_NUM_100G, > > + }; > > + > > PMD_DRV_LOG(DEBUG, "Link update\n"); > > > > hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > @@ -831,8 +842,21 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw) > > link.link_status = ETH_LINK_UP; > > > > link.link_duplex = ETH_LINK_FULL_DUPLEX; > > - /* Other cards can limit the tx and rx rate per VF */ > > - link.link_speed = ETH_SPEED_NUM_40G; > > + > > + nn_link_status = (nn_link_status >> NFP_NET_CFG_STS_LINK_RATE_SHIFT) > & > > + NFP_NET_CFG_STS_LINK_RATE_MASK; > > + > > + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || > > + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && > > + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) > > + link.link_speed = ETH_SPEED_NUM_40G; > > Same comment from previous review: > > For specific firmware version, speed is still hardcoded to 40G, can you > please mention from this and if possible its reason in commit log? > > Well, we have old firmware still around and we need to avoid reading this info from hardware if not supported. But I guess I could be a more chatty about this in the commit log. I will send another version. > > + else { > > + if (nn_link_status == NFP_NET_CFG_STS_LINK_RATE_UNKNOWN || > > Again from previous review: > > > This is for checking any wrong value from firmware/hardware. > > I see, but removing this check will not change the logic, else branch is > taken and again same value set. > > OK. I think I can remove the first part of the if clause, because it is implicit in the second part. I guess this is what you really meant, and not just to leave the else statement (without the else, of course). am I right? > Still if you deliberately prefer to keep it, that is OK. > > > + nn_link_status >= RTE_DIM(ls_to_ethtool)) > > + link.link_speed = ETH_SPEED_NUM_NONE; > > + else > > + link.link_speed = ls_to_ethtool[nn_link_status]; > > + } > > > > if (old.link_status != link.link_status) { > > nfp_net_dev_atomic_write_link_status(dev, &link); > > > >