From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 0A56B6CCC for ; Thu, 26 Apr 2018 20:14:25 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id w195so14550416wmw.2 for ; Thu, 26 Apr 2018 11:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FljIYhLbmi2bzi3fFwkMlkTVnUqIA0tiuGRqkqhjmKg=; b=m7IFwykwRJtyf7unqdJMUk36KujzmPZwuKprR8XV688dCo/XWu9YKMKb61jKZ2fZgp xm6H1brr2bvw3xnwq5iePppOvO5TN4c3XsYQBToBbU0wNPGFbpTVSkts0UNWjpTkV7Jp UHZDpcqxQtC9nfEl8OC29+1/dJ5SD08hWK2oc7D11M2bGezGa17NCgQ3G2x8N9ekN4b9 jC4tJwpjrqsNsTmMEBZub1aZ7vdUNYUpRnz9zjH45TDf/QdZvmO0Xz6+PLTrXsVfFrTg /MM4Q5X01ruhFNfFAbDSHStycyO0BK1VBCixTStBZ8gfVqCDOOzSdMCETYEZAfVe8Kpz Qkhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FljIYhLbmi2bzi3fFwkMlkTVnUqIA0tiuGRqkqhjmKg=; b=LhB4zd1oxHlVPuvD1iPW0CfLENL4lrGzQkGFa2dCaGvrmISQF5D1rTUasvnqfdh7Yf rcEj3Rcs5R9k784oxBC91Wcroc0h9wumttd0+XVJpSOySBm7LRkkwK7mattSpJXVKOzT SXT8K2whfyGVDpRS3G4Y/9xkfj3olyMZ+V8a8uNTgC3UXWgFwVwSXAwfeX0+zzs/5mm0 NSWKgO+GUhNXU1BVGQcprz9WTApSnx+j1Dz17Kbjw+iD5sh4f4c6N6sZL7vd8pgbhJ72 4JswcHMYPuMpVeWGvkgsvqECP6M8YFgoVXSBFuigeKaLCYxfKJFYVRIZoHehcpvDZpSR lzqQ== X-Gm-Message-State: ALQs6tDcxYGUHyv5CwYxDWH1m4ulkRDzgqOVmSkvYKrMfnGuimis0tiu sQDrDfiYNiMpwLeKmAEfBT0RmbwmwO20ifW5uWas7HDk X-Google-Smtp-Source: AIpwx48v5KplENZEL+1+vEIFem6H7gxVhhLVbsyhz1GBO8mKflwS2uWqLcqJcjhzyFupkNl2uWvBPMOjXkpbgYFpkoI= X-Received: by 10.80.240.199 with SMTP id a7mr46079894edm.90.1524766464760; Thu, 26 Apr 2018 11:14:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.212.197 with HTTP; Thu, 26 Apr 2018 11:14:24 -0700 (PDT) In-Reply-To: <20180426084253.1a615c82@xeon-e3> References: <20180425154551.6795-1-stephen@networkplumber.org> <20180426084253.1a615c82@xeon-e3> From: Alejandro Lucero Date: Thu, 26 Apr 2018 19:14:24 +0100 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 18:14:25 -0000 On Thu, Apr 26, 2018 at 4:42 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Thu, 26 Apr 2018 13:52:53 +0100 > Alejandro Lucero wrote: > > > Hi Stephen, > > > > Thanks for this patch set. > > > > I'm happy with it although I have some concerns regarding how the dynamic > > logs work, or maybe I have a wrong understanding about it. I have tried > to > > read some doc about how it works, and I found the original patch from > > Olivier the best source, so maybe things have changed a bit and my > concerns > > are unfounded. > > > > I think it is OK to specifically add something like > > > > --log-level='pmd\.i40e.*,8' > > > > if you want to debug a PMD, but if you are an user and you just want to > > know why the app is not finding any port, finding out the right string is > > not trivial. For example, with an PF, the NFP PMD goes through a process > > where the NFP device (no the NIC) is accessed first through a complex > > interface, then firmware is uploaded, DPDK ports created (for multiport > > devices), etc. I think any error in that process should be output if the > > right loglevel is there and not just if the right log type was > specifically > > enabled. Is this what would happen with your patchset? > > Most drivers set default log level to NOTICE. Then if they see something > obviously wrong it will show up if the right log level is used. > For the case of finding out why no drivers are found then doing > something like > --log-level='pmd.*:info' > would be useful. > > Latest version makes regex optional and allows symbolic levels. > > > > I have suffered silent configuration problems, like the NFP card being in > > the wrong NUMA socket, and although I can solve that quickly because I > have > > the knowledge, other people using NFP with DPDK require someone to help > > because they do not know what is going on. And this is usually bad > because > > they have another NIC card in the same host (in the right NUMA socket) > and > > the app just works smoothly then, leaving our NIC with a bad press. So I > > think, some errors should always appear with the right loglevel > configured. > > Driver should definitely use level > INFO for things that are wrong. > > Uhmm, yes. I think I need to submit some changes to the level of most of the PMD messages. Thanks for the heads up. I have reviewed and tested the patches and they all seem all right. Acked-by: Alejandro Lucero Tested-by: Alejandro Lucero