From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com [209.85.213.47]) by dpdk.org (Postfix) with ESMTP id 818F35A44 for ; Thu, 12 Jan 2017 13:12:53 +0100 (CET) Received: by mail-vk0-f47.google.com with SMTP id 137so11099323vkl.0 for ; Thu, 12 Jan 2017 04:12:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6q2aSQC/ZWym//nH7OlltUvAYcw557yUzgf5YPF7EcQ=; b=hzNcMsUWWAhO/BFr+wzFmbU5Cz5BNbfgwZCsNV7jZvE9WGbM4i86TNjnP28lYvqhij rodSBcD8+B9swJuxKph3tlW0RIkNapD5pmRlZZBF2qd+PlscwjQcXjN7nMLbi13SwJTx v37zrPpoaYQ6hU+8fyrXxPsz2Tjp+h+kw4OopiflkdReGXmWc+rEmjG5RPewBTIQ60ng M+2JeWWEpLcrPhiFjoEnajSkVxhc33K43YUcVfO+2RHiha0fQSYd3SN+RsDGlvnTMg3C PJ4ScZ4Jyjxa6/Zky6d8WBemLtYdha8bKwc8ruJQ97EXiEy+IBY9m8JKIVJCoHJNSdNv SbtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6q2aSQC/ZWym//nH7OlltUvAYcw557yUzgf5YPF7EcQ=; b=ETrRKL+KlfRwgc4i9uLwTWsS5v4a21MHSU90Des7U2qsuFiEgyR2bdzXN9UCvCaBeL djS4pJA+3U/lM/ybyf/lcI3IkFdSnlXeeTPvzCMm5MsuLo55/saVAGjPU6i/BFC8jp6m ww20kQE+wmKvkHC53Rjmeobj15Y2qyVpJkVsXWnhi43PKLR40wTSNfU1kFaylNS1yiHi UUH6bcdFSKR0QMWv0fX9On63nu0FBUAnB9sVadmItsHo+6ZJRSj1z8ReDeR9/7P0g+Gv 1q17iCyv+AYiYY+L3FosIOVuU+iZ1CbkRGWdkG0QFEvXLMd5y3vRkH7lyzt8ZgJiwUO3 Ol/Q== X-Gm-Message-State: AIkVDXIyUGqUHH77JQBC0Wa4gpnvZ6OkUGWPBN5IAbbkaQkr8ujCQg7Szb6ZhPK+G4eVelZ4OL0I/xtfSOoZwSHG X-Received: by 10.31.0.67 with SMTP id 64mr6546568vka.167.1484223172820; Thu, 12 Jan 2017 04:12:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.146.141 with HTTP; Thu, 12 Jan 2017 04:12:52 -0800 (PST) In-Reply-To: <608e7dfd-5226-3e30-f43b-0fbe01aee16a@intel.com> References: <3355891.l3I590SjcV@polaris> <608e7dfd-5226-3e30-f43b-0fbe01aee16a@intel.com> From: Alejandro Lucero Date: Thu, 12 Jan 2017 12:12:52 +0000 Message-ID: To: Ferruh Yigit Cc: Gregory Etelson , dev , users@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 12:12:53 -0000 On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit wrote: > On 12/9/2016 8:54 AM, Gregory Etelson wrote: > > Hello, > > > > IGB_UIO driver does not close port PCI activities after DPDK process > exits. > > DPDK API provides rte_eth_dev_close() to manage port PCI, > > but it can be skipped if process receives SIGKILL signal > > I guess I understand the problem. > This is a known problem, but it is not just a UIO problem, and this patch does not solve it, maybe it just solves part of it. In fact, a DPDK program crashing could imply the NIC DMAing after that and after that memory was assigned to another program. > > > The patches below provide IGB_UIO release callback and IXGBEVF release > function > > But adding ixgbe specific code into igb_uio may not be good idea. > Can be anything done one upper layer, pci layer, generic to all drivers? > > This module is not just being used for Intel cards, so this addition will break, at least, the NFP PMD support. I was told to use igb_uio instead of adding a new NFP uio driver, so I guess that implies this igb_uio driver should be considered not only a igb driver. > > With the patches, each time DPDK process terminates, > > UIO release callback will trigger port PCI close. > > On the down side, patched IGB_UIO can be bound to a single adapter type > > > > Regards, > > Gregory > > <...> >