From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f170.google.com (mail-ua0-f170.google.com [209.85.217.170]) by dpdk.org (Postfix) with ESMTP id F122D2C40 for ; Fri, 18 Nov 2016 16:42:19 +0100 (CET) Received: by mail-ua0-f170.google.com with SMTP id 51so173580581uai.1 for ; Fri, 18 Nov 2016 07:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rK4G5PeKgD/kpMyTpxeBFyg4SLaPdDmGx6GVxLgX+ls=; b=sxsawQJjMh8ohDHR/oSgpBF//ZaT7/VKR2vY92LHxQtyPbZo1iDjFQvZTjggA5yqxq NXitGB/56ztzoXX2sJgNzMT5UMszxBRijpd/ZoCUfRTrytS83S0kjhaSh1N+bZ1RvRAI 5vDx5uHewf4jeax36NbWsQq8pSD9ZB1dU95UJudXtGK+nEzMsiiI8VSD8wPRaZyRPqLn d0s9D9DpSaBDXVua/G6A7B9Gsy98gF6LyflwdSSrTe+1wChL0j1bjqmaZ4JZLxNwqkWo xnZ+EQopQgixZB3T8Q5MlSivnmjuQL5j/TSkVNvBcnTN0ZIm4w/+8w/UhFiYTS90CzKm aeFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rK4G5PeKgD/kpMyTpxeBFyg4SLaPdDmGx6GVxLgX+ls=; b=myub7iXJrvqoETzUUSN20ja/Z+ACljvfDeBisS08yTK6iECiMScL0VioirWJV+9Rd/ r8m5nAr+5YcQHlQb3O5qXW/asc8tObB+NXsrBdtkerfjo++M/uFNSjYQ6heX16pH4ahL Y/QqnQUkh2fLKe7GgsoaEuZIlyrZbewmywdV4gKplqruE2iBdNwvppSXjJpnCeSIFiuB 4yjS3N99Lkxl0g0Ie2a6PSsoZ6tPHpVNa/iAhtcqrzxvFRf79qcvF55Gfh5407TLAgh/ 5+xRlyYKwj/ksu9CzD+wxNke7a3C1kz2a4SUxQkQ8hSIa/2Evee6mjIei5nV4OSDWk2X Y9sQ== X-Gm-Message-State: AKaTC0186isJ3QocI5+ozzSrrmjjrJpZ5YJg7986266tUgpSlh4IY0ef7T1f1H8aIrB40MUnu7CgrlhidR4tjViN X-Received: by 10.176.69.171 with SMTP id u40mr232281uau.24.1479483739263; Fri, 18 Nov 2016 07:42:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.79.145 with HTTP; Fri, 18 Nov 2016 07:42:18 -0800 (PST) In-Reply-To: References: <1479481467-29431-1-git-send-email-alejandro.lucero@netronome.com> <20161118150433.AD575558B@dpdk.org> From: Alejandro Lucero Date: Fri, 18 Nov 2016 15:42:18 +0000 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 15:42:20 -0000 On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > > > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > >> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: >> > Hi Thomas, >> > >> > I got this email when sending a patch some minutes ago. >> > >> > The point is I trusted script/checkpatches.sh which did not report those >> > warnings. >> > Am I doing anything wrong when using checkpatches.sh? >> >> I am also getting same warnings as below, this can be related to the >> checkpatch.pl version. >> >> I have: Version: 0.32 >> (./scripts/checkpatch.pl --version) >> >> > Uhmm, I got same one. > > Ok. It seems I suffered a temporal blindness. I though the automatic report was about warnings but it is about checks. But I got just one of the checks messages. This is the output with -v and adding OPTIONS used: ### [PATCH] nfp: report link speed using hardware info OPTIONS: --no-tree --max-line-length=80 --show-types --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,NEW_TYPEDEFS,COMPARISON_TO_NULL CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #60: FILE: drivers/net/nfp/nfp_net.c:856: + else { + total: 0 errors, 0 warnings, 1 checks, 68 lines checked 0/1 valid patch > > >> > >> > ---------- Forwarded message ---------- >> > From: >> > Date: Fri, Nov 18, 2016 at 3:04 PM >> > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info >> > To: test-report@dpdk.org >> > Cc: Alejandro Lucero >> > >> > >> > Test-Label: checkpatch >> > Test-Status: WARNING >> > http://dpdk.org/patch/17091 >> > >> > _coding style issues_ >> > >> > >> > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible >> side-effects? >> > #53: FILE: drivers/net/nfp/nfp_net.c:806: >> > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) >> > >> > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' >> > #91: FILE: drivers/net/nfp/nfp_net.c:856: >> > + else { >> > + >> > >> > total: 0 errors, 0 warnings, 2 checks, 68 lines checked >> > >> >> >