From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alejandro.lucero@netronome.com>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
 [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 51ACB8DED
 for <dev@dpdk.org>; Tue, 17 Apr 2018 11:07:17 +0200 (CEST)
Received: by mail-wr0-f196.google.com with SMTP id d19so33331850wre.1
 for <dev@dpdk.org>; Tue, 17 Apr 2018 02:07:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netronome-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=4tn5pZTenXSwOGTeyf8TO5dhTvYywmX7V0sXQLIf38k=;
 b=WLpIgGh8k6ZQBhYW/qo+ppYmk5iZ69OhacKUOEcFlLRYo4JDL4JSPt66F2Qlz8k0m4
 3vTGwttrP5rp1u795T3FYCdRWapSYenN0KTlWVmccJjn4owQYHfJHI0O5d5PmfaJ9S0E
 10cHiyUAoe7gWzamy3p5NDDcG1bbgBOTAw5LyQFUfKio6umtmmp4kHl47h1iQ7LewWh1
 uL/WrC4ttoX5Tl1YXuNBTcyhN723hN3IgsvZEj1O9yf0RUyGMW1Hg1+Qd3gSFCSXoTpQ
 Zv9YrML7hUv0pTQsfg5J18vrv3H4W8rYNxuKO48/Yh+OYhJN0Eqn/UWo+r8AYgUWY9Zy
 tJ6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=4tn5pZTenXSwOGTeyf8TO5dhTvYywmX7V0sXQLIf38k=;
 b=nuXIn0dF67y48efQkSYq/To+nB2koqP3w85ovslJ7W4lg+wsuePcfR8xF/VmtU5BBN
 DpsPXbMppRFE1yl9qieafzUHdL0+Kh3R2/PcOoxk9iJjXLOgQ5DbEbnCzW/zb2S+4Fyh
 +Oc9ICF5Q9vAZtA1o6kLy0AHEofGRCHeBAX+4kpAnYuNDwhvVZiMlPBfscKGWwOxS7WJ
 Nz8/NdjKvRcox+2jMHirZtLGzufI9tMdcKU0o3W1t9MdxynZgg2EcrPKGp9iFQc/qbTW
 vsod0RkkTQH2//FVPcXui/fZPDdi3c8UVIGmSOIcNExSiCBN0dSQVBk1zlXF34hyaux5
 K9Ew==
X-Gm-Message-State: ALQs6tD6sPdVA8Qi14AdcG2ExH5eucEYpbWnPQB5316D9XwFnkRHQMTE
 Xd+CgfzxjaLUhZFAjBCJX8V/hwGREObZun0h9bo1OA==
X-Google-Smtp-Source: AIpwx4+8sWGBK2qC+OOeTTGQ6BMwuRoHEVIyYxgZYHWBtNPEm2FZR226OIOylcYSyTH6r4o5rJdjc4usP71Dtv/7A6I=
X-Received: by 10.80.189.130 with SMTP id y2mr2101801edh.138.1523956037110;
 Tue, 17 Apr 2018 02:07:17 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.80.212.197 with HTTP; Tue, 17 Apr 2018 02:07:16 -0700 (PDT)
In-Reply-To: <1523944748-13334-1-git-send-email-zhouyates@gmail.com>
References: <1523944748-13334-1-git-send-email-zhouyates@gmail.com>
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Tue, 17 Apr 2018 10:07:16 +0100
Message-ID: <CAD+H991xemg04yAoWQOUw2kThA46YoSVnMB1g-ESSWJonNEWxQ@mail.gmail.com>
To: Yangchao Zhou <zhouyates@gmail.com>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 09:07:17 -0000

Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>

On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:

> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index ad6ce72..f2fcc4a 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -816,6 +816,7 @@ struct nfp6000_area_priv {
>
>         if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
>                 printf("error reading resource file for bar size\n");
> +               fclose(fp);
>                 return -1;
>         }
>
> --
> 1.7.1
>
>