From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <alejandro.lucero@netronome.com> Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 7C6437292 for <dev@dpdk.org>; Thu, 26 Apr 2018 14:52:54 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id l16so13131747wmh.2 for <dev@dpdk.org>; Thu, 26 Apr 2018 05:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N+coxf9DEKPxXUfYKG2k8G0A+iD6V7x4xuIeADMS0uc=; b=evI+3Z2gPUBYmprEEThIFNoLkjpIzWLzDdqgf/7Om2plj8FO2BCBMR4lijiTnZ4EJb chGwkzxsxPbvE8ZW5Rz4SpZtrg90NY+WyaQtc6f6x+Y7L/QWwm20pHJwoPgvUlTQJoRX uddsWPMGz+QWi4w4mNUln4f3VuLObsE36KtIMaMgElGsG1e9x8NXdglja9p1jh7UF0QQ jUJ9BK2EVjAPC9bVOV8ue0hczsAP0RuSH4V9/wDFp9Jq1wHyadWDS0RJmmMu3ol5Nxmu 9K2+3CsQZ58BTdNvwsJEMZ7rjQOexx/TARIU8I5gInqbDN5+wDnCWkzr9c2MAIP5j5At 5EYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N+coxf9DEKPxXUfYKG2k8G0A+iD6V7x4xuIeADMS0uc=; b=Mu6wTFVm4HpDV6xuiBbJv9gnnXsmvoyYZF3ig/VBFIJI5MJxKcoDkKXv/Xb0YYfzHd HXJ0Bm7qKJ+aTJl3F4LKMiCHn600PBkN/AW4Ajmgj10MsudHObHmZONr3vthYI7LDn5u 4b+XKZJ4UMkLQkEh4TYreUj8ZU9/57fQjKmGEKj+HLuOdvehwKvQ4JmgN0HSlLlq9zl0 66ZJF2FveHd/LvRpkflFYnf6/nbUEccvnWa4whSdu1fRYh9Wqhw4iSh1qbf0nqjbcKka Xf4ANECApQW9YzQK6EhTxr0pVEFUXELe5iUkd+2KUbGf0ebTRFTPknQBhID63x/gz3kP toEw== X-Gm-Message-State: ALQs6tAAMHobuW1s2e2jrJze7Vjf5DGr3J4/q9RcsXp9CgrTfyjFAgmc dxVcXG65ZlhUbalrKZUwFQC2c3ipDRwQAKEJyLA4SQ== X-Google-Smtp-Source: AB8JxZpgVfLma2mbqSN5Cu4PACq8UwsJ0k9SuGEpU9+AzXjqkQRBlVHdWbsuoEkY6kST1e3WaS6+N7WH+tqKk+GmydY= X-Received: by 10.80.168.2 with SMTP id j2mr10370794edc.138.1524747174209; Thu, 26 Apr 2018 05:52:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.212.197 with HTTP; Thu, 26 Apr 2018 05:52:53 -0700 (PDT) In-Reply-To: <20180425154551.6795-1-stephen@networkplumber.org> References: <20180425154551.6795-1-stephen@networkplumber.org> From: Alejandro Lucero <alejandro.lucero@netronome.com> Date: Thu, 26 Apr 2018 13:52:53 +0100 Message-ID: <CAD+H992-ax+N2H4oEA7vF_FOiK7w7+X1pZ7S7PA2kt+FyCb-6g@mail.gmail.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev <dev@dpdk.org> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 26 Apr 2018 12:52:54 -0000 Hi Stephen, Thanks for this patch set. I'm happy with it although I have some concerns regarding how the dynamic logs work, or maybe I have a wrong understanding about it. I have tried to read some doc about how it works, and I found the original patch from Olivier the best source, so maybe things have changed a bit and my concerns are unfounded. I think it is OK to specifically add something like --log-level='pmd\.i40e.*,8' if you want to debug a PMD, but if you are an user and you just want to know why the app is not finding any port, finding out the right string is not trivial. For example, with an PF, the NFP PMD goes through a process where the NFP device (no the NIC) is accessed first through a complex interface, then firmware is uploaded, DPDK ports created (for multiport devices), etc. I think any error in that process should be output if the right loglevel is there and not just if the right log type was specifically enabled. Is this what would happen with your patchset? I have suffered silent configuration problems, like the NFP card being in the wrong NUMA socket, and although I can solve that quickly because I have the knowledge, other people using NFP with DPDK require someone to help because they do not know what is going on. And this is usually bad because they have another NIC card in the same host (in the right NUMA socket) and the app just works smoothly then, leaving our NIC with a bad press. So I think, some errors should always appear with the right loglevel configured. On Wed, Apr 25, 2018 at 4:45 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > These are several small changes to make the Netronome driver > use logging macros in the same way as other drivers. > > Compile tested only. I don't have Netronome hardware. > > Stephen Hemminger (5): > net/nfp: use correct logtype for init messages > net/nfp: add implied new line to PMD_DRV_LOG > net/nfp: fix double space in init log > net/nfl: add newline in PMD_RX/TX_LOG macros > net/nfp: use dynamic logging everywhere > > drivers/net/nfp/nfp_net.c | 186 ++++++++++++++++----------------- > drivers/net/nfp/nfp_net_logs.h | 9 +- > 2 files changed, 98 insertions(+), 97 deletions(-) > > -- > 2.17.0 > >